From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4B5DC531D0 for ; Mon, 27 Jul 2026 19:06:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1woQeb-0005lt-13; Mon, 27 Jul 2026 15:06:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1woQeZ-0005lY-DD for qemu-devel@nongnu.org; Mon, 27 Jul 2026 15:06:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1woQeX-0007Cm-TB for qemu-devel@nongnu.org; Mon, 27 Jul 2026 15:06:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785179176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mM5h3ubQZstLI8T1Ui9C4krWDKq5yQCBW2N0LqK792s=; b=fZjG7rJp2SzWX2X2hlrmTEWVC4Jr82QYiISxwPKkDsuvrF35OU27MUJBINriNK72WtGDl+ IOuaga+Nh1WWJoPj+dhugjWemLeTzTNS7LJDaarjUMfgCS2lEOD35V+R6D/YJ2qP1c2nM4 O21V+BWNj/nboL5p1001beX66YiUYbs= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-0hyJ2HrKMBiq2oioB9mdxg-1; Mon, 27 Jul 2026 15:06:11 -0400 X-MC-Unique: 0hyJ2HrKMBiq2oioB9mdxg-1 X-Mimecast-MFC-AGG-ID: 0hyJ2HrKMBiq2oioB9mdxg_1785179169 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ECD561956072; Mon, 27 Jul 2026 19:06:07 +0000 (UTC) Received: from localhost (unknown [10.2.16.116]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D5F3E180058F; Mon, 27 Jul 2026 19:06:05 +0000 (UTC) Date: Mon, 27 Jul 2026 15:06:04 -0400 From: Stefan Hajnoczi To: Connor Kite Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Stefano Garzarella , Alex =?iso-8859-1?Q?Benn=E9e?= , Viresh Kumar , Gerd Hoffmann , Mathieu Poirier , Manos Pitsidianakis , Haixu Cui , Raphael Norwitz , Kevin Wolf , Hanna Reitz , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Paolo Bonzini , Fam Zheng , Milan Zamazal , Akihiko Odaki , Dmitry Osipenko , qemu-block@nongnu.org, virtio-fs@lists.linux.dev, "Gonglei (Arei)" , zhenwei pi , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Eric Blake , Markus Armbruster , Jason Wang , Peter Xu , Eugenio =?iso-8859-1?Q?P=E9rez?= , Alyssa Ross , Demi Marie Obenour Subject: Re: [PATCH RFC 05/15] vhost-user: add memory_isolation to VhostUserState Message-ID: <20260727190604.GD371693@fedora> References: <20260723-vhost-user-isolated-memory-v1-0-6b97c439eb28@gmail.com> <20260723-vhost-user-isolated-memory-v1-5-6b97c439eb28@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GRVu7jzoCipJ+wdN" Content-Disposition: inline In-Reply-To: <20260723-vhost-user-isolated-memory-v1-5-6b97c439eb28@gmail.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.58, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --GRVu7jzoCipJ+wdN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 23, 2026 at 03:30:04PM -0700, Connor Kite wrote: > @@ -73,12 +74,14 @@ typedef struct VhostUserState { > int memory_slots; > bool supports_config; > bool supports_inflight_migration; > + bool memory_isolation; > } VhostUserState; > =20 > /** > * vhost_user_init() - initialise shared vhost_user state > * @user: allocated area for storing shared state > * @chr: the chardev for the vhost socket > + * @memory_isolation: disables device access to guest memory "Device" is confusing because it has several meanings. "vhost-user back-end" would be clearer. "Disables" is also a little confusing because the vhost-user back-end still needs to access guest memory somehow. Memory access cannot be completely disabled. Something like "restricts vhost-user back-end access to guest memory via bounce buffers" could be clearer, but it's up to you. We probably don't want to repeat the full explanation in every comment about memory isolation, so it's fine to omit the details as long as there is user-facing documentation somewhere that explains what the feature does. --GRVu7jzoCipJ+wdN Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmpnrBwACgkQnKSrs4Gr c8g/dggAh1YcQjd3Z68P3Ps7X5qBR06hLTnzCcvxJcgUdkL/zhk2JRB8QNKknhvW S3BgaUom6aHcIvbo510pR/Y/IH0TqPU/IqKKwCRMS801ifd0K+Ma34s99i3vislo vq5zrfcfMuyWUKb3KFaiiwGpoRSIEMon+jyZvB2UxU+bfRvRvVDN1wP/1Wn+TsDK QRVDqg8Gzy4fWGB9YvM+OV6efVcOtLCTdzOLb/TVAFaxG0nJ3529x49lQHG5Myv+ i91ha0m/yl1XM/YMcTwIi8/ptgMgtPdqJPh8fSuU9d03ej4OM7bRsRkowrHE0+eq F+92L+IMyU7aR8Y1A1vdhcakQZ2IBw== =3u2s -----END PGP SIGNATURE----- --GRVu7jzoCipJ+wdN--