From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4AF4C531D0 for ; Mon, 27 Jul 2026 19:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c7MyEWcFLcoaE0w34JeUmxMjJYDXBwYaZRBn7Za/qEg=; b=G7EFnkgTSb0SvS 4y5bik6ZHun33qqE+p1gcF1rCLH/n3bGF9CIirCE98VDHCvJKC8M/3shhUIFCMnE2K4L9HyzjJhvp nPdjWvelecU/AUxFBAJly6qSAOb0yqiJnFzAA21nFOe4FYM8pwfrOeRNX0bUVDBYsuCSr99R7wbDb vTQ8gVxntAcZz+oeKTN7L8cNThvhvW6ZjGRz+/PkA3dsPwKO4yYdsQ37H/ASOEds1UZwa6dQNBVYD svBtWXOpPWdF5ADHXV95czFFXRYiXcyeivn3SdAbtDIKc8BGhin+yvkRF6Ixt9qWPkePSU0uF3wlK y+qqy88cAaRuVj8n0lCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1woRCj-00000003lwL-1e4k; Mon, 27 Jul 2026 19:41:37 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1woRCi-00000003lw9-2BGo for linux-phy@lists.infradead.org; Mon, 27 Jul 2026 19:41:36 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id ABB0760008; Mon, 27 Jul 2026 19:41:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFFDD1F000E9; Mon, 27 Jul 2026 19:41:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785181295; bh=NXZ01KRGPMGOj00getszVzMdpSsaQmnkNWAK37M3n/g=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=KsfBC8WKwAvkkFn307EM+YTnBJ6P+q+7aCNFiaalNL7KOP+jsQSbvTbRP9Ca6DE1h 2QoSJaw6r0L6CCLIbtd66vpbz7BzUp4oinbTEgBVsV3oVtJw9Amn8XbDJCNj1Xekf3 34BqQOHy5JPpwgGH8w+DFByeYYb8KHYn3UsSJhHf9MEXxSh+XC5IVSctDex588K7h1 2Sn4jpAYmzcnth0F65JJHUdqPK6h2TX+7XlDMp27/g3ktNZJ3zyxOKDz83CPBLLO4S 48DbVj7BYG8b9S6AaMHIjdt8BT19eL8XuS7OgHTdjwv5e4pJbdde/OnqZtuokQ3UX0 U/FglnuaT2ivQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v8 09/12] clk: zte: Introduce a driver for zx297520v3 matrix clocks To: =?utf-8?b?U3RlZmFuIETDtnNpbmdlcg==?= Cc: neil.armstrong@linaro.org, devicetree@vger.kernel.org, robh@kernel.org, mfd@lists.linux.dev, vkoul@kernel.org, olteanv@gmail.com, conor+dt@kernel.org, linux-phy@lists.infradead.org, lee@kernel.org In-Reply-To: <20260727-zx29clk-v8-9-7a107b00f1dd@gmail.com> References: <20260727-zx29clk-v8-0-7a107b00f1dd@gmail.com> <20260727-zx29clk-v8-9-7a107b00f1dd@gmail.com> Date: Mon, 27 Jul 2026 19:41:34 +0000 Message-Id: <20260727194134.EFFDD1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gVGhlIHVzZSBvZiBgY2xr X21haW5bMF1gIHRvIGluaXRpYWxpemUgZmllbGRzIGluIHN0YXRpYyBnbG9iYWwgYXJyYXlzIGlz IGludmFsaWQgQyBhbmQgY2F1c2VzIGEgY29tcGlsYXRpb24gZXJyb3IuCi0tCgotLS0gUGF0Y2gg WzldOiBbUEFUQ0ggdjggMDkvMTJdIGNsazogenRlOiBJbnRyb2R1Y2UgYSBkcml2ZXIgZm9yIHp4 Mjk3NTIwdjMgbWF0cml4IGNsb2NrcyAtLS0KY29tbWl0IDg5NWQwOTVlOWUyMWQ4NGVhZWZlZmIy ZTI4ODFhNGY4MTkzZWY0NTAKQXV0aG9yOiBTdGVmYW4gRMO2c2luZ2VyIDxzdGVmYW5kb2VzaW5n ZXJAZ21haWwuY29tPgoKY2xrOiB6dGU6IEludHJvZHVjZSBhIGRyaXZlciBmb3IgengyOTc1MjB2 MyBtYXRyaXggY2xvY2tzCgpUaGlzIGNvbW1pdCBpbnRyb2R1Y2VzIGEgbmV3IGNsb2NrIGRyaXZl ciBmb3IgdGhlIHp4Mjk3NTIwdjMgbWF0cml4IGNsb2NrCmNvbnRyb2xsZXIsIHdoaWNoIG1hbmFn ZXMgaGlnaC1zcGVlZCBkZXZpY2VzIHN1Y2ggYXMgQ1BVLCBETUEsIFJBTSwgU0RJTywKYW5kIEV0 aGVybmV0LiBJdCByZWdpc3RlcnMgbXVsdGlwbGV4ZXJzLCBmaXhlZCBkaXZpZGVycywgYW5kIGdh dGVzIHdpdGhpbgp0aGUgY29udHJvbGxlci4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY2xrL3p0 ZS9jbGstengyOTc1MjB2My5jIGIvZHJpdmVycy9jbGsvenRlL2Nsay16eDI5NzUyMHYzLmMKPiBp bmRleCA0NDQ0YzJlYjEzODI1Li45Mjk5NDQ5MDk3YjRhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Y2xrL3p0ZS9jbGstengyOTc1MjB2My5jCj4gKysrIGIvZHJpdmVycy9jbGsvenRlL2Nsay16eDI5 NzUyMHYzLmMKWyAuLi4gXQo+IEBAIC01NDIsNiArNTQyLDM0MCBAQCBzdGF0aWMgY29uc3Qgc3Ry dWN0IHp4X2Nsa19kYXRhIHp4Mjk3NTIwdjNfdG9wY2xrX2RhdGEgPSB7ClsgLi4uIF0KPiArc3Rh dGljIGNvbnN0IHN0cnVjdCB6eF9nYXRlX2Rlc2MgengyOTc1MjB2M19tYXRyaXhfZ2F0ZXNbXSA9 IHsKWyAuLi4gXQo+ICsJLyogQm90aCAweDI0IGFuZCAweDI4IGJpdHMgMSBhbmQgMiBzdG9wIHRo ZSBDUFUuIFRoZXJlIGlzIGFsc28gYSBiaXQgaW4gdG9wY2xrKzB4MTM4LCB3aGljaAo+ICsJICog WlRFJ3MgdWJvb3QgY2FsbHMgIkE1MyByZXNldCIsIHdoaWNoIGFsc28gc3RvcHMgdGhlIENQVS4g SSBjYW4ndCByZWFsbHkgdGVsbCB0aGUKPiArCSAqIGRpZmZlcmVuY2UgYmV0d2VlbiBtYXRyaXgr MHgyOCBhbmQgdG9wKzB4MTM4LiBUaGUgY2xvY2sgKG1hdHJpeCsweDI0KSBjYW4gYmUgZGlzYWJs ZWQKPiArCSAqIGFuZCBlbmFibGVkIGZyb20gdGhlIENvcnRleCBNMCBhbmQgaXQgd2lsbCBuaWNl bHkgc3RvcCBhbmQgcmVzdGFydCB0aGUgQTUzLCByZXRhaW5pbmcKPiArCSAqIGFsbCBzdGF0ZS4K PiArCSAqLwo+ICsJR0FURShaWDI5NzUyMFYzX0NQVV9XQ0xLLCAgICAgICAgICAiY3B1LXdjbGsi LCAgICAgICAiY3B1LW11eCIsICAgICAgICAweDI0LCAgMSwKPiArCSAgICAgQ0xLX0lTX0NSSVRJ Q0FMKSwKPiArCUdBVEUoWlgyOTc1MjBWM19DUFVfUENMSywgICAgICAgICAgImNwdS1wY2xrIiwg ICAgICAgY2xrX21haW5bMF0sICAgICAgMHgyNCwgIDIsCj4gKwkgICAgIENMS19JU19DUklUSUNB TCksCgpbU2V2ZXJpdHk6IExvd10KRG9lcyB0aGlzIGNhdXNlIGEgY29tcGlsYXRpb24gZXJyb3I/ IEluIEMsIHN0YXRpYyBhcnJheSBpbml0aWFsaXplcnMgbXVzdAp1c2UgY29uc3RhbnQgZXhwcmVz c2lvbnMuIEFjY2Vzc2luZyBhbiBhcnJheSBlbGVtZW50IGxpa2UgY2xrX21haW5bMF0gcmVxdWly ZXMKcmVhZGluZyBtZW1vcnksIHdoaWNoIGlzIG5vdCBjb25zaWRlcmVkIGEgY29uc3RhbnQgZXhw cmVzc2lvbiBieSB0aGUgY29tcGlsZXIsCmFuZCB3aWxsIGxpa2VseSByZXN1bHQgaW4gYW4gaW5p dGlhbGl6ZXIgZWxlbWVudCBpcyBub3QgY29uc3RhbnQgYnVpbGQgZXJyb3IuCgpUaGlzIHBhdHRl cm4gYWxzbyBhcHBlYXJzIGluIHNldmVyYWwgb3RoZXIgR0FURSBkZWZpbml0aW9ucyBmdXJ0aGVy IGRvd24gaW4KdGhlIHp4Mjk3NTIwdjNfbWF0cml4X2dhdGVzIGFycmF5LgoKLS0gClNhc2hpa28g QUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDcyNy16eDI5 Y2xrLXY4LTAtN2ExMDdiMDBmMWRkQGdtYWlsLmNvbT9wYXJ0PTkKCi0tIApsaW51eC1waHkgbWFp bGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B788725B0BE; Mon, 27 Jul 2026 19:41:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785181296; cv=none; b=OxPWje/B35r/FAXBf3ONSb5e8QGVF/fMEkq8Q43/f6mFw1DFyg7XRkwcwULvwyy+9dofsnTY92xDRf/+6KV1F17o4+1z0lCo46LjPiR7DKhBOMatrVWT0+0uX06KH/MnUO1Us+8Ll7tGeJcE3wTzWfKw1HTYr5tX++GWkOAC7hY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785181296; c=relaxed/simple; bh=VYS7e0squFLmdhH1o1lCcd9sBcIgf3F3pTxhg3qPOHo=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=cjFpSJcN8dZLonyJV4uyK3j9LSpSqoRnGG37SzG0T5pZ1eMqgUd+QbenrEw1lTY36UwUeJjkFnz8B5asZ75FFijONd8GnKZU8xZVU2ZQZl7bPk5UGNip5ggRBhOpgEM9h+2Pw8EPk+TviCdvRmK/Jy0NPQBfHseb+aoIqgbiJFk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KsfBC8WK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KsfBC8WK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFFDD1F000E9; Mon, 27 Jul 2026 19:41:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785181295; bh=NXZ01KRGPMGOj00getszVzMdpSsaQmnkNWAK37M3n/g=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=KsfBC8WKwAvkkFn307EM+YTnBJ6P+q+7aCNFiaalNL7KOP+jsQSbvTbRP9Ca6DE1h 2QoSJaw6r0L6CCLIbtd66vpbz7BzUp4oinbTEgBVsV3oVtJw9Amn8XbDJCNj1Xekf3 34BqQOHy5JPpwgGH8w+DFByeYYb8KHYn3UsSJhHf9MEXxSh+XC5IVSctDex588K7h1 2Sn4jpAYmzcnth0F65JJHUdqPK6h2TX+7XlDMp27/g3ktNZJ3zyxOKDz83CPBLLO4S 48DbVj7BYG8b9S6AaMHIjdt8BT19eL8XuS7OgHTdjwv5e4pJbdde/OnqZtuokQ3UX0 U/FglnuaT2ivQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v8 09/12] clk: zte: Introduce a driver for zx297520v3 matrix clocks Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?U3RlZmFuIETDtnNpbmdlcg==?= Cc: neil.armstrong@linaro.org, devicetree@vger.kernel.org, robh@kernel.org, mfd@lists.linux.dev, vkoul@kernel.org, olteanv@gmail.com, conor+dt@kernel.org, linux-phy@lists.infradead.org, lee@kernel.org In-Reply-To: <20260727-zx29clk-v8-9-7a107b00f1dd@gmail.com> References: <20260727-zx29clk-v8-0-7a107b00f1dd@gmail.com> <20260727-zx29clk-v8-9-7a107b00f1dd@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 27 Jul 2026 19:41:34 +0000 Message-Id: <20260727194134.EFFDD1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The use of `clk_main[0]` to initialize fields in static global arra= ys is invalid C and causes a compilation error. -- --- Patch [9]: [PATCH v8 09/12] clk: zte: Introduce a driver for zx297520v3= matrix clocks --- commit 895d095e9e21d84eaefefb2e2881a4f8193ef450 Author: Stefan D=C3=B6singer clk: zte: Introduce a driver for zx297520v3 matrix clocks This commit introduces a new clock driver for the zx297520v3 matrix clock controller, which manages high-speed devices such as CPU, DMA, RAM, SDIO, and Ethernet. It registers multiplexers, fixed dividers, and gates within the controller. > diff --git a/drivers/clk/zte/clk-zx297520v3.c b/drivers/clk/zte/clk-zx297= 520v3.c > index 4444c2eb13825..9299449097b4a 100644 > --- a/drivers/clk/zte/clk-zx297520v3.c > +++ b/drivers/clk/zte/clk-zx297520v3.c [ ... ] > @@ -542,6 +542,340 @@ static const struct zx_clk_data zx297520v3_topclk_d= ata =3D { [ ... ] > +static const struct zx_gate_desc zx297520v3_matrix_gates[] =3D { [ ... ] > + /* Both 0x24 and 0x28 bits 1 and 2 stop the CPU. There is also a bit in= topclk+0x138, which > + * ZTE's uboot calls "A53 reset", which also stops the CPU. I can't rea= lly tell the > + * difference between matrix+0x28 and top+0x138. The clock (matrix+0x24= ) can be disabled > + * and enabled from the Cortex M0 and it will nicely stop and restart t= he A53, retaining > + * all state. > + */ > + GATE(ZX297520V3_CPU_WCLK, "cpu-wclk", "cpu-mux", = 0x24, 1, > + CLK_IS_CRITICAL), > + GATE(ZX297520V3_CPU_PCLK, "cpu-pclk", clk_main[0], = 0x24, 2, > + CLK_IS_CRITICAL), [Severity: Low] Does this cause a compilation error? In C, static array initializers must use constant expressions. Accessing an array element like clk_main[0] requi= res reading memory, which is not considered a constant expression by the compil= er, and will likely result in an initializer element is not constant build erro= r. This pattern also appears in several other GATE definitions further down in the zx297520v3_matrix_gates array. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260727-zx29clk-v8= -0-7a107b00f1dd@gmail.com?part=3D9