Re: [PATCH 6.18.y 1/4] dm-verity-fec: fix the size of dm_verity_fec_io::erasures

[Eric Biggers <ebiggers@kernel.org>]

On Mon, Jul 27, 2026 at 09:09:27PM +0000, Eric Biggers wrote:
> On Mon, Jul 27, 2026 at 05:00:08PM -0400, Sasha Levin wrote:
> > From: Eric Biggers <ebiggers@kernel.org>
> > 
> > [ Upstream commit a7fca324d7d90f7b139d4d32747c83a629fdb446 ]
> > 
> > At most 25 entries in dm_verity_fec_io::erasures are used: the maximum
> > number of FEC roots plus one.  Therefore, set the array size
> > accordingly.  This reduces the size of dm_verity_fec_io by 912 bytes.
> > 
> > Note: a later commit introduces a constant DM_VERITY_FEC_MAX_ROOTS,
> > which allows the size to be more clearly expressed as
> > DM_VERITY_FEC_MAX_ROOTS + 1.  This commit just fixes the size first.
> > 
> > Fixes: a739ff3f543a ("dm verity: add support for forward error correction")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> > Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> > Stable-dep-of: 31d6e6c0ba8d ("dm-verity: fix buffer overflow in FEC calculation")
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> 1. Missing cover letter.
> 
> 2. I was only sent patches 1-3 of 4.
> 
> 3. Missing Cc to the subsystem mailing list.  Needed since these aren't
>    clean cherry-picks.
> 
> 4. These backports seem to have unnecessary differences from the
>    upstream commits.  DM_VERITY_FEC_MAX_ROOTS in added in the first
>    commit, but upstream it was added in the third one.
> 
> - Eric

I would be glad to do this backport if needed, by the way.  Just I
wasn't aware that "dm-verity: fix buffer overflow in FEC calculation"
was FAILED, since dm-devel wasn't included in Cc on the FAILED email, so
I never received it.

As I've said many times before, failure to Cc the subsystem mailing list
is grounds for a nack, just like any other kernel patch.

- Eric