From: Andreas Kemnade <andreas@kemnade.info>
To: robby.cai@oss.nxp.com
Cc: lgirdwood@gmail.com, broonie@kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/2] regulator: fp9931: Fix VPOS/VNEG voltage selector table
Date: Mon, 27 Jul 2026 22:04:38 +0200 [thread overview]
Message-ID: <20260727220438.2a5bf1a8@akphone> (raw)
In-Reply-To: <20260721095959.1855436-2-robby.cai@oss.nxp.com>
On Tue, 21 Jul 2026 17:59:58 +0800
robby.cai@oss.nxp.com wrote:
> From: Robby Cai <robby.cai@nxp.com>
>
> The VPOSNEG_table[] mapping does not match the FP9931/JD9930
> datasheet.
>
> The datasheet defines the VPOS/VNEG voltage mapping as:
>
> 00h-04h -> 7.04V (-7.04V)
> 05h -> 7.26V (-7.26V)
> 06h -> 7.49V (-7.49V)
> ...
> 28h-3Fh -> 15.06V (-15.06V)
>
> However, the current table maps selector 0x05 to 7.04V instead of
> 7.26V, causing all subsequent entries to be shifted by one position.
>
> Update VPOSNEG_table[] to match the documented register encoding.
>
> Fixes: 12d821bd13d4 ("regulator: Add FP9931/JD9930 driver")
> Signed-off-by: Robby Cai <robby.cai@nxp.com>
Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
next prev parent reply other threads:[~2026-07-27 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 9:59 [PATCH 0/2] regulator: fp9931: fix voltage mapping and runtime PM issues robby.cai
2026-07-21 9:59 ` [PATCH 1/2] regulator: fp9931: Fix VPOS/VNEG voltage selector table robby.cai
2026-07-21 10:07 ` sashiko-bot
2026-07-21 10:46 ` Robby Cai (OSS)
2026-07-27 20:04 ` Andreas Kemnade [this message]
2026-07-21 9:59 ` [PATCH 2/2] regulator: fp9931: Fix Runtime PM usage count underflow in v3p3 ops robby.cai
2026-07-21 10:07 ` sashiko-bot
2026-07-21 10:37 ` Robby Cai (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727220438.2a5bf1a8@akphone \
--to=andreas@kemnade.info \
--cc=broonie@kernel.org \
--cc=imx@lists.linux.dev \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robby.cai@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.