Re: [PATCH v3 5/5] arm64: dts: qcom: milos-fairphone-fp6: Add NFC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The NFC controller will remain unpowered because the `s3fwrn5` driver lacks regulator support, so the `pvdd-supply` specified in the device tree will never be enabled.
--

--- Patch [5]: [PATCH v3 5/5] arm64: dts: qcom: milos-fairphone-fp6: Add NFC ---
commit a37bde53492f31e7077b36b4e030e872e07827b0
Author: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>

arm64: dts: qcom: milos-fairphone-fp6: Add NFC

This commit adds the Samsung S3NRN4V NCI NFC controller on i2c1 to the
device tree. It configures the necessary clocks, interrupts, and assigns
the PVDD supply to the PM7550 LDO20 regulator.

> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
> index ebdca0e2d2f3a..a1b86e4092fe2 100644
> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
> @@ -601,9 +601,29 @@ &gcc {
[ ... ]
> +	nfc@27 {
> +		compatible = "samsung,s3nrn4v";
> +		reg = <0x27>;
> +
> +		clk-req-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
> +		clocks = <&rpmhcc RPMH_RF_CLK2>;
> +		en-gpios = <&tlmm 56 GPIO_ACTIVE_HIGH>;
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <31 IRQ_TYPE_EDGE_RISING>;
> +		pinctrl-0 = <&nfc_clk_req_default>, <&nfc_irq_default>,
> +			    <&nfc_pd_default>;
> +		pinctrl-names = "default";
> +		pvdd-supply = <&vreg_l20b>;

[Severity: High]
Will the NFC controller remain unpowered here?

Looking at the upstream driver in drivers/nfc/s3fwrn5/i2c.c in
s3fwrn5_i2c_probe(), it parses and initializes GPIOs and clocks:

    phy->common.gpio_en = devm_gpiod_get(&client->dev, "en", GPIOD_OUT_HIGH);

However, it appears to omit requesting or enabling any regulators like
pvdd-supply. Since vreg_l20b is not marked as always-on, won't the regulator
core leave it disabled, preventing the chip from functioning?

> +		wake-gpios = <&tlmm 7 GPIO_ACTIVE_HIGH>;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260726222405.153008-1-jorijnvdgraaf@catcrafts.net?part=5