From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 229E73CBE84 for ; Mon, 27 Jul 2026 23:34:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785195289; cv=none; b=pPIAJ/lRt4OehVlAj7+PWS6b1RIHroniJN/xCw/bm+1xKtD7ZIlZmhD1Mv7zOL6DbVIij08afhCskCJBkZTMorTDIDTGr5dzXEI/zBGwykSMQvHMhpD0/jZLIbHH4XsmIIIfHmC4THTIQTtVSqIQCorVLtX85azggoyKx3kzzWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785195289; c=relaxed/simple; bh=rnrH9KrOeTih4Poj3NcaqgMuvGNEj1ClMUEKjnWjYI8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cIOpGeX5FeYY49/Ha6tuDKyuduxFJ4Kz0Gp0HvryHuU4lp7aTvpzGv3gOF1TOEIn9jMloLKelEkZBl2Dzq6SQ6MUciR481AUlXtzmnSmPRFi7vWrK+eglNWe22v6YstnRW0YyzEx14dc+QnwWc27uOZRuZqVuGsnswumLfcwbqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eIexWvzX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eIexWvzX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 863EC1F000E9; Mon, 27 Jul 2026 23:34:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785195288; bh=cLvL70u34uu5OKhg6HTqGoCqTfQ14Ll+WKKp7p9HvTs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=eIexWvzXuweLpYADUAK6SGDiFWKQQJiiow1XRRNHshaMJvbEz+ZdHAerz3uDrWCqH WRVUq2qahLBuxzZoohjHkfJ5d9AEI0ctv2L0T5h0YBm0TDvc9s/qWa2ceiPadiGCck rMgolP1BOwKfRGXDhVu58ZetzcnJnujjMerC4L5shfv+AbOKkiVvx8OGzRQlZqRrtK WNBsSfwR+WbCm9hu53dTNRjiB8ri/wolgTqzz160LGFWjefqA+fck8Tqo8ZdkbSxEG y3BSOKDp5OhB6NLfZRqTmnRUyzXPaN8uPLfk0+hDOcTdmKJEHuc5YCZHL+Jwyol1gE Am5WBmYr/PRJw== From: Sasha Levin To: stable@vger.kernel.org Cc: Johan Hovold , Binbin Zhou , Ulf Hansson Subject: [PATCH 6.12.y 1/3] mmc: vub300: fix use-after-free on disconnect Date: Mon, 27 Jul 2026 19:34:42 -0400 Message-ID: <20260727233445.2426041-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026072046-octane-riverside-49ce@gregkh> References: <2026072046-octane-riverside-49ce@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Johan Hovold The vub300 driver maintains an explicit reference count for the controller and its driver data and the last reference can in theory be dropped after the driver has been unbound. This specifically means that the controller allocation must not be device managed as that can lead to use-after-free. Note that the lifetime is currently also incorrectly tied the parent USB device rather than interface, which can lead to memory leaks if the driver is unbound without its device being physically disconnected (e.g. on probe deferral). Fix both issues by reverting to non-managed allocation of the controller. Fixes: dcfdd698dc52 ("mmc: vub300: Use devm_mmc_alloc_host() helper") Cc: stable@vger.kernel.org # 6.17+ Cc: Binbin Zhou Signed-off-by: Johan Hovold Signed-off-by: Ulf Hansson (cherry picked from commit 8f4d20a710225ec7a565f6a0459862d3b1f32330) --- drivers/mmc/host/vub300.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c index 35393f534de2bd..b39978357aab28 100644 --- a/drivers/mmc/host/vub300.c +++ b/drivers/mmc/host/vub300.c @@ -2279,7 +2279,7 @@ static int vub300_probe(struct usb_interface *interface, dev_err(&vub300->udev->dev, "Could not find two sets of bulk-in/out endpoint pairs\n"); retval = -EINVAL; - goto error5; + goto err_free_host; } retval = usb_control_msg(vub300->udev, usb_rcvctrlpipe(vub300->udev, 0), @@ -2288,14 +2288,14 @@ static int vub300_probe(struct usb_interface *interface, 0x0000, 0x0000, &vub300->hc_info, sizeof(vub300->hc_info), 1000); if (retval < 0) - goto error5; + goto err_free_host; retval = usb_control_msg(vub300->udev, usb_sndctrlpipe(vub300->udev, 0), SET_ROM_WAIT_STATES, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE, firmware_rom_wait_states, 0x0000, NULL, 0, 1000); if (retval < 0) - goto error5; + goto err_free_host; dev_info(&vub300->udev->dev, "operating_mode = %s %s %d MHz %s %d byte USB packets\n", (mmc->caps & MMC_CAP_SDIO_IRQ) ? "IRQs" : "POLL", @@ -2310,7 +2310,7 @@ static int vub300_probe(struct usb_interface *interface, 0x0000, 0x0000, &vub300->system_port_status, sizeof(vub300->system_port_status), 1000); if (retval < 0) { - goto error5; + goto err_free_host; } else if (sizeof(vub300->system_port_status) == retval) { vub300->card_present = (0x0001 & vub300->system_port_status.port_flags) ? 1 : 0; @@ -2318,7 +2318,7 @@ static int vub300_probe(struct usb_interface *interface, (0x0010 & vub300->system_port_status.port_flags) ? 1 : 0; } else { retval = -EINVAL; - goto error5; + goto err_free_host; } usb_set_intfdata(interface, vub300); INIT_DELAYED_WORK(&vub300->pollwork, vub300_pollwork_thread); @@ -2348,7 +2348,7 @@ static int vub300_probe(struct usb_interface *interface, return 0; error6: del_timer_sync(&vub300->inactivity_timer); -error5: +err_free_host: mmc_free_host(mmc); /* * and hence also frees vub300 -- 2.53.0