All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Aryan Krishnan <aryankrishnan4b@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: apply clang-format cleanup
Date: Mon, 27 Jul 2026 06:35:25 +0200	[thread overview]
Message-ID: <2026072754-finishing-utilize-558c@gregkh> (raw)
In-Reply-To: <20260727040649.54338-1-aryankrishnan4b@gmail.com>

On Mon, Jul 27, 2026 at 09:36:39AM +0530, Aryan Krishnan wrote:
> From: Aryan <aryankrishnan4b@gmail.com>
> 
> This patch formats the drivers/staging/rtl8723bs directory using
> clang-format, hence reducing the number of errors by 2, warnings by 66,
> and CHECKs by 4,685.
> 
> This is a purely mechanical, whitespace/formatting-only change with
> no functional impact.

Which, if we wanted to, we could have done already, but that's not the
point here in staging.  The point is to have a place where people can
learn how to contribute to the kernel in an easy way.  By just using an
automated tool, no one learns much :(

As my bot says for this patch:

----------------

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

  reply	other threads:[~2026-07-27  4:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27  4:06 [PATCH] staging: rtl8723bs: apply clang-format cleanup Aryan Krishnan
2026-07-27  4:35 ` Greg KH [this message]
2026-07-27  5:12   ` Aryan Krishnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026072754-finishing-utilize-558c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=aryankrishnan4b@gmail.com \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.