From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 522A938D404; Tue, 28 Jul 2026 04:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785211979; cv=none; b=itcYmbp7wGbnzefj0anBUdqhmGZiFc91awhiXJBQYSJmmw1Aayw7IGJiHhIoGEPa6J0Y5ZlSzGtSwI37kuNZHbDFbFjnBcBDWxQhKFuWtrElHDNvwQrscGzj3TEJcugowpajOQklTel2K5lJUP2FU0g/p+jt9McPRvuOzbZRIJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785211979; c=relaxed/simple; bh=cH7oUihXT5tSE12SlVvQqKNd1nNVqFN94y4J0cSFmek=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UmqydUG8maa6GXfu8i35zqqHARJHXF20I4Z+rIjP0JDpB9/YT+m40CqF1fx5wardPU4E3A13Y27akZV4As8PxbyrdF7010ju5jXicI+jRf/TuCuZgZOMk/C2imJQ59j5QMwqSwSHZcIg2hGVJOOftg3P9lEsA7UcMcIdMViHb6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Xyxjh3QU; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Xyxjh3QU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA7A21F00ADF; Tue, 28 Jul 2026 04:12:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785211975; bh=tgUZwUoU8BIl3mw05ttJnd7LdxesVWGSbPXBRiEQeMQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Xyxjh3QU3OC66tCGLcocjG4phVqYA0nwfNKDz9aUUpsJBEWSAtbfzj7kx5k3rdn1S 0KZ+fbObrCtBLQ3ZK7uaY/svbiTgdZnBq2Yex16T2qfe7DBJx67NNITCuYFHa/SJ+j Pp4OBC+eXtuzja0t8yTDXS3m9oN864RsEcZLxt6kgIcmUCoE4//W0RNs17Cx0NO2sr Ri6lcE68xV2+VlItOt9B84SPPk+K0RCr6ZWw8cpB9HBAwwcvmtp9QuQ2gl3pv0+tyJ 0jNXSH3bIfGxAczc4l+hniYwjgl7C5EkdcNQBUKQLEVKxuANtsQzO+SSvpLNVFkUWC odZmsxxH8fo6g== From: SJ Park To: Cc: SJ Park , Andrew Morton , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v2.2 11/17] mm/damon/sysfs: create directories for nr_preps writes Date: Mon, 27 Jul 2026 21:12:32 -0700 Message-ID: <20260728041242.187380-12-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260728041242.187380-1-sj@kernel.org> References: <20260728041242.187380-1-sj@kernel.org> Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Implement nr_preps write action to actually create subdirectories of the number. Each of the directory will be evolved to represent each probe preparation action. Signed-off-by: SJ Park --- mm/damon/sysfs.c | 80 +++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 79 insertions(+), 1 deletion(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 38affef08d0fb..afd39659d6b84 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -750,12 +750,50 @@ static const struct kobj_type damon_sysfs_intervals_ktype = { .default_groups = damon_sysfs_intervals_groups, }; +/* + * prep directory + */ + +struct damon_sysfs_prep { + struct kobject kobj; +}; + +static struct damon_sysfs_prep *damon_sysfs_prep_alloc(void) +{ + struct damon_sysfs_prep *prep; + + prep = kzalloc_obj(struct damon_sysfs_prep); + if (!prep) + return prep; + return prep; +} + +static void damon_sysfs_prep_release(struct kobject *kobj) +{ + struct damon_sysfs_prep *prep = container_of(kobj, + struct damon_sysfs_prep, kobj); + + kfree(prep); +} + +static struct attribute *damon_sysfs_prep_attrs[] = { + NULL, +}; +ATTRIBUTE_GROUPS(damon_sysfs_prep); + +static const struct kobj_type damon_sysfs_prep_ktype = { + .release = damon_sysfs_prep_release, + .sysfs_ops = &kobj_sysfs_ops, + .default_groups = damon_sysfs_prep_groups, +}; + /* * preps directory */ struct damon_sysfs_preps { struct kobject kobj; + struct damon_sysfs_prep **preps_arr; int nr; }; @@ -766,13 +804,53 @@ static struct damon_sysfs_preps *damon_sysfs_preps_alloc(void) static void damon_sysfs_preps_rm_dirs(struct damon_sysfs_preps *preps) { + struct damon_sysfs_prep **preps_arr = preps->preps_arr; + int i; + + for (i = 0; i < preps->nr; i++) { + kobject_del(&preps_arr[i]->kobj); + kobject_put(&preps_arr[i]->kobj); + } preps->nr = 0; + kfree(preps_arr); + preps->preps_arr = NULL; } static int damon_sysfs_preps_add_dirs(struct damon_sysfs_preps *preps, int nr_preps) { - preps->nr = nr_preps; + struct damon_sysfs_prep **preps_arr, *prep; + int err, i; + + damon_sysfs_preps_rm_dirs(preps); + if (!nr_preps) + return 0; + + preps_arr = kmalloc_objs(*preps_arr, nr_preps, + GFP_KERNEL | __GFP_NOWARN); + if (!preps_arr) + return -ENOMEM; + preps->preps_arr = preps_arr; + + for (i = 0; i < nr_preps; i++) { + prep = damon_sysfs_prep_alloc(); + if (!prep) { + damon_sysfs_preps_rm_dirs(preps); + return -ENOMEM; + } + + err = kobject_init_and_add(&prep->kobj, + &damon_sysfs_prep_ktype, &preps->kobj, "%d", + i); + if (err) { + kobject_put(&prep->kobj); + damon_sysfs_preps_rm_dirs(preps); + return err; + } + + preps_arr[i] = prep; + preps->nr++; + } return 0; } -- 2.47.3