From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8840A41A513 for ; Tue, 28 Jul 2026 09:24:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785230677; cv=none; b=D6F1gJ823s6wtpa869Fddpnv/lXNKbE4udMOEFckqN5PhZmnShpCiPIeF8euAySTU7vElsTngLKA6VxfGh6qRIPhhELmHqy/95v8DPb9zYoKmf5SzwWJfNssDWB3W7mG2ykqzwo68Q81qid53c45eMDRuldO/wqfuKzNROK5b08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785230677; c=relaxed/simple; bh=x4EfWP9lpPGABSNYkiBqcMZxBLj2mqJhtQnxiC7693s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kf+c95TRT50Q+zN+OmNhUPkkyOH3B4ZPWQ+5A/MBy3xQbyoJhu2k/TFK8GWU6YXpeSfm278F0GudTgC4A0zYm3Z/u5TnnhJDUlKqGKvAhDf/DqdxuHQccYLtcw4waTvNuNXsDW1VXXByU4R+Cj/CdfN5L7VB/vlxZqWbGAxYQig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jecgP6af; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jecgP6af" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-4728c12ba97so2155824f8f.0 for ; Tue, 28 Jul 2026 02:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785230674; x=1785835474; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MU0kB3tzcL3BcIvbRsjvopfqP7S9hljDqDjRn4DR50I=; b=jecgP6af/u1p5YR5mFutb7goA6nUViQ09L+qU/ddzWiyN7qV53CTVt/kwF2fsQOJbr /w2RnSyYP1F8Xbp+Z6F94l5PTe/2PX/bhuKehFPLfp4npSWg5RJ6oiWAg7dQkri7E8t3 dPBJHlsX5kyxnoWF6rxo5YvU5rfnN9NpeVblqoLRhUniwwwnir5ylW6HEml7cU2hR258 81NGZVq7u+EoZPIrkmyIChsP2NoxgDm0EWfNgDIQX1DxdUxS4t93KDKSmtN5v3Wx2Zuc OzAQdJokbWfuwg7mh+MHG2CQv8PXsBa6FjM0K6kglEAgJvzCFrmL7HgnlgXCHZB2mJxk kiQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785230674; x=1785835474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MU0kB3tzcL3BcIvbRsjvopfqP7S9hljDqDjRn4DR50I=; b=JTO41HmjkP78Tt6GK9/0UxOb2h3K+YNXUWSuZXfKAXfHwR1pZNT0I0lNznjz1Ntbag BfrfntVNzd1lHwQr6z67Qyarqpk2eW+f0uq0ixB7ve6nvR6pcxzqTBWQhe+rq31hZzHU MV6VSBzNZ2DpBke8sLbqVzJfIXLjkUVHPuTIcALwmEzhNo6XDue8SZFwt52HfdNJUTzh smzURiPsgt0EQVNjGg3FAfveEeteRE2OsaIf1n/N5fXDoYHkoEKae+6omcsW8LvKThOP vw43q+kV7zdzxzl0rdrL3LNvtDIkQG8aE/gnFfULkYCk10JSuBb6YyWxvrQ7OW8aBq3g MZyA== X-Forwarded-Encrypted: i=1; AHgh+Ro0jbeEpu7oN/wa2AnvfUBYcwhRLr1M7kTEu4WtXUNXT6dU9o0Xse3I1TzcvEYpQ1wqoB7xF1+T++Dv32Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzJbnTr4gRJ1Ki9r5C5zlZIJ5yNup3XOzd6ahkjD3a1Li3z9if9 QJ50hNnloAQ9eD4doqDt2ddEEhz8CEHBN7jyD3dqTsl64mmL2QX5uUNM X-Gm-Gg: AR+sD13EhM5RL6Gxwzw74F0LwO779PWDN+7GgJBr1f9Bws1vijM4Gf3MTEwFA6RZyvl yokoHxCPqmsNIK6XWdNr++f5rxRUmJX8IrQjlExh2gjA0YH1WWvkhsVUAKoVw/+KGwnoT3/zzB0 K/WJb0MsZeAP0yPxiTqHm9cUafxfxPG79hwIcHkgSCNKyFshXXssVTZTIvSLihLH8njUVk573Qa h/7laItiCevBZDoxrSpg+3GbdqeA6CTWYLxdWVyBQDhzvQhVvnbU8+r04u4oXznffXXbrz6dfzI h4GQTzo3kOfFmzm7SxHiAnxAjdCV4l9svmi9S4Kvoaj3oeLEwX06zkakaaKwE9PUu2nPOBfCg9F IdIn1seo4uOyftFNOv6bAwSxCnOriL/crwWgr22EwSy5X808ZZeOqs+KI01rh1PMOeL1r8pHcLp jF17Oz+g8UC2c+g9WR/LMweyeLj+VgUwaRnDngNItAFmLApvpow7zmaOTqISPDZA== X-Received: by 2002:a05:600c:4ecb:b0:495:443b:1bbb with SMTP id 5b1f17b1804b1-496c656ca2emr15166545e9.25.1785230673624; Tue, 28 Jul 2026 02:24:33 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4957bfc2ff2sm267739645e9.4.2026.07.28.02.24.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 02:24:32 -0700 (PDT) From: David Carlier To: Kate Hsuan Cc: Sakari Ailus , Mauro Carvalho Chehab , Tarang Raval , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH v2] media: i2c: imx471: Fix uninitialized error value in imx471_set_ctrl() Date: Tue, 28 Jul 2026 10:24:30 +0100 Message-ID: <20260728092430.12491-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260724041417.9921-1-devnexen@gmail.com> References: <20260724041417.9921-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The exposure and vertical blanking writes pass the address of the local ret variable to cci_write() as its error pointer, but there is no earlier error to propagate: each case is a single standalone write, like the other controls in the same switch that already pass NULL. In the exposure case ret is still uninitialized, so a non-zero stack value makes cci_write() return early without programming the register, and the control write reports a bogus status. The vertical blanking case is benign today because ret is zero there, but the construct is equally wrong. Pass NULL as the error pointer in both cases. Fixes: be1589e567ae ("media: i2c: imx471: Add Sony IMX471 image sensor driver") Suggested-by: Kate Hsuan Signed-off-by: David Carlier --- Changes in v2: - Fix the root cause by passing NULL as the cci_write() error pointer for the exposure and vertical blanking writes, instead of initializing ret to zero (Kate Hsuan). v1: https://lore.kernel.org/linux-media/20260724041417.9921-1-devnexen@gmail.com/ drivers/media/i2c/imx471.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/imx471.c b/drivers/media/i2c/imx471.c index 6d358b11e96d..4053aed84340 100644 --- a/drivers/media/i2c/imx471.c +++ b/drivers/media/i2c/imx471.c @@ -334,12 +334,12 @@ static int imx471_set_ctrl(struct v4l2_ctrl *ctrl) break; case V4L2_CID_EXPOSURE: ret = cci_write(sensor->regmap, IMX471_REG_EXPOSURE, - ctrl->val, &ret); + ctrl->val, NULL); break; case V4L2_CID_VBLANK: /* Update FLL that meets expected vertical blanking */ ret = cci_write(sensor->regmap, IMX471_REG_FLL, - format->height + ctrl->val, &ret); + format->height + ctrl->val, NULL); break; case V4L2_CID_TEST_PATTERN: ret = cci_write(sensor->regmap, IMX471_REG_TEST_PATTERN, -- 2.53.0