All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergio Prado <sergio.prado@e-labworks.com>
To: u-boot@lists.denx.de
Cc: trini@konsulko.com, sjg@chromium.org, alpernebiyasak@gmail.com,
	marek.vasut+renesas@mailbox.org, ilias.apalodimas@linaro.org,
	pbrobinson@gmail.com, sughosh.ganu@arm.com,
	sergio.prado@e-labworks.com, wolfgang.wallner@at.abb.com,
	xypron.glpk@gmx.de, quentin.schulz@cherry.de,
	jj251510319013@gmail.com, Wojciech.Dubowik@mt.com
Subject: [PATCH v6 1/5] binman: x509_cert: document Entry_x509_cert properties
Date: Tue, 28 Jul 2026 08:35:31 -0300	[thread overview]
Message-ID: <20260728113535.128601-2-sergio.prado@e-labworks.com> (raw)
In-Reply-To: <20260728113535.128601-1-sergio.prado@e-labworks.com>

The Entry_x509_cert class only listed 'content' in its
'Properties / Entry arguments' section, even though 'keyfile',
'cert-ca', 'cert-revision-int' and 'sw-rev' are also read from the
entry node and passed through to openssl.

Expand the docstring so the binman documentation generated from it
matches the actual behavior of the entry.

No functional change.

Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
 tools/binman/etype/x509_cert.py | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/tools/binman/etype/x509_cert.py b/tools/binman/etype/x509_cert.py
index b6e8b0b4fb09..efa85f9553e7 100644
--- a/tools/binman/etype/x509_cert.py
+++ b/tools/binman/etype/x509_cert.py
@@ -18,7 +18,15 @@ class Entry_x509_cert(Entry_collection):
     """An entry which contains an X509 certificate
 
     Properties / Entry arguments:
-        - content: List of phandles to entries to sign
+        - content: List of phandles to entries to sign.
+        - keyfile: Filename of the PEM key file used to sign the binary.
+        - cert-ca: Common Name (CN) embedded in the certificate. Used when
+            generating a generic x509 certificate.
+        - cert-revision-int: Integer certificate revision number. Used when
+            generating a generic x509 certificate. Defaults to 0.
+        - sw-rev: Software revision number embedded in the certificate by
+            the sysfw/rom variants used by the TI K3 secure boot subclasses.
+            Defaults to 1.
 
     Output files:
         - input.<unique_name> - input file passed to openssl
-- 
2.34.1


  reply	other threads:[~2026-07-28 11:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4LN_e4Mi0TK99Phw-qnFJv5fIiv9tloFlexssVWY2btc8KqK4_JhOcNLziBlaQYe1fRY5-gnFHrYEYQjBOTiPw==@protonmail.internalid>
2026-07-28 11:35 ` [PATCH v6 0/5] binman: add PKCS#11/HSM signing support for X509 certificates Sergio Prado
2026-07-28 11:35   ` Sergio Prado [this message]
2026-07-28 11:35   ` [PATCH v6 2/5] binman: x509_cert: document PKCS#11 URI support in keyfile Sergio Prado
2026-08-05 18:57     ` Simon Glass
2026-07-28 11:35   ` [PATCH v6 3/5] binman: ti_secure: drop the redundant keyfile re-read Sergio Prado
2026-08-05 18:58     ` Simon Glass
2026-08-07 13:19       ` Sergio Prado
2026-07-28 11:35   ` [PATCH v6 4/5] binman: x509_cert: support PKCS11_PIN environment variable Sergio Prado
2026-08-05 18:58     ` Simon Glass
2026-07-28 11:35   ` [PATCH v6 5/5] binman: Add BINMAN_X509_KEYFILE to override the signing key Sergio Prado
2026-08-05 18:58     ` Simon Glass
2026-07-28 14:40   ` [PATCH v6 0/5] binman: add PKCS#11/HSM signing support for X509 certificates Rasmus Villemoes via U-Boot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260728113535.128601-2-sergio.prado@e-labworks.com \
    --to=sergio.prado@e-labworks.com \
    --cc=Wojciech.Dubowik@mt.com \
    --cc=alpernebiyasak@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jj251510319013@gmail.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=pbrobinson@gmail.com \
    --cc=quentin.schulz@cherry.de \
    --cc=sjg@chromium.org \
    --cc=sughosh.ganu@arm.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=wolfgang.wallner@at.abb.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.