Re: [PATCH v2 1/2] dt-bindings: iio: adc: add support for PAC1711

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Incomplete array constraint for `interrupt-names` restricts the property to a single item.
- [Medium] The `pattern` keyword is used directly on the `compatible` property array, causing the conditional blocks to always evaluate to true.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: iio: adc: add support for PAC1711 ---
commit 77f3bdc33ee2d8c631ae6a4bc6e945119e803da5
Author: Ariana Lazar <ariana.lazar@microchip.com>

dt-bindings: iio: adc: add support for PAC1711

This is the device tree schema for Microchip PAC1711, PAC1721, PAC1811 and
PAC1821 single-channel power monitor with accumulator. The devices use
12-bit or 16-bit resolution for voltage and current measurements.

> diff --git a/Documentation/devicetree/bindings/iio/adc/microchip,pac1711.yaml b/Documentation/devicetree/bindings/iio/adc/microchip,pac1711.yaml
> new file mode 100644
> index 0000000000000..846e7801a1667
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/microchip,pac1711.yaml

[ ... ]

> +  interrupts:
> +    description:
> +      Could be triggered by overvoltage, undervoltage, overcurrent, overpower,
> +      undercurrent, step limit, accumulator overflow and accumulator count
> +      overflow.
> +    minItems: 1
> +
> +  interrupt-names:
> +    items:
> +      - enum: [alert0, alert1]

[Severity: Medium]
Does this constraint restrict the interrupt-names property to a single item?

In JSON Schema and dt-schema, providing a list to items defines a tuple,
which implicitly bounds the maximum array length to 1. Since the hardware
supports two independent alert lines, this prevents device trees from
configuring the hardware with both of its supported interrupt alert lines
(alert0 and alert1).

Could this be defined with minItems: 1, maxItems: 2, and an unnested
items: enum: [alert0, alert1] to allow valid configurations using both
lines?

[ ... ]

> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          pattern: "^microchip,pac1[78]11$"

[Severity: Medium]
Will this condition always evaluate to true?

In Device Tree schemas, compatible is an array of strings. The JSON Schema
pattern keyword only applies to strings, so when the instance is an array,
pattern is ignored and evaluates to true.

To correctly match array elements, should the condition use contains, such
as contains: pattern: "^microchip,pac1[78]11$"?

> +    then:
> +      properties:
> +        microchip,vbus-input-range-microvolt:

[ ... ]

> +  - if:
> +      properties:
> +        compatible:
> +          pattern: "^microchip,pac1[78]21$"

[Severity: Medium]
Does this block suffer from the same pattern matching issue on the
compatible array?

Since both if conditions evaluate to true, the schema will enforce mutually
exclusive oneOf constraints for microchip,vbus-input-range-microvolt
(max 42V vs 9V). Validation will always fail for any device tree using this
property.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260728-pac1711-v2-0-609bc026093c@microchip.com?part=1