From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m155101.qiye.163.com (mail-m155101.qiye.163.com [101.71.155.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81FED447814 for ; Tue, 28 Jul 2026 13:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785246733; cv=none; b=gH7+usn86JHgntUdxih0KbmqxaQ1g5aLbhBHmwF8ZuiZv1fT4l54gFYuPujyXFsoGd3970KRaI1UWYRaioIdg6LJIRxksvnr+0UdI4bSmF1fphmt9bHSPPLXhRFOS1DR4iSzdQ6n5a2rV7sCvf+p6Cid8L9BaH7kCj8/3HsEvtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785246733; c=relaxed/simple; bh=nSrKukoXEIMYSxehzm8uEcaODDpMsdifcmsrU0n7CQ0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=shzNvBbQbc/7SiWyjALjBV/WZTACKkHIId2cqxhRNp8zyE3kRYxeBv4bmgBab9ze4eFQgnSRFgH8tnrBx9GW2SBwIjVJjLqs6wff0L5/5FEtoIIoV/y6Lk7dNRHDm0SvHnlRTKMjbp9NazdSGVSFih6lM1GAnzakCEsdWCi4sRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn; spf=pass smtp.mailfrom=seu.edu.cn; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b=esidB9zT; arc=none smtp.client-ip=101.71.155.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b="esidB9zT" Received: from LAPTOP-99KJFSET (unknown [221.228.238.82]) by smtp.qiye.163.com (Hmail) with ESMTP id 47e2b3612; Tue, 28 Jul 2026 21:52:06 +0800 (GMT+08:00) From: Hongyan Xu To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, luca.ceresoli@bootlin.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, zyytlz.wz@163.com, jianhao.xu@seu.edu.cn, Hongyan Xu Subject: [PATCH] drm/bridge: adv7511: cancel HPD work during teardown Date: Tue, 28 Jul 2026 21:52:05 +0800 Message-ID: <20260728135205.859-1-getshell@seu.edu.cn> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9fa8ff381003a1kunme3223698f13fe X-HM-MType: 10 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlCGUweVhgdQksfHxhNHUxNHlYeHw 5VEwETFhoSFyQUDg9ZV1kYEgtZQVlJSUpVSUlDVUlIQ1VDSVlXWRYaDxIVHRRZQVlPS0hVSktJSE 5DQ1VKS0tVS1kG DKIM-Signature: a=rsa-sha256; b=esidB9zTszYZx6Wx3u3CKERzKHwofidxdzK78FZ96IJ7rlKZ97kIn9IbWlLR9yBUHOxdmOktmWLeeSEqNS91I85iwj5+9MVtomXO081Eovxhk4o4SJsCRqIDRz3DcNwA40sOG0AFHrvxOQnlAB/CvfIy8x+WFPvwvAcQ13BH34E=; s=default; c=relaxed/relaxed; d=seu.edu.cn; v=1; bh=xtROo/A43OhfIAyUZ9GmB4Q2D+1MSaS+bas4iB3g3yQ=; h=date:mime-version:subject:message-id:from; The threaded IRQ handler queues hpd_work. The work accesses the regmap and calls drm_bridge_hpd_notify(), so it must not run after the bridge or the devm-allocated driver data has been released. Free the IRQ before cancelling hpd_work so the handler cannot queue the work again. Do this in remove and when adv7533_attach_dsi() fails after the IRQ has been registered. The remove-side race was reported previously, but the proposed fix did not cover the late probe failure path. This issue was found by a static analysis tool. Fixes: 518cb7057a59 ("drm/bridge: adv7511: Use work_struct to defer hotplug handing to out of irq context") Reported-by: Zheng Wang Link: https://lore.kernel.org/r/20230413065943.198088-1-zyytlz.wz@163.com Signed-off-by: Hongyan Xu --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 02f8f7e78..132ec4793 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -1400,11 +1400,15 @@ static int adv7511_probe(struct i2c_client *i2c) if (adv7511->info->has_dsi) { ret = adv7533_attach_dsi(adv7511); if (ret) - goto err_unregister_audio; + goto err_free_irq; } return 0; +err_free_irq: + if (i2c->irq) + devm_free_irq(dev, i2c->irq, adv7511); + cancel_work_sync(&adv7511->hpd_work); err_unregister_audio: drm_bridge_remove(&adv7511->bridge); i2c_unregister_device(adv7511->i2c_cec); @@ -1425,6 +1429,10 @@ static void adv7511_remove(struct i2c_client *i2c) { struct adv7511 *adv7511 = i2c_get_clientdata(i2c); + if (i2c->irq) + devm_free_irq(&i2c->dev, i2c->irq, adv7511); + cancel_work_sync(&adv7511->hpd_work); + of_node_put(adv7511->host_node); adv7511_uninit_regulators(adv7511); -- 2.50.1.windows.1