From: Simon Horman <horms@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: davem@davemloft.net, lcherian@marvell.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
sgoutham@marvell.com, tduszynski@marvell.com,
andrew+netdev@lunn.ch, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, Suman Ghosh <sumang@marvell.com>
Subject: Re: [PATCH net] octeontx2-pf: Set correct sequence for carrier off and tx queue stop
Date: Tue, 28 Jul 2026 17:50:17 +0100 [thread overview]
Message-ID: <20260728165017.GU418547@horms.kernel.org> (raw)
In-Reply-To: <20260724072831.2415281-1-rkannoth@marvell.com>
On Fri, Jul 24, 2026 at 12:58:31PM +0530, Ratheesh Kannoth wrote:
> From: Suman Ghosh <sumang@marvell.com>
>
> During link down event, we were doing netif_tx_stop_all_queues() first
> and then netif_carrier_off(). This can cause a potential race since
> carrier is still on during down event. This patch reverse the calling
> order to fix the issue.
>
> Fixes: 50fe6c02e5ad ("octeontx2-pf: Register and handle link notifications")
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-07-28 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 7:28 [PATCH net] octeontx2-pf: Set correct sequence for carrier off and tx queue stop Ratheesh Kannoth
2026-07-28 16:50 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728165017.GU418547@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
--cc=tduszynski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.