Re: [PATCH v6 2/4] dt-bindings: iio: flow: add Sensirion SLF3S liquid flow sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Hardware mismatch: The DT binding documents an `interrupts` property for a 4-pin device that lacks a physical interrupt pin.
--

--- Patch [2]: [PATCH v6 2/4] dt-bindings: iio: flow: add Sensirion SLF3S liquid flow sensor ---
commit 926be8ca8c587fafce9ef5ee2b44bb20052e203d
Author: Wadim Mueller <wafgo01@gmail.com>

dt-bindings: iio: flow: add Sensirion SLF3S liquid flow sensor

This commit documents the device tree bindings for the Sensirion SLF3S family of
digital liquid-flow sensors on I2C. The driver covers multiple variants which
differ only in flow scale factor and calibrated measurement range.

> diff --git a/Documentation/devicetree/bindings/iio/flow/sensirion,slf3s.yaml b/Documentation/devicetree/bindings/iio/flow/sensirion,slf3s.yaml
> new file mode 100644
> index 0000000000000..79718f4f98bd6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/flow/sensirion,slf3s.yaml

[ ... ]

> +properties:
> +  compatible:
> +    enum:
> +      - sensirion,slf3s-0600f
> +      - sensirion,slf3s-1300f
> +      - sensirion,slf3s-4000b
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +
> +  interrupts:
> +    maxItems: 1

[Severity: Low]
Is this interrupts property accurate for the hardware?

The SLF3S sensors are 4-pin devices (VDD, GND, SDA, and SCL) and do not appear
to have a physical interrupt pin. Documenting it here might mislead device tree
authors into configuring phantom interrupts.

> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        flow-sensor@8 {
> +            compatible = "sensirion,slf3s-0600f";
> +            reg = <0x08>;
> +            vdd-supply = <&reg_3v3>;
> +            interrupt-parent = <&gpio0>;
> +            interrupts = <0 IRQ_TYPE_EDGE_RISING>;

[Severity: Low]
Could these interrupt properties be removed from the example, since the
hardware does not have an interrupt pin?

> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260728214943.29820-1-wafgo01@gmail.com?part=2