All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mohit Mishra <mishraloopmohit@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Teddy Wang <teddy.wang@siliconmotion.com>,
	linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] staging: sm750fb: Remove dead VALIDATION_CHIP preprocessor blocks
Date: Tue, 28 Jul 2026 09:14:29 +0200	[thread overview]
Message-ID: <2026072852-whole-commuting-cd30@gregkh> (raw)
In-Reply-To: <20260725090750.113598-1-mishraloopmohit@gmail.com>

On Sat, Jul 25, 2026 at 02:37:48PM +0530, Mohit Mishra wrote:
> @@ -1020,9 +994,7 @@
>  #define CRT_DISPLAY_CTRL_CRTSELECT                    BIT(25)
>  #define CRT_DISPLAY_CTRL_RGBBIT                       BIT(24)
>  
> -#ifndef VALIDATION_CHIP
>      #define CRT_DISPLAY_CTRL_CENTERING                BIT(24)
> -#endif

The indentation makes no sense here now, right?

>  #define CRT_DISPLAY_CTRL_LOCK_TIMING                  BIT(23)
>  #define CRT_DISPLAY_CTRL_EXPANSION                    BIT(22)
>  #define CRT_DISPLAY_CTRL_VERTICAL_MODE                BIT(21)
> @@ -1121,22 +1093,17 @@
>  
>  /* This vertical expansion below start at 0x080240 ~ 0x080264 */
>  #define CRT_VERTICAL_EXPANSION                        0x080240
> -#ifndef VALIDATION_CHIP
>      #define CRT_VERTICAL_CENTERING_VALUE_MASK         (0xff << 24)
> -#endif

Same here :(

And elsewhere in this patch.

Always look at the end result of your change please.

thanks,

greg k-h

      parent reply	other threads:[~2026-07-28  7:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-25  9:07 [PATCH v2 1/2] staging: sm750fb: Remove dead VALIDATION_CHIP preprocessor blocks Mohit Mishra
2026-07-25  9:07 ` [PATCH v2 2/2] staging: sm750fb: Remove unused function sm750_enable_dma Mohit Mishra
2026-07-25  9:22 ` [PATCH v2 1/2] staging: sm750fb: Remove dead VALIDATION_CHIP preprocessor blocks Dan Carpenter
2026-07-28  7:14 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026072852-whole-commuting-cd30@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mishraloopmohit@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.