From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B884F27442 for ; Wed, 29 Jul 2026 00:05:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785283524; cv=none; b=M3IIp2qc9tLAcqwjlxgjWwjfbLoUwCuWzfZn4iKlj1qeBanyTQJ4n3JdGufxUujae79qbO7IhhTp1VmOeYeljEF3q/wUgpaXWPDY8z4choWng/jiTtWWFX2QjATLbRFp7Xu+4urExGDe8KbUY5/hNWCBrO5wunMOAukO5+Ec5pA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785283524; c=relaxed/simple; bh=5BXHm43osJoPriHeLFf7/AenR3tW2wFtl1rbGcgvBpI=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=WXo5Hn6ELs41YqLhwFDfUrOnNhtkHC6/Ue91J/IHHSmL0RXuwDpmzuIKAZp2ariEVRHfTREwCnhc0A7k9C3Lyugo4ZSWCMG9DSIQzaYOo2WcvFlMggcdRTd3XGVcVZCKH8LuuxnfNKi6tbb6/iJPZqtgBtqhc1NgJauxwWtJiB0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OINPrzqx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OINPrzqx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E09F1F00A3D; Wed, 29 Jul 2026 00:05:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785283521; bh=Q2bO/IK7a9uLzwFesE3e+fFNqPEQHWacg+Hdj77Xvac=; h=Date:From:To:Cc:Subject:References; b=OINPrzqxGqCh7iWQXTNIA4EXU6/yEdXPa2lACxYOiBQd8z06W7X8YPEuqpfZ9HdY4 3z3ZvLRYH2Q6Y/fQqLpbgUgBo220lpvHHjgk1vA1WElNne55r5U/HSQp/mkY70vTma yDG4ccS7GrNRyFo6ViCXDEnE6r1oSne/IwQMef3YqBY1q3XiA3iYeept0taAuouV8P TbHqNJU+pbRslogSAAgsBIoQdZTtqyeAxKZk57YXcR6bBWIlLTFrx1jwplhR7bMsMB tIpRPxSbBE/Ot7CLSKh15+wfkKDY34ATE8H0lXuxFSIeX4KHeu/O2BbVsBGxeo033d aG2QBkP6eNFLw== Received: from rostedt by gandalf with local (Exim 4.99.4) (envelope-from ) id 1woro4-00000006UcC-0Y3Z; Tue, 28 Jul 2026 20:05:56 -0400 Message-ID: <20260729000555.984000881@kernel.org> User-Agent: quilt/0.69 Date: Tue, 28 Jul 2026 20:05:28 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , David Laight Subject: [for-next][PATCH 05/16] kernel/trace/trace_printk: Use kstrdup() instead of kmalloc() and strcpy() References: <20260729000523.093060274@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 From: David Laight Link: https://patch.msgid.link/20260606202633.5018-34-david.laight.linux@gmail.com Signed-off-by: David Laight Reviewed-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt --- kernel/trace/trace_printk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/trace/trace_printk.c b/kernel/trace/trace_printk.c index 3ea17af60169..98171a2398e4 100644 --- a/kernel/trace/trace_printk.c +++ b/kernel/trace/trace_printk.c @@ -71,10 +71,9 @@ void hold_module_trace_bprintk_format(const char **start, const char **end) fmt = NULL; tb_fmt = kmalloc_obj(*tb_fmt); if (tb_fmt) { - fmt = kmalloc(strlen(*iter) + 1, GFP_KERNEL); + fmt = kstrdup(*iter, GFP_KERNEL); if (fmt) { list_add_tail(&tb_fmt->list, &trace_bprintk_fmt_list); - strcpy(fmt, *iter); tb_fmt->fmt = fmt; } else kfree(tb_fmt); -- 2.53.0