From: sashiko-bot@kernel.org
To: "Shawn Guo" <shengchao.guo@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v8 6/6] arm64: dts: qcom: Add device tree for Nord RRD board
Date: Wed, 29 Jul 2026 01:13:14 +0000 [thread overview]
Message-ID: <20260729011314.ED3B81F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260729010022.875799-7-shengchao.guo@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The comment for PMIC A describes it as 'PMM8650AU' but the compatible string used is 'qcom,pmm8654au-rpmh-regulators'.
--
--- Patch [6]: [PATCH v8 6/6] arm64: dts: qcom: Add device tree for Nord RRD board ---
commit 563913f28894928090f9bd89b1b6b23bd7792224
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>
arm64: dts: qcom: Add device tree for Nord RRD board
Add initial device tree for the Qualcomm Dragonwing IQ10 RRD (Robotics
Reference Design) board, which is built on Nord Embedded variant. Enable
the debug UART, UFS storage, PMICs, I2C and SPI.
> diff --git a/arch/arm64/boot/dts/qcom/nord-rrd.dts b/arch/arm64/boot/dts/qcom/nord-rrd.dts
> new file mode 100644
> index 0000000000000..a2a19f2304fa1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/nord-rrd.dts
[ ... ]
> +&apps_rsc {
> + /* PMIC A - Kobra_MM (PMM8650AU) - SID 0x0, Bus E0 */
> + regulators-0 {
> + compatible = "qcom,pmm8654au-rpmh-regulators";
[Severity: Low]
This isn't a bug, but there is a mismatch between the comment and the
compatible string here. The comment describes the PMIC as PMM8650AU, but
the compatible string is for pmm8654au. Could you clarify which one is
accurate for this hardware?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260729010022.875799-1-shengchao.guo@oss.qualcomm.com?part=6
prev parent reply other threads:[~2026-07-29 1:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 1:00 [PATCH v8 0/6] Add initial device trees for Nord platform Shawn Guo
2026-07-29 1:00 ` [PATCH v8 1/6] arm64: dts: qcom: Add device tree for Nord SoC series Shawn Guo
2026-07-29 1:14 ` sashiko-bot
2026-07-29 1:00 ` [PATCH v8 2/6] arm64: dts: qcom: Add device tree for Nord GearVM variant Shawn Guo
2026-07-29 1:00 ` [PATCH v8 3/6] arm64: dts: qcom: Add device tree for Nord Embedded variant Shawn Guo
2026-07-29 1:10 ` sashiko-bot
2026-07-29 1:00 ` [PATCH v8 4/6] dt-bindings: arm: qcom: Document Nord reference boards Shawn Guo
2026-07-29 1:08 ` sashiko-bot
2026-07-29 1:00 ` [PATCH v8 5/6] arm64: dts: qcom: Add device tree for Nord Ride board Shawn Guo
2026-07-29 1:00 ` [PATCH v8 6/6] arm64: dts: qcom: Add device tree for Nord RRD board Shawn Guo
2026-07-29 1:13 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729011314.ED3B81F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shengchao.guo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.