From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 214422D7D47 for ; Wed, 29 Jul 2026 01:23:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785288207; cv=none; b=EWhaGyaQNlaDITvwZZvBl9MnakjfEYnyPuHn3nZtiNyAQpKi5XzZPwIdw4R100jFyJcNeKyYUNSEMZoA9IShGdXxU0l42pEI55P8IHmMj6KvhyxC7uenjTQfZxpjuJdhw/uI0J1te0By1MJAbXgSEDQ2yV7J/MuWo9heqSwFhZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785288207; c=relaxed/simple; bh=ruyCAl/d75W453410VelrLvh/Qfpj9qdc2hdxBMy15I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WHU3viLExyQUTvfbaLzmQPwLbtTDvFHu9SGH9J/YN0zMrR3dAQLlz5KZX/UPZUgdV/5JZm1SW1Ur4+ZhxWpDylHrbzhCx76OoDGARSdUioLGoinaBUAbg6UQCO2ZAvL01kGfe18Nsp4kcU8ZohZUg2RSeE+0yv0+UvEl2IZ9RgI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n/2Tg6Wi; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n/2Tg6Wi" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ccf2360620so4130125ad.3 for ; Tue, 28 Jul 2026 18:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785288203; x=1785893003; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=2AGRW0GPVXdo/+h/vfV0tTRF7kuY/c8KFwUfzyJ8FbM=; b=n/2Tg6WiVuW1RyAD/vL1y34Xot70OI7D9mMONLaMpnJTagUfWFKJC5n42yEPlxN1vx bi38Cw3H1wEuH5vE7Hr0vFPwlgKZ863ij+l1bUZ8Z2trTTspldLA1aEjcxtGWLRPRjvk 3B6WqSTu2pjGKc4Ctx85NOtbkPwdPx4XLoNPaq4sZeNkn7zrHtBr5Pab729+r9hp6+9T FkMyUXy6L2FeOPTNxqV0GzHs4CXeB15Qy3jxKP6u65Ej0gL0ufFzzZRZYn4hjpTqHY4t d1PVz1pBR3zh8Wxyroru5ftM4r8A9rnJYjUCPJlI7C8ZPsPa9lHu50FIcj4O2DtWdJHJ 0UCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785288203; x=1785893003; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2AGRW0GPVXdo/+h/vfV0tTRF7kuY/c8KFwUfzyJ8FbM=; b=o015Z//sUvBKOY/xmX7FHyEDFy32g8CnoZwNkioMKgxpg4oEtWBxQQFzm+YbWdYrG/ w6myvpy7XyQI1/1Oxs1YwbflyyPHRqXAI6sRgSsNyM2obBrqXi3OR6qDKfsrg0HL7EWu DHnkJ0cyWA9qSnX69Pl8zcmxSmiEONkp0wH2sf9csRxrObEZH5vavDa9BC3Q1a75/PYr ZLlw5A80pxCEz3ni/ONXquox7u4xqRCR5dIt0Mrmo0SiU3EMcK238OAmte94d6PrIZSc p6j9FqvcUvZwnE5uIP4B6LfTOk8VLTiecgLUl22drIRaTxKGuF63bgzGNjy3WgyKrCPM n+BQ== X-Forwarded-Encrypted: i=1; AHgh+RpWCwmZKSh/rfJ+CdKfrs6uQilMsvRP3n/umYGzf4V+QboXFLYckzyAPcWDM34nL+7pVL1+Ii2N3wVCPJw=@vger.kernel.org X-Gm-Message-State: AOJu0YyRy4AzAqHOt8QW//Zv/asep5ifppgAUhgVsG4WpMKSqaNdKZB5 E05CqWFSDjgm73b73Ue2du3aALsiTE7ytUYzikfj77sjExmdyBPdQelD X-Gm-Gg: AR+sD1061r/24rU3oZqPX/2+XiGG2Om1g0xqm58XNRNkaoavOU4WqgOj5Ec2yzATd6K 6BC/EJm919Iw8Ks5ZtspgQ0ExscIpEoXACTsR2OINr5EtNrPGOkyJqZ661xSNYR+obwLN5nd74L 3k3J95ZLHqqq7p+/UAbLwkpQPd9BDm7Li5FaPeTEuNXBCyV6FdRhM/TxnhqkfoMKgojw8FOYU6g TyyWPp7K4w6qSGk7VCoj2MDuUDcEXBuEbYclse6mOONeHINsthfI0mVxIa3Qndf351kx9rYqYYJ JC9uhvzV6IwZmz8ak9JTEMFBabi9355nHaaq8Ea641DvcvrcE9BaUyeHboMAfdvNB1WQiVSjvg6 +J8qXK5ZqrE51XB+DoxyYXNT7PGvIEuz3w5TFbCgUDx+EkweXX64hOSXhGUq/k4wXQLgvlsqlif ZDcjOR+qbdHahEdp0H/FrEK7sPVNxk7hyQ/S3p3hQ7HklojdS/F0mfA1kQgEU5gPA19jEnurdPl IIfE8wR9dFgC5NGPvqvA+P5MIp7JFICjOJ4kjmGVsuckvn1vwPCyH0Xya6Lkx9ieUKTNXhfL5XV 8m3ODqSEqE5uTRE18DyFzEkvk1zOVKzOsO6k3A== X-Received: by 2002:a17:902:fd83:b0:2c9:97a7:f544 with SMTP id d9443c01a7336-2d015d25a51mr49814735ad.42.1785288203225; Tue, 28 Jul 2026 18:23:23 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022bf7cb7sm3329575ad.68.2026.07.28.18.23.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 18:23:22 -0700 (PDT) From: Rosen Penev To: linux-edac@vger.kernel.org Cc: Frank Li , Borislav Petkov , Tony Luck , imx@lists.linux.dev (open list:EDAC-FSL_DDR), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] EDAC/fsl_ddr: use non devm for request_irq() Date: Tue, 28 Jul 2026 18:23:20 -0700 Message-ID: <20260729012320.616174-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We need to tear down the irq before edac_mc_free() to avoid a use after free on teardown as request_irq uses mci as dev_id. Signed-off-by: Rosen Penev --- drivers/edac/fsl_ddr_edac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c index f4cc89b26954..f1ddd1f47f2a 100644 --- a/drivers/edac/fsl_ddr_edac.c +++ b/drivers/edac/fsl_ddr_edac.c @@ -601,7 +601,7 @@ int fsl_mc_err_probe(struct platform_device *op) /* register interrupts */ pdata->irq = platform_get_irq(op, 0); - res = devm_request_irq(&op->dev, pdata->irq, + res = request_irq(pdata->irq, fsl_mc_isr, IRQF_SHARED, "[EDAC] MC err", mci); @@ -639,6 +639,7 @@ void fsl_mc_err_remove(struct platform_device *op) if (edac_op_state == EDAC_OPSTATE_INT) { ddr_out32(pdata, FSL_MC_ERR_INT_EN, 0); + free_irq(pdata->irq, mci); } ddr_out32(pdata, FSL_MC_ERR_DISABLE, -- 2.55.0