Re: [PATCH v5 2/3] dt-bindings: remoteproc: qcom,nord-pas: Document Nord PAS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The macro `IPCC_MPROC_ADSP0` is defined without a value in the YAML example, causing a cell count mismatch that breaks `dt_binding_check` validation.
--

--- Patch [2]: [PATCH v5 2/3] dt-bindings: remoteproc: qcom,nord-pas: Document Nord PAS ---
commit 6e5bdff8032d03019c9e668110ed03437c7f4597
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

dt-bindings: remoteproc: qcom,nord-pas: Document Nord PAS

Add a dedicated binding for the Qualcomm Nord SoC PAS devices: ADSP
and CDSPs. Nord ADSP uses CX and MX power domains while the CDSPs
add an NSP domain on top of that.

> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml
> new file mode 100644
> index 0000000000000..e90d2953ba692
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/clock/qcom,rpmh.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/mailbox/qcom-ipcc.h>
> +    #include <dt-bindings/power/qcom,rpmhpd.h>
> +    #define IPCC_MPROC_ADSP0

[Severity: Low]
Is this macro missing a value?

Because it is defined without a placeholder value, the C preprocessor will
evaluate it to nothing.

> +
> +    remoteproc@4c00000 {

[ ... ]

> +        glink-edge {
> +            interrupts-extended = <&ipcc IPCC_MPROC_ADSP0
> +                                         IPCC_MPROC_SIGNAL_GLINK_QMP
> +                                         IRQ_TYPE_EDGE_RISING>;
> +            mboxes = <&ipcc IPCC_MPROC_ADSP0 IPCC_MPROC_SIGNAL_GLINK_QMP>;

[Severity: Low]
Will this cause dt_binding_check validation to fail?

Since IPCC_MPROC_ADSP0 evaluates to nothing, the cell count for both
interrupts-extended and mboxes will be missing one cell. The ipcc interrupt
and mailbox controllers expect 3 and 2 cells respectively.

> +
> +            label = "adsp";
> +            qcom,remote-pid = <2>;
> +
> +            /* ... */
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260729023508.879752-1-shengchao.guo@oss.qualcomm.com?part=2