All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guixin Liu <kanie@linux.alibaba.com>
To: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Lukas Wunner" <lukas@wunner.de>, "Kees Cook" <kees@kernel.org>
Cc: linux-pci@vger.kernel.org, xlpang@linux.alibaba.com,
	oliver.yang@linux.alibaba.com
Subject: [PATCH v1 0/2] PCI: Add pci=nobwctrl to disable the PCIe bandwidth controller
Date: Wed, 29 Jul 2026 11:45:03 +0800	[thread overview]
Message-ID: <20260729034505.469107-1-kanie@linux.alibaba.com> (raw)

Enabling the PCIe bandwidth controller sets the Link Bandwidth Management
Interrupt Enable (LBMIE) and Link Autonomous Bandwidth Interrupt Enable
(LABIE) bits.  On some (typically old) platforms this has been observed to
cause boot hangs; commit 46a9f70e93ef ("PCI/bwctrl: Disable BW controller
on Intel P45 using a quirk") works around one such platform with a
per-device quirk.

A per-device quirk only helps once the offending device is identified and
a quirk has shipped, which is awkward for a boot hang since the machine
cannot be booted to report the culprit.  The only existing escape hatch,
pcie_ports=compat, is a blunt instrument that also disables AER, PME,
hotplug and DPC.

This series adds a pci=nobwctrl boot option to disable just the bandwidth
controller system-wide, giving users an immediate, rebuild-free workaround
while a targeted quirk is worked out.

Patch 1 adds the pci_bwctrl_available()/pci_no_bwctrl() infrastructure
(mirroring pci_aer_available()/pci_no_aer()) with no functional change.
Patch 2 wires up the pci=nobwctrl parameter and documents it.

Tested on a QEMU q35 topology with PCIe ports and switches: without the
parameter the bwctrl service devices are present as before; with
pci=nobwctrl they all disappear while PME/AER/hotplug services stay intact
and boot is clean.

Guixin Liu (2):
  PCI/bwctrl: Add pci_bwctrl_available()
  PCI: Add pci=nobwctrl parameter to disable the PCIe bandwidth
    controller

 Documentation/admin-guide/kernel-parameters.txt |  6 ++++++
 drivers/pci/pci.c                               |  2 ++
 drivers/pci/pci.h                               |  4 ++++
 drivers/pci/pcie/bwctrl.c                       | 12 ++++++++++++
 drivers/pci/pcie/portdrv.c                      |  3 ++-
 5 files changed, 26 insertions(+), 1 deletion(-)

-- 
2.43.7


             reply	other threads:[~2026-07-29  3:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  3:45 Guixin Liu [this message]
2026-07-29  3:45 ` [PATCH v1 1/2] PCI/bwctrl: Add pci_bwctrl_available() Guixin Liu
2026-07-29  3:52   ` sashiko-bot
2026-07-29  3:45 ` [PATCH v1 2/2] PCI: Add pci=nobwctrl parameter to disable the PCIe bandwidth controller Guixin Liu
2026-07-29  3:50   ` sashiko-bot
2026-07-29  7:01 ` [PATCH v1 0/2] PCI: Add pci=nobwctrl " Lukas Wunner
2026-07-29  8:28   ` Guixin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260729034505.469107-1-kanie@linux.alibaba.com \
    --to=kanie@linux.alibaba.com \
    --cc=bhelgaas@google.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=kees@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=oliver.yang@linux.alibaba.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=xlpang@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.