From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: linux-usb@vger.kernel.org
Cc: "Yehezkel Bernat" <YehezkelShB@gmail.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Andreas Noever" <andreas.noever@gmail.com>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Woody Suwalski" <terraluna977@gmail.com>
Subject: Re: [PATCH] thunderbolt: Initialize ->domain_released completion before it is being used
Date: Wed, 29 Jul 2026 08:55:54 +0200 [thread overview]
Message-ID: <20260729065554.GA20844@black.igk.intel.com> (raw)
In-Reply-To: <20260728065222.2550284-1-mika.westerberg@linux.intel.com>
On Tue, Jul 28, 2026 at 08:52:22AM +0200, Mika Westerberg wrote:
> Both Woody and Marek reported following crash:
>
> BUG: unable to handle page fault for address: fffffffffffffff8
> Call Trace:
> <TASK>
> device_release+0x43/0x90
> kobject_cleanup+0x3c/0x180
> icm_probe+0x19c/0x550 [thunderbolt]
> nhi_probe+0x1a4/0x370 [thunderbolt]
> local_pci_probe+0x41/0x90
> pci_call_probe+0x5b/0x1a0
> ...
>
> This only triggers on the error path when icm_probe() fails and the
> domain structure is released, it tries to complete() uninitialized
> completion.
>
> Fix this by initializing the completion earlier.
>
> Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Closes: https://lore.kernel.org/linux-usb/amdezCBiW4fd_DuB@mail-itl/
> Reported-by: Woody Suwalski <terraluna977@gmail.com>
> Closes: https://lore.kernel.org/linux-usb/62caf7f8-b403-d0dd-15bc-b31b56f71c28@gmail.com/
> Fixes: f5cc545f5969 ("thunderbolt: Wait for tb_domain_release() to complete when driver is removed")
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied to thunderbolt.git/fixes.
next prev parent reply other threads:[~2026-07-29 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 6:52 [PATCH] thunderbolt: Initialize ->domain_released completion before it is being used Mika Westerberg
2026-07-29 6:55 ` Mika Westerberg [this message]
2026-07-29 15:54 ` Woody Suwalski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729065554.GA20844@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=marmarek@invisiblethingslab.com \
--cc=terraluna977@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.