From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB0B63E5A2F for ; Wed, 29 Jul 2026 07:19:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785309566; cv=none; b=PNz6A1VGeMo8nwmgLLJlpCMD4EfkMyupSpv1R8y5isjZzY1xIa3meavtZzqKyfjs3YmcD0Vujq8zCky3PLUijrH3E1n4oc6pBooLtxN9ZH08KpPL0ikQOuNJd0XfwvKfzmYY6A4woDRsHHkmB7PKHP88peUifg5JCu9/Kf7ZKI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785309566; c=relaxed/simple; bh=pP4fF1laRgJDuWZ4+i9SyoiKqvqfiQpUxWe0F0Jh9Ak=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lvZ0KQ1FKzy+ob8uA6SuTA5p7z5ZpPvbEfDlD37Zt7SWtI56sfncX0wxIdPiUpHb63SyjzIjlKpUvODhoYDDvlRvT9jL0m42A2gD4xkHK6v3kuXjKDl+3J88Am5ppRJBO3x3BRAoDYsYcLrXLFJEYUB2KFEyheF306fowjJMLqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=lY8Ol8l2; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="lY8Ol8l2" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1785309557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=AWvv/tGxm6QJaUEHZNsJBGjnnWIXBs2hBaZEuk3xjWU=; b=lY8Ol8l29OuC6IEg8FnIQP7um37VM4AYSiAEkuZHCPVoV37TXlwC0Pv1wvUcz/QHqn/V7p qie0rXwjLjirkNdHtihFWY2z0loIAXb9EStmm3p4s0mEZeqJmv+evjnK9fHbQpQz4RxbGj Q7OH6fQnMhhH9A/ymq0BBllrsxzN9u8= From: Yuntao Wang To: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Cc: Nathan Chancellor , Nicolas Schier , Miguel Ojeda , Gary Guo , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= , Luis Augenstein , Steven Rostedt , Masahiro Yamada , Andrew Jones , Alexey Gladkov , Yuntao Wang Subject: [PATCH] kbuild: fix modules.builtin(.modinfo) targets in the top-level Makefile Date: Wed, 29 Jul 2026 15:17:37 +0800 Message-ID: <20260729071737.818007-1-yuntao.wang@linux.dev> Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Commit 7a342e6c7735 ("kbuild: move modules.builtin(.modinfo) rules to Makefile.vmlinux_o") moved the modules.builtin(.modinfo) rules from link-vmlinux.sh to Makefile.vmlinux_o, and added the corresponding targets to the top-level Makefile. Commit 39cfd5b12160 ("kbuild: extract modules.builtin.modinfo from vmlinux.unstripped") later moved these rules from Makefile.vmlinux_o to Makefile.vmlinux, but left the corresponding targets in the top-level Makefile unchanged. These modules.builtin(.modinfo) targets in the top-level Makefile should be moved alongside the vmlinux target, since they are now generated by Makefile.vmlinux. However, simply removing these trivial targets might be a better choice, as it makes the Makefile cleaner and avoids the need to keep them in sync across multiple files, reducing the chance of future mistakes. Fixes: 39cfd5b12160 ("kbuild: extract modules.builtin.modinfo from vmlinux.unstripped") Signed-off-by: Yuntao Wang --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 2f5bf24e3389..5f3f460fd10f 100644 --- a/Makefile +++ b/Makefile @@ -1352,7 +1352,7 @@ PHONY += vmlinux_o vmlinux_o: vmlinux.a $(KBUILD_VMLINUX_LIBS) $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.vmlinux_o -vmlinux.o modules.builtin.modinfo modules.builtin: vmlinux_o +vmlinux.o: vmlinux_o @: PHONY += vmlinux -- 2.55.0