All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Jan Kara <jack@suse.cz>
Cc: Amir Goldstein <amir73il@gmail.com>,
	ltp@lists.linux.it, AnonymeMeow <anonymemeow@gmail.com>
Subject: Re: [LTP] [PATCH 5/5] fanotify20: Skip on v7.2
Date: Wed, 29 Jul 2026 11:51:42 +0200	[thread overview]
Message-ID: <20260729095142.GA24216@pevik> (raw)
In-Reply-To: <wexuhnkssz5j5kswcmsj73l7i6yrhpsvg36t4hg2e3flxvp4l3@5jczb6r55haj>

> On Wed 29-07-26 11:17:17, Petr Vorel wrote:
> > fanotify_init() used to reject FAN_REPORT_PIDFD combined with
> > FAN_REPORT_TID with EINVAL. Since Linux v7.2, fanotify supports
> > reporting pidfds for thread IDs, so this combination is expected to
> > succeed.

> > The test that these flag combinations are allowed:
> >                 FLAGS_DESC(FAN_REPORT_PIDFD | FAN_REPORT_TID),
> > 		FLAGS_DESC(FAN_REPORT_PIDFD | FAN_REPORT_FID |
> > 			   FAN_REPORT_DFID_NAME),

> > Because the above flag combinations are already "tested" by the tests
> > that use them and we don't have any tests that >= 5.10 has support for
> > FAN_MARK_FILESYSTEM etc just simply skip the test on v7.2.

> > Reported-by: AnonymeMeow <anonymemeow@gmail.com>
> > Suggested-by: Amir Goldstein <amir73il@gmail.com>
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>

> I agree with the intention. I just think that if the option is called
> max_kver, then this suggest this is the last version where the test should
> be run. Not the first version where the test shouldn't be run. So the name
> is a bit confusing to me.

Good catch ...

> 								Honza

...
> >  static struct tst_test test = {
> >  	.setup = do_setup,
> > +	.max_kver = "7.2",

... it was supposed to be:
.max_kver = "7.1"

FYI .max_kver is a new implementation (part of the patchset, I just did not want
to bother you with LTP internals, that's why you're Cc only on fanotify20.c
patch) and works exactly as you suggested (run on kernel <= 7.1, skip on >= 7.2).

If there is no other objection with with the patchset, I'll fix this before
merge.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-07-29  9:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  9:17 [LTP] [PATCH 0/5] Add support for .max_kver Petr Vorel
2026-07-29  9:17 ` [LTP] [PATCH 1/5] lib: Rename function check_kver() => check_min_kver() Petr Vorel
2026-07-29  9:17 ` [LTP] [PATCH 2/5] lib: Add support for max_kver to struct tst_test and tst_fs Petr Vorel
2026-07-29  9:17 ` [LTP] [PATCH 3/5] execve04: Use .max_kver Petr Vorel
2026-07-29  9:17 ` [LTP] [PATCH 4/5] creat07: " Petr Vorel
2026-07-29  9:17 ` [LTP] [PATCH 5/5] fanotify20: Skip on v7.2 Petr Vorel
2026-07-29  9:27   ` Jan Kara
2026-07-29  9:51     ` Petr Vorel [this message]
2026-07-29  9:58       ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260729095142.GA24216@pevik \
    --to=pvorel@suse.cz \
    --cc=amir73il@gmail.com \
    --cc=anonymemeow@gmail.com \
    --cc=jack@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.