From: sashiko-bot@kernel.org
To: Biju <biju.das.au@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org,
wsa+renesas@sang-engineering.com, conor+dt@kernel.org
Subject: Re: [PATCH v5 1/9] dt-bindings: reset: renesas,rzg2l-usbphy-ctrl: Document RZ/G3L support
Date: Wed, 29 Jul 2026 11:59:05 +0000 [thread overview]
Message-ID: <20260729115906.0D93D1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260729115022.222340-2-biju.das.jz@bp.renesas.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `regulators` object node is missing the `additionalProperties: false` constraint.
--
--- Patch [1]: [PATCH v5 1/9] dt-bindings: reset: renesas,rzg2l-usbphy-ctrl: Document RZ/G3L support ---
commit 222a9a4d47d2afbc7efadd9794f65d8f61be1bb8
Author: Biju Das <biju.das.jz@bp.renesas.com>
dt-bindings: reset: renesas,rzg2l-usbphy-ctrl: Document RZ/G3L support
This commit documents the Renesas RZ/G3L (r9a08g046) USB PHY controller
bindings. It introduces a regulators sub-node to handle per-port vbus0 and
vbus1 entries, which replaces the single regulator-vbus property used by
other compatible SoCs.
> diff --git a/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.yaml b/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.yaml
> index c83469a1b379a..9e0c450976573 100644
> --- a/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.yaml
> +++ b/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.yaml
[ ... ]
> @@ -50,6 +51,28 @@ properties:
> $ref: /schemas/regulator/regulator.yaml#
> unevaluatedProperties: false
>
> + regulators:
> + type: object
> + description:
> + list of vbus regulators provided by this controller.
> +
> + properties:
[Severity: Low]
Should this regulators object node include an additionalProperties: false
constraint?
Without it, any arbitrary or misspelled properties added inside the regulators
sub-node might silently pass schema validation.
> + vbus0:
> + type: object
> + description: Port 1 USB VBUS regulator
> + $ref: /schemas/regulator/regulator.yaml#
> + unevaluatedProperties: false
> +
> + vbus1:
> + type: object
> + description: Port 2 USB VBUS regulator
> + $ref: /schemas/regulator/regulator.yaml#
> + unevaluatedProperties: false
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260729115022.222340-1-biju.das.jz@bp.renesas.com?part=1
next prev parent reply other threads:[~2026-07-29 11:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 11:50 [PATCH v5 0/9] Add RZ/G3L USB2.0 host support Biju
2026-07-29 11:50 ` Biju
2026-07-29 11:50 ` [PATCH v5 1/9] dt-bindings: reset: renesas,rzg2l-usbphy-ctrl: Document RZ/G3L support Biju
2026-07-29 11:59 ` sashiko-bot [this message]
2026-07-29 11:50 ` [PATCH v5 2/9] reset: rzg2l-usbphy-ctrl: Introduce info struct for match data Biju
2026-07-29 11:50 ` [PATCH v5 3/9] reset: rzg2l-usbphy-ctrl: Add RZ/G3L support Biju
2026-07-29 11:50 ` [PATCH v5 4/9] regulator: renesas-usb-vbus-regulator: Add RZ/G3L VBUS regulator support Biju
2026-07-29 11:50 ` [PATCH v5 5/9] dt-bindings: phy: renesas,usb2-phy: Document RZ/G3L PHY bindings Biju
2026-07-29 11:50 ` Biju
2026-07-29 11:50 ` [PATCH v5 6/9] phy: renesas: phy-rcar-gen3-usb2: Add RZ/G3L support Biju
2026-07-29 11:50 ` Biju
2026-07-29 11:50 ` [PATCH v5 7/9] phy: renesas: phy-rcar-gen3-usb2: Fix devm action registration for disabled VBUS regulator Biju
2026-07-29 11:50 ` Biju
2026-07-29 12:08 ` sashiko-bot
2026-07-29 11:50 ` [PATCH v5 8/9] arm64: dts: renesas: r9a08g046: Add USB2.0 device nodes Biju
2026-07-29 12:12 ` sashiko-bot
2026-07-29 11:50 ` [PATCH v5 9/9] arm64: dts: renesas: r9a08g046l48-smarc: Add USB2.0 support Biju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729115906.0D93D1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=biju.das.au@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.