Re: [PATCH V4 1/6] tools/perf: Move powerpc VPA-DTL auxtrace init into a separate file

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing forward declarations for `struct evsel` and `struct auxtrace_record` in `powerpc-vpadtl.h`.
--

--- Patch [1]: [PATCH V4 1/6] tools/perf: Move powerpc VPA-DTL auxtrace init into a separate file ---
commit d6642397942d2744eabc1f173cb06052b8c22930
Author: Athira Rajeev <atrajeev@linux.ibm.com>

tools/perf: Move powerpc VPA-DTL auxtrace init into a separate file

This commit factors out the VPA-DTL auxtrace recording initialization logic
from auxtrace.c into a new file, vpa-dtl.c. It reduces auxtrace.c to a thin
dispatcher that calls per-PMU init functions like vpa_dtl_recording_init().
This preparation aims to accommodate additional PMUs like HTM without
creating a monolithic file.

[ ... ]

> diff --git a/tools/perf/util/powerpc-vpadtl.h b/tools/perf/util/powerpc-vpadtl.h
> index ca809660b9bb7..41e09b17a353d 100644
> --- a/tools/perf/util/powerpc-vpadtl.h
> +++ b/tools/perf/util/powerpc-vpadtl.h
> @@ -20,4 +20,5 @@ struct perf_pmu;
>  int powerpc_vpadtl_process_auxtrace_info(union perf_event *event,
>  				  struct perf_session *session);
>  
> +struct auxtrace_record *vpa_dtl_recording_init(struct evsel *pos, int *err);

[Severity: Low]
This isn't a bug, but could we add forward declarations for struct evsel and
struct auxtrace_record before they are used in this function prototype?

Without prior declarations, using undeclared structures in a function
parameter list gives them function prototype scope in C. While the current
inclusion order in the source files hides the issue, this could cause
compiler warnings about structures declared inside a parameter list, or
build failures if this header is included in a different context. Adding
forward declarations here would also align with the perf subsystem guidelines
for header files.

>  #endif

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260729124400.65009-1-atrajeev@linux.ibm.com?part=1