From: sashiko-bot@kernel.org
To: "Lorenzo Bianconi" <lorenzo.bianconi@oss.qualcomm.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI/pwrctrl: tc9563: rely on regmap APIs
Date: Wed, 29 Jul 2026 13:43:09 +0000 [thread overview]
Message-ID: <20260729134310.149121F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260729-pci-pwrctrl-tc956x-regmap-v1-1-20ce61a3ce12@oss.qualcomm.com>
> Replace the custom tc9563_pwrctrl_i2c_{read,write,bulk_write} functions
> with standard regmap APIs. The device uses 24-bit big-endian register
> addresses and 32-bit little-endian register values over I2C, which is
> directly supported by regmap.
>
> This removes the open-coded I2C transfer handling and lets the regmap
> core handle formatting, locking, and multi-register coalescing.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260729-pci-pwrctrl-tc956x-regmap-v1-0-20ce61a3ce12@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-07-29 13:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 13:34 [PATCH 0/2] Rely on regmap APIs in tc9563 PCI/pwrctrl driver Lorenzo Bianconi
2026-07-29 13:34 ` [PATCH 1/2] PCI/pwrctrl: tc9563: rely on regmap APIs Lorenzo Bianconi
2026-07-29 13:43 ` sashiko-bot [this message]
2026-07-29 14:42 ` Manivannan Sadhasivam
2026-07-29 13:34 ` [PATCH 2/2] PCI/pwrctrl: tc9563: use devm-managed I2C dummy device allocation Lorenzo Bianconi
2026-07-29 13:44 ` sashiko-bot
2026-07-29 14:03 ` Lorenzo Bianconi
2026-07-29 14:43 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729134310.149121F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.