All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Aurelien Jarno" <aurelien@aurel32.net>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 5/6] riscv: dts: spacemit: k1-orangepi-r2s: fix maximum CPU core voltage
Date: Wed, 29 Jul 2026 15:15:10 +0000	[thread overview]
Message-ID: <20260729151510.9F5AF1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260729150722.1598630-6-aurelien@aurel32.net>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The CPU core voltage limit in the Banana Pi CM6 devicetree remains at a dangerously high 3.45V, risking permanent hardware damage.
--

--- Patch [5]: [PATCH 5/6] riscv: dts: spacemit: k1-orangepi-r2s: fix maximum CPU core voltage ---
commit e89342d2210b8ee4353584159b6747437181135a
Author: Aurelien Jarno <aurelien@aurel32.net>
Subject: riscv: dts: spacemit: k1-orangepi-r2s: fix maximum CPU core voltage

This commit lowers the maximum output voltage of the buck1 and buck2
regulators on the OrangePi R2S board from 3.45V to 1.050V. This prevents
potential permanent CPU damage from misconfigurations or privileged userspace
requests.

Link: https://sashiko.dev/#/message/20260728211020.1248676-2-aurelien%40aurel32.net

> diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
> index 24591f7c3d236..2d1ba34cb00e2 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
[ ... ]
>  			buck2 {
>  				regulator-min-microvolt = <500000>;
> -				regulator-max-microvolt = <3450000>;
> +				regulator-max-microvolt = <1050000>;
>  				regulator-ramp-delay = <5000>;
>  				regulator-always-on;
>  			};

[Severity: High]
This is a pre-existing issue, but I noticed the Banana Pi CM6 devicetree
appears to retain the same 3.45V maximum voltage limit for its CPU core 
regulators.

Should arch/riscv/boot/dts/spacemit/k1-bananapi-cm6.dtsi also be updated
to prevent similar hardware damage risks?

arch/riscv/boot/dts/spacemit/k1-bananapi-cm6.dtsi:
			buck1 {
				regulator-min-microvolt = <500000>;
				regulator-max-microvolt = <3450000>;
				regulator-ramp-delay = <5000>;
				regulator-always-on;
			};

			buck2 {
				regulator-min-microvolt = <500000>;
				regulator-max-microvolt = <3450000>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260729150722.1598630-1-aurelien@aurel32.net?part=5

  reply	other threads:[~2026-07-29 15:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 15:02 [PATCH 0/6] riscv: dts: spacemit: fix maximum CPU core voltage for K1 boards Aurelien Jarno
2026-07-29 15:02 ` Aurelien Jarno
2026-07-29 15:02 ` [PATCH 1/6] riscv: dts: spacemit: k1-bananapi-f3: fix maximum CPU core voltage Aurelien Jarno
2026-07-29 15:02   ` Aurelien Jarno
2026-07-29 15:19   ` sashiko-bot
2026-07-29 15:02 ` [PATCH 2/6] riscv: dts: spacemit: k1-milkv-jupiter: " Aurelien Jarno
2026-07-29 15:02   ` Aurelien Jarno
2026-07-29 15:14   ` sashiko-bot
2026-07-29 15:02 ` [PATCH 3/6] riscv: dts: spacemit: k1-orangepi-rv2: " Aurelien Jarno
2026-07-29 15:02   ` Aurelien Jarno
2026-07-29 15:02 ` [PATCH 4/6] riscv: dts: spacemit: k1-musepi-pro: " Aurelien Jarno
2026-07-29 15:02   ` Aurelien Jarno
2026-07-29 15:02 ` [PATCH 5/6] riscv: dts: spacemit: k1-orangepi-r2s: " Aurelien Jarno
2026-07-29 15:02   ` Aurelien Jarno
2026-07-29 15:15   ` sashiko-bot [this message]
2026-07-29 15:02 ` [PATCH 6/6] riscv: dts: spacemit: k1-bananapi-cm6: " Aurelien Jarno
2026-07-29 15:02   ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260729151510.9F5AF1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=aurelien@aurel32.net \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.