From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C76424C900A for ; Wed, 29 Jul 2026 15:57:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785340636; cv=none; b=dMwpfaTmx32Elf2N9hHePe+CwPAZvESIQmNl/3PCyr92xnM6hEw6IOuWQ4q+8sPNgqy+tktM6OuUTyKP4TaXqeKaSOfYHJhyyOnWIzvhar3Xs6bVDeLR1s2kkkYgJ7UG9mVDsttsFvrYC5qpWI9lhAjP0L3SXJSgM31ohV4Jf74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785340636; c=relaxed/simple; bh=YFCARu1iDAQemSo9hHRVwGO0Zi1LAiupPz1rAzpgHvI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QMCxfDQwxhHIp7+ZXfMXr8sioUtvbdhVjePYwY7PVCD0yxMr9gYcqipXzm6d2/8uqqL8NI22T7Fl1tMOIUFBhjeNZ9aDAWlloVuaCpXzhRllFYANTWlQvVXIcvWXNUvctNTObOoR2BzrLEtZS17o5rJIEHHK7ep+0TuJjcS36So= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RDbDCgOU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IyAl9dpQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RDbDCgOU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IyAl9dpQ" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66TF3LNB2108372 for ; Wed, 29 Jul 2026 15:57:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=QToEERHB/YX j06omeVD4G3Qa5rVxfi5IbCI988AYdmc=; b=RDbDCgOUmHwGk3nNfzvBwVjdu1c T1f8qh/c04cVKZbKjexPmUkU9BvSuNjZl/95c4OXocn2EHqeashGBG+8lRsETOuv ePBVo4L2OpjGFWs1Yry/HOSdPtwGMILSr0iVCvf1+21hyfO5SiugNMzH68FHRJGH nwZosLbTpnNIVXuyBGrIbwkBoUoR2RkcjyFI+PnV0MTBj4Af1bmV+8jMmUj1L5Vj o5Kz3Tzd0wv1FrN9OEUbFPSn9cmMGxvjl+9S+m+W6HTlz+NK8CqAqG5vyHpDLLA0 sTjw5J+HIi1r4EaWXjKmeYN/nPHfvi+T6fxjlGk46TG7ROZ3Egmb3CuA75Q== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fqkds8g04-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2026 15:57:13 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8484ba00601so1304225b3a.1 for ; Wed, 29 Jul 2026 08:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785340632; x=1785945432; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QToEERHB/YXj06omeVD4G3Qa5rVxfi5IbCI988AYdmc=; b=IyAl9dpQu87i+9Mzrt6ClTe2Lf8ZwYIH+UUFrc+dus8K/XXLZHsY9rYSRiXFFnnTkZ IN0Bjz20kWtUAxpE2seU8d98lLFeoBrlavGyIMFhqdRaXzEQYLpwFSIiWK2JccBUw7dq svw90drxlA4G+s+LF4ykl3heMYnXq9gTN2RSMJesJfGm+oosQ5gH0BOeptJ6LmniePWx I8T4b/+vUeanMqJoN+iHsCfndpTkog/IMyrogZ7psAaeyh9Dc6hR/mP00avOl0pBbaET Ow0RsEYWSXH1FZEEpnC3m2GRu8GT/hl04CEH+2+BAPo5cOTN5rmZtgvrFecMGJQ2qvdO WMvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785340632; x=1785945432; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=QToEERHB/YXj06omeVD4G3Qa5rVxfi5IbCI988AYdmc=; b=FkLZCLkLXkQubSKB11IOEHKpG2FzfIiZfwIVaVaIKflm+SHsiRX/bCvMsivn1Co8Rg /qs/IBkbF8WTkVmncSHUWZy0EGHIQX6ZPjWAMvsyoPs3IOM5LiuMuLGp03xTDtgeByz8 cX9lL739X2pVOsYUEcvIatbwg5fdT8zS1wQoqP6WaUGSYz2VV0e734QvXqFRpKywfAAy OQPCrhNglp4lNdrwKloEgm+8o7J2QO7UOy8kNW7s2rhYnMTFnHzfSO+a+7JguW1LzcDY diqVfRmdiFEtUkb56GFCH6xwd80heBG+tp7Cur7KAAxxyVN5zV+2HvLKMnj9CIdTifcE QmTQ== X-Forwarded-Encrypted: i=1; AHgh+RouUodyNsELPKcYBrYR1fFW+NU4q5fOMV+eUpBATu6bVEjmr9UX5XIDe1oqKMm/W3Uk5Sitb4S82AnkoK0=@vger.kernel.org X-Gm-Message-State: AOJu0YwwVHyNrf69RQA+AcpPzrMvor+IWYd7MQVxei4SpsiMovOuh8yL TUCU+0dRxNR4hc16zJq6Q7eapdXJB45rr8hHEaprpOWqERVqYX10X/V8uecz7Ya6N32hkDBUmcM wpoDSLz2feGvZo62WL49mPYqi7I8uG3SiZpsUj5bhThpRnm5eUmA6NJ4rc3Dqnrkp0mw= X-Gm-Gg: AR+sD115LKya5Nzg8pl4IwoeyQjIobRsPD+qzcMcnl0+Jt1HHsbxqod7cmwp6UGB+Uo 4QPj+zkRaMJuGGRDy+qDT3VEsuCgLzQtx+MjYconOvVMvVeJPP11NHwOAJ1pjuuRIMmm2uBox9u GlTy49I3TFPFGYrPZuZLJusND4FEnZWjmcUoCOTS0ybewHf3GtA/2bM06jGejinpasMeeO9FYOd 5uzYaS+DpMbH0XFVOBSzNMim53n/M1XJBIGevzfLoPgp4Dc+VPfbDFvyVTC6ByO0DnqS8cZ7h10 8RV0W5C4EdRLwuQ4bi/P1GnVqdDoITaYqfiQxdu07k52uxBW+4y+ibTEjP0cOOXktZ92EyV5AYl cFZCh3lDbnHyUZ2hk2lRQYHjm407yhVinvNbXKNT5htRN1EA= X-Received: by 2002:a05:6a00:39a8:b0:848:7731:d95a with SMTP id d2e1a72fcca58-84e933e8275mr7336323b3a.37.1785340632513; Wed, 29 Jul 2026 08:57:12 -0700 (PDT) X-Received: by 2002:a05:6a00:39a8:b0:848:7731:d95a with SMTP id d2e1a72fcca58-84e933e8275mr7336308b3a.37.1785340632131; Wed, 29 Jul 2026 08:57:12 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbdba929728sm1055763a12.29.2026.07.29.08.57.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 08:57:11 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v7 13/17] drm/msm/gem: Validate lazy VM in GEM_NEW Date: Wed, 29 Jul 2026 08:55:50 -0700 Message-ID: <20260729155609.20190-14-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260729155609.20190-1-robin.clark@oss.qualcomm.com> References: <20260729155609.20190-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI5MDEyNyBTYWx0ZWRfXyryYE2C8SRL8 IihZVkrbjN+6A6ip+xs6u/l03vA03gjuZv6eL9+YLauEWIS/Gv8taD9VupawfokMWjlru84z0s/ L5aTS6r4Vq3+IGT39OmL2gLwrOaEw1g= X-Proofpoint-ORIG-GUID: ng-lt5TU7Le6bdkpxm8dA5VpM3FdUCU6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI5MDEyNyBTYWx0ZWRfXxuCaoB/5BINW HSnjEri2X1hxyPCW7Pp8yK3/Zen74vudxYnOJ48WQ0IAc2RySlIqC2KO29o7d8ODQ1AqVXH8pNC DFk8REwAFCgO75p51Zm2g5gTnyKXJrK6bc2S9xSuEh9FLelvhxNo/XK6R3azhUTVwst62d3JtG/ io3M+7ElbJM3juNk8fUy72mZrroK/pGf4Tvh9IgP3uj2meMlervh3Upf9luPDxcn+iu+u7xsTIP pAnDtfnHRR7lE6B80CVIxZ4hjNqIHy9fBWYICqVoQTzJYjexZmE1I0pkQv1Oy59fG3e+MT9PrQM 3/1oySPwpxYX25u8eGeQdKUL1A4a54dkdozmrB+odHz4ZzaiU5EIt4BqWsFIryyDcp+HJCqKG6r p3Qdj7OZ/xK+3eGeE0GKHpD8PxwnwIne4km3YpJ4lSqhVxWnYyWdwLjUtdQRF8Do3iAsfyvoQeR kdiPXR84pqDPo8FDEcg== X-Authority-Analysis: v=2.4 cv=VJTtWdPX c=1 sm=1 tr=0 ts=6a6a22d9 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=VGCgC6sU4evaG-_1UnEA:9 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: ng-lt5TU7Le6bdkpxm8dA5VpM3FdUCU6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_06,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607290127 Otherwise creating a _NO_SHARE BO before any BOs are mapped could cause a NPE. Reported-by: Sashiko Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index 535c6e1acb3c..de4e60e28a71 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -1140,9 +1140,13 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file, int ret; if (flags & MSM_BO_NO_SHARE) { + struct msm_drm_private *priv = dev->dev_private; struct msm_context *ctx = file->driver_priv; struct drm_gpuvm *vm = msm_context_vm(dev, ctx); + if (!priv->gpu || !vm) + return UERR(EINVAL, dev, "not supported with shared VM"); + r_obj = drm_gpuvm_resv_obj(vm); } -- 2.55.0