From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C66764D8D8D for ; Wed, 29 Jul 2026 15:57:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785340639; cv=none; b=fC6DAecy5Brof7N5Qt1fgnsMQFGaupCTLZUG+RyT5PFypWYrZ09SdTnjq3pW5ESqZS0WSht0Jxi8ydMDjzCSYUS2v8TcvSrpD5WLXu7xw8O39P0MbRzZTZ34xLeAZgYVcc5vJttLSZRYwKjy4mTATCyVLveiXrQ8FD3pnuXO23o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785340639; c=relaxed/simple; bh=5jusFGwn3Qm4zEYz94oUfi+TSGTz9Tl8cBbI4B7YQDk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YtoP1V10hX4tXkh4Ep9ps6GMaN+b+eBkCCNYThNUqZCLKnaiTXwA1hmO8HtxzgLK2lrdWKgyTUX0qk5kaEvbO3bUlrcBGdAxhghWKeJexxgcq2NFJ/cGe84qIrjKzEK26UJjnLBLfNTdSSBA2kozNxot9skLYvLiHYjyuv10cxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=edD/tAPX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IbyCXReg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="edD/tAPX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IbyCXReg" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66TF31jj2357585 for ; Wed, 29 Jul 2026 15:57:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=4y99CIHhO7Z Ma20JkU9vG7q5Jf/ock0IskJ460LHt8I=; b=edD/tAPXdh3PRCzl2ZeF8A5Au0W C7hMgP09AgYNb0zhEwVFeMEcJnQ4NFBF4gW7hcexatTK8vTQdczGEObq5UOpuyK6 Qd60texAmuRbhNoyyZ4bOpspf59jalVunlzJHibw4AZG5UHvrC2BqUq08SjUOzDt HRQsrXI3JtzntdUE27qTWKU59xfygrF1kAmmTsRCDPG0QattencMgCAGUpmrwTye sKSae6cptA6caE0OyDNVoVVA+eLIVgV5wmekTniuDpWu/DvrrIZRPw4v33g3q3Wn 4oNyRFHNWN26PWsObj/1AEL0F4kZPZMrPRv517JG69WuKxEwofqzYOX/Tpg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fqhe99560-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2026 15:57:16 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cd01a14e81so15327725ad.1 for ; Wed, 29 Jul 2026 08:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785340636; x=1785945436; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4y99CIHhO7ZMa20JkU9vG7q5Jf/ock0IskJ460LHt8I=; b=IbyCXReg99mKUQYPBplqSok7pYjz6QFTT8kUPSpu6z2NunNQMhQ6BQ/N3PlAJ8Q7pG 6YhTj5C0u7XVMnvv02t3tZXd88exXdsk1Uk9x7LRyV5wIYGOsh8eTOHsuR1elcqOjDwa Zc1svznOscBftxnbFgm1jey2KKywz9Xmqt7OUb4gz+LQYOSoxENyKLg7gKEK9mU1OQ71 g0p5Ve9qb7qeoQqCSSx52mmQrWx+ujyNKEJrnmNCRxI8GcQ5+OPZCQwZVUJqG9z6vtL8 bntNqus8Mr0K7XV8xBO6AXgx0H9xpvwlxPqW2EpRcSKmlWzpQzvGuCISnNVkk3qPAh66 bswQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785340636; x=1785945436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4y99CIHhO7ZMa20JkU9vG7q5Jf/ock0IskJ460LHt8I=; b=mUAob2cCxvSQujPae+r+O6vQoztnSuFgX5bcqhW7/93Fe5DOHezxzJusS9JZnzKavD zluZDPxHG7bdgB1zo868AogIbT/IJIO1VNuOGLA3WKpPeGdYsiQ4PExDbFL5y2d6aO64 4wsvVhh4kwSevwYjKIGUylADx9ZlCZ5CW0Ti2xdAeediVX0oyP1W7x4b+GKCTZqly3wI +3DlyXNnSEewrdC/Jzb82P2rWV9ZSPGcge0XgHOepiYfTydE/2lof9u6tslqhM9O51PL B2pUMgkf+AMaIg62i/bMG22sVxW0u9QcdVxYL+eX67ItGZKhGyuRQooFGr7ufXWaUATl rEFQ== X-Forwarded-Encrypted: i=1; AHgh+RrMOXKRhO51Vso9/uPg5w2KrQ5kbRtKgjZ0qkQH9X7GK5ioDgZROikHmt1rS4/e+jvRTGtjr/zxinzVPGc=@vger.kernel.org X-Gm-Message-State: AOJu0YzQMr9nrXAt/Qre4VimUYoKPezSMTnHo5rNrPflLir6Xsl0Zklb dl8W2old6eRx0b2jf38x3QZuMwzCjq4t4hUuM0nbfai4kEDrnExw+b86kBR6Ss1rO1bNwZThYzM IsRihBiaSgXagJhK7iIx7NKcb3CUyd7tG/olRlYHTcnvhS8Fxbk0ICEFQZpJ8l/z5MnI= X-Gm-Gg: AR+sD12tkMlOh58tL39BemmWuwIawqWQXKJkIWrAYiiHn8NZHaBfbkI/AEalWa2Zkf6 ZpkItCXRkofl7gqHzhdw1i2aJ32OhPfC6gC4UazEc7r99Sr995ug4pW0JkGrI+aSFJ6s/XIk62M qwqtudME+H0ReK54Eo3PaMx48tXuNf1gHkmYTybYB/pibyRisfWZQWkwBpI3UoZBCDkixy285gj khaLNTs4ZDxOcfleduAAew8ratwVGiRQucla5rIyl5FiJCYaNz63PO8UFcb3Le65SE8oAfQ0Rpz YAZCvquZWNQ6J5/PyY/PB6qjistl3QdCxsrvtznSsQ6OaqktsIXnKjWrTrvwRLTtvVm9XBjHz9n /iExo3AykTbXlxHBVPJ2OLH7ZXXS5SR62Su9RdrYTHwKK6S8= X-Received: by 2002:a17:903:38c3:b0:2cf:b330:e0e8 with SMTP id d9443c01a7336-2d015affaf4mr86146455ad.10.1785340636240; Wed, 29 Jul 2026 08:57:16 -0700 (PDT) X-Received: by 2002:a17:903:38c3:b0:2cf:b330:e0e8 with SMTP id d9443c01a7336-2d015affaf4mr86146245ad.10.1785340635839; Wed, 29 Jul 2026 08:57:15 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022a15303sm13735525ad.3.2026.07.29.08.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 08:57:15 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Akhil P Oommen , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v7 15/17] drm/msm: Don't fallback to shared VM for VM_BIND Date: Wed, 29 Jul 2026 08:55:52 -0700 Message-ID: <20260729155609.20190-16-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260729155609.20190-1-robin.clark@oss.qualcomm.com> References: <20260729155609.20190-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI5MDEyNyBTYWx0ZWRfX6Qo1I8Puf4Sv JQCKE2voUoWz99Uem1WxWtzS4I0FE7aKkoOX9HR/IjBx8Zf71H4vQcmiGHCvVrzUeJNMFejk0p/ uOiAJwsu9/pW3b9YQunQqiN/pARLibXRQKYPACD0hnnlD8w9lGJNDqNH5RkqsmBwr6eIldOd56W DvqqPwbnAxXgg4+hU57dXi6Y7oP6f3kSSE6eQbYy+Tt1COgxDBSOqFfkpiOS06MIdZAba+11dzZ FHvI20t2gXxLA+9wqhIvLpNsu2PY5RkgbTBhc5TifWWeV6HB356OkqeF9qacEowQBcEWunf4sg5 OCZHKDJzHre6Fy79dYbBDJyV0yEY+H4NL/7YpFt/ZVNOrZka8yAJdkXgkaHVfzZQf+oz48Jqzw5 QbSE1GpiBy7w21kzwP9JpN2r3R1+LdlbSVnW3FfG8hY9FFE8Xt8thzBvmGjqZ2Wn7WBJnXDca39 /xsVQoy55BEOPbjEPrQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI5MDEyNyBTYWx0ZWRfXya03/ZJUG9Ny 2Vxo0yV530uCKZOd6GRTT3vCVLbcLYO4p7iIhY46BF9tQMWhqraPM4a6Qx4FtGKO3yXaJ2jQoGl N1qg10XI7ll+MSo+yfmoHnuXRT06fvo= X-Proofpoint-ORIG-GUID: ORRtEKWiRQedCHiJjB_AEltRzbH0P_i5 X-Proofpoint-GUID: ORRtEKWiRQedCHiJjB_AEltRzbH0P_i5 X-Authority-Analysis: v=2.4 cv=EsriaycA c=1 sm=1 tr=0 ts=6a6a22dc cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=isCY8TonHXl0-fnU9HAA:9 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_06,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 malwarescore=0 adultscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607290127 If the user wants a userspace managed VM (EN_VM_BIND) don't silently fall back to shared VM. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 3 ++- drivers/gpu/drm/msm/msm_gpu.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 52ff72d8e17a..73d99bde26f1 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -234,7 +234,8 @@ struct drm_gpuvm *msm_context_vm(struct drm_device *dev, struct msm_context *ctx if (!ctx->vm) { vm = msm_gpu_create_private_vm( priv->gpu, current, !ctx->userspace_managed_vm); - smp_store_release(&ctx->vm, vm); + if (!IS_ERR_OR_NULL(vm)) + smp_store_release(&ctx->vm, vm); } return ctx->vm; diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 18ed00e5f143..a1c4adcac128 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -875,7 +875,7 @@ msm_gpu_create_private_vm(struct msm_gpu *gpu, struct task_struct *task, to_msm_vm(vm)->pid = get_pid(task_pid(task)); } - if (IS_ERR_OR_NULL(vm)) + if (IS_ERR_OR_NULL(vm) && kernel_managed) vm = drm_gpuvm_get(gpu->vm); return vm; -- 2.55.0