From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEE7F4119E2 for ; Wed, 29 Jul 2026 15:56:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785340620; cv=none; b=kNO2bLPGwoDYtsGhaTfzy4rzV0jng+SkErX9fbJwhgWtdoVz1yEI6oXxQP+cMF9mM0u/GewoSktTN8xqMrZgAAY7EbRKyazPRpjAcVJ1RRtwpUuhzVEu+myp22AH3Jq5YPTxSFFC5ijXWavsgz3Olqmir9girRyAMCTz+Ylm9Mg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785340620; c=relaxed/simple; bh=wZufhlf2OrTXiXq8s7psP10WRX750jNvVBTi3KYm6Ro=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BMNz9/jvVd5ln4YZ/l6MYF6GLx83E8dGd5Ie1ewEW9LUFFBcdjoh6FJM2umuC7uPBe+1eWTOZjr7xuavO2XyLRN2t5eqj6ngwMBHl4Jv7HVA+XN53qWtzmku5cyxIvE+ZDzO0o6rMbBZQbLmmy8r2IRwj1LAI6xm63PbSWhTe5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DzNILbgf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=B2ZMG9fP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DzNILbgf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="B2ZMG9fP" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66TF2N5s3341135 for ; Wed, 29 Jul 2026 15:56:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Ss8T08lcQRu h4LT8qU7cdiXED4Y+cvXcR0q697Hi17o=; b=DzNILbgfKW78+tLPUtiCbtGflhN Tz/XvVk97izyIUHbklt0XAt9d+WcriUW4s5GVya3/NQ4KhV0EqpoVoiThe1i3Jmx E7psVcT9EJpZ+svd/U6ROffu3yiNWFxzU/JFlcLhVPVeBniU4Wjbkeygp0mzFW5z wv9CWV7UN8CxfQHvEAYRZDrpaZZ5LzzUGtomS9HNQzP8PBqZVlXO0bdbRcofMjCc JLmiCZbjODMCLxClSGfqLp1HcNWGyb3QCeZiIJea5+esUz4c47bRDu/wYnu/3FyH Kf5oylTLw8ipIKYixhIRlCRlRw7sbpDju155k4y4bOyag/DXopg6Zk0+IAw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fqh3ms6r9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2026 15:56:58 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cee894b3d8so20180465ad.2 for ; Wed, 29 Jul 2026 08:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785340618; x=1785945418; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ss8T08lcQRuh4LT8qU7cdiXED4Y+cvXcR0q697Hi17o=; b=B2ZMG9fPp9EzjGlQZIZ73M25XEm3Cwc01ZzQouiMcOjvHl8sX9qy7vgF9hIODJxPud vwiDS8GdYTK4y3OxrEvBnsCXUbU4sWhMIW0Icqf6fyujrSFeuqvwtRbHtfTdrgYGprl8 oOfBNqv1aWHAkKK/cJAGNbv+NL4t8UGI8EsERMBy0ge2ESvQjBiQy6OBxTBKae3wkV35 aqooEXQUdXKCBzIPmUF04+0ZSPNgmC04nTy1OA9f+EBiIBiLg2Fl5OEX+2axy414R7N6 PD0ScZ3ZV013BUv5qIR2Th8qehLIApH6dRG/DVHfm5DUa8J2AfVgX+g+b2hDW1UFDokA SKAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785340618; x=1785945418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Ss8T08lcQRuh4LT8qU7cdiXED4Y+cvXcR0q697Hi17o=; b=oHqwbbd3IQpQ2uSjRG6CWFDsDQAI5RMh/s2KVLu3/msDhs8TOCuFKNxt2WisX99Bvb b1MYgo2P8+6xKhw1ORBi1FL6In3dOQG5d9g+5nUiiop+EaQGaVe23g+5lFVmZGfl9aFG THz99byH9/Z5dn4NLyjmuubR9Jc0dRx+gYMB2xzTexV1pDAUa8uq4jruswX3yhLS2bmh SuefXUEeeQPBUmRiFzUZ4GS2dWAoZH1O9hYdns4gFe2kejs+i5Y4BmKxLh5HhegBaBw5 dy+bHIquc6Xzm1+iLuWa/vS1x24Sb93pZ2saftcbbcKRVF/dXz8RQX6/oFcMYyQESp/G i10g== X-Forwarded-Encrypted: i=1; AHgh+RoZZ7LoWoew81XcENGU0ge/CuwbKo1jyFFwXtEdS+mBZV46VLeL9RQZx0HxnJoH8Eon8pITpfRgQ3VG1D4=@vger.kernel.org X-Gm-Message-State: AOJu0YxS2f7eBov9i0VkiJXyHZlvL4onDdAUjWxhTYFFzRokfRBUz4pn odw27dT7mS416Kx6xSwf7nFgNC5Z6kXisvENZL4hgl58SoehYQnHFxddl4v0XOVLUJ4v45o/F3g oc7wE8jvPJIqVWZ/VZxF1lbkRiFSV3+wp5OQF6HOVgMSVKvAqoNQEPllefgIDvxKNHNw= X-Gm-Gg: AR+sD1215TiTfiZov5COGdIDvUtyS3jqywpbkc3Sz8PHfsc4HF+W0nGTW3ye7owljlz qCAsi9wGdaC6JUrGLqJzpnhQieU5/uWomAlyipizHLsMowGtky7JqU6CmNhwlVq2lQAygI7f2Bn YrkhaUHwpcSNvJ6JvS58Djr5Rfu0usXJ2+jzAJUbrurxz5Bf2gyAieiVY4HKfgfAjn6WEl9lDu3 0JRwNDDNPGV68n6lYL+RyyKKLLu9Fc8Ic9dpIEdR+eFTcvpB+7smt6/F8KJMhmhF+avhfGYI+VY E/Awf/rq7UY6vHRVWYbA96v5DG4I4uAkuP3mW4EJB5gJDJSbgcqUQ72ds3iCLGn4U+ydaNLtssW 4gE9bI/tr9jrxzMuZOTyOlUyIddsZ0dda1QgX3U6c/qEbx60= X-Received: by 2002:a17:903:1a84:b0:2c2:be43:39bc with SMTP id d9443c01a7336-2d015ee21e8mr88173345ad.22.1785340618392; Wed, 29 Jul 2026 08:56:58 -0700 (PDT) X-Received: by 2002:a17:903:1a84:b0:2c2:be43:39bc with SMTP id d9443c01a7336-2d015ee21e8mr88173115ad.22.1785340617955; Wed, 29 Jul 2026 08:56:57 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022bf99edsm13505125ad.67.2026.07.29.08.56.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 08:56:57 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v7 04/17] drm/msm: Synchronize set_sysprof on ctxlock Date: Wed, 29 Jul 2026 08:55:41 -0700 Message-ID: <20260729155609.20190-5-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260729155609.20190-1-robin.clark@oss.qualcomm.com> References: <20260729155609.20190-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI5MDEyNyBTYWx0ZWRfX9w8mk8sJ5Wwu 5rihE20/Odde8O1j0itnXg0FKc0SB3U/qOuA7rl6a/As4aeLmC6QBo7LeNIcm1XzvabPN3r61bM rMsIo7tcgi8LyGesfy1BG0HDnPevlFHfWAjMZ6jWqxlMzU8x3Lue1ho68NsGx3YjPBUmmhjchu/ 39Bf0kom9icuDk+cvh8y+RYQ/tcLQ9EFOp5OcuX5SBM9HJiFtbotniAkl7eUD93Thr/CcgJffzf p6wKFTLWTQa5zs6Pio8i3L+Ysa0wYKqkidsW5WSwVs2oht/vKsVgosdmzM+CStmZqphk0mwTiuU j2AbHNfHDiXQY0+Tg9pn32QZ2UIBPXq7r2qYM2WG4fCay967s8D+7l/W/vYReH1P3jqsNtj0+Tg jIp58IF0dXMRdR7Q1TeYm1lhhCntrzUdZ/XdAGH2Tvo/xmWq1nOiBoN5HXrW4mAdoibKBggypWn wITIyblGzeQUghXbRfQ== X-Authority-Analysis: v=2.4 cv=F49nsKhN c=1 sm=1 tr=0 ts=6a6a22ca cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=A-0ye_aN_Dr-yZQka4YA:9 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: 7sbU2tCYgounZkTFbASlQ3E63StOL6V2 X-Proofpoint-ORIG-GUID: 7sbU2tCYgounZkTFbASlQ3E63StOL6V2 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI5MDEyNyBTYWx0ZWRfX/avItl/JZolP 28YHsNE3LOl0nbwYDve7gouuMvgB6kbaO150T5VUikRqfXmzNJd9UUKGP2DtG39BUK/CiDwz49y 6Dx+vFLFU5tVgAANGYPZZsCS93f5P+A= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_06,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607290127 A user that was perfmon_capable() could try to race setting SYSPROF param on multiple threads to trigger a reference leak. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_submitqueue.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_submitqueue.c b/drivers/gpu/drm/msm/msm_submitqueue.c index 8b5980d5a6a7..233c4f35ab12 100644 --- a/drivers/gpu/drm/msm/msm_submitqueue.c +++ b/drivers/gpu/drm/msm/msm_submitqueue.c @@ -9,6 +9,8 @@ int msm_context_set_sysprof(struct msm_context *ctx, struct msm_gpu *gpu, int sysprof) { + guard(rwsem_write)(&ctx->ctxlock); + /* * Since pm_runtime and sysprof_active are both refcounts, we * call apply the new value first, and then unwind the previous -- 2.55.0