All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Claudio Imbrenda" <imbrenda@linux.ibm.com>
Cc: "Vasily Gorbik" <gor@linux.ibm.com>,
	kvm@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
	linux-s390@vger.kernel.org,
	"Alexander Gordeev" <agordeev@linux.ibm.com>
Subject: Re: [PATCH v5 06/13] KVM: s390: Fix race in __do_essa()
Date: Wed, 29 Jul 2026 17:22:22 +0000	[thread overview]
Message-ID: <20260729172223.4339F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260729152938.782383-7-imbrenda@linux.ibm.com>

> An unlikely race between __do_essa() and kvm_s390_vm_start_migration(),
> kvm_s390_vm_stop_migration(), or dat_get_cmma() was possible.
> 
> Fix by locking kvm->slots_arch_lock. Since this is not a hot path, the
> overhead of an additional mutex is negligible.
> 
> Fixes: e38c884df921 ("KVM: s390: Switch to new gmap")
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260729152938.782383-1-imbrenda@linux.ibm.com?part=6


  reply	other threads:[~2026-07-29 17:22 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 15:29 [PATCH v5 00/13] KVM: s390: Misc fixes Claudio Imbrenda
2026-07-29 15:29 ` [PATCH v5 01/13] KVM: s390: Fix unlikely NULL gmap dereference Claudio Imbrenda
2026-07-29 15:43   ` sashiko-bot
2026-07-29 15:29 ` [PATCH v5 02/13] KVM: s390: Fix kvm_s390_vcpu_unsetup_cmma() Claudio Imbrenda
2026-07-29 16:06   ` sashiko-bot
2026-07-29 15:29 ` [PATCH v5 03/13] KVM: s390: Fix overclearing ESCA in case of error Claudio Imbrenda
2026-07-29 16:35   ` sashiko-bot
2026-07-29 15:29 ` [PATCH v5 04/13] KVM: s390: ucontrol: Fix sca_clear_ext_call() Claudio Imbrenda
2026-07-29 16:55   ` sashiko-bot
2026-07-29 15:29 ` [PATCH v5 05/13] KVM: s390: Fix leaking of PGM_ADDRESSING to userspace Claudio Imbrenda
2026-07-29 17:08   ` sashiko-bot
2026-07-29 15:29 ` [PATCH v5 06/13] KVM: s390: Fix race in __do_essa() Claudio Imbrenda
2026-07-29 17:22   ` sashiko-bot [this message]
2026-07-29 15:29 ` [PATCH v5 07/13] KVM: s390: cmma: Fix dirty tracking when removing memslot Claudio Imbrenda
2026-07-29 17:38   ` sashiko-bot
2026-07-29 15:29 ` [PATCH v5 08/13] KVM: s390: ucontrol: Add missing locking around gmap_remove_child() Claudio Imbrenda
2026-07-29 17:50   ` sashiko-bot
2026-07-29 15:29 ` [PATCH v5 09/13] KVM: s390: Free the mmu cache when kvm_arch_vcpu_create() fails Claudio Imbrenda
2026-07-29 18:02   ` sashiko-bot
2026-07-29 15:29 ` [PATCH v5 10/13] KVM: s390: Return -EINTR if a signal was pending while faulting-in Claudio Imbrenda
2026-07-29 18:12   ` sashiko-bot
2026-07-29 15:29 ` [PATCH v5 11/13] KVM: s390: Fix ordering when adding to SCA Claudio Imbrenda
2026-07-29 18:33   ` sashiko-bot
2026-07-29 15:29 ` [PATCH v5 12/13] KVM: s390: Fix cleanup in kvm_s390_pv_create_cpu() Claudio Imbrenda
2026-07-29 18:39   ` sashiko-bot
2026-07-29 15:29 ` [PATCH v5 13/13] KVM: s390: Fix kvm_arch_commit_memory_region() when low on memory Claudio Imbrenda
2026-07-29 18:53   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260729172223.4339F1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.