All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>,
	Youssef Samir <youssef.abdulrahman@oss.qualcomm.com>
Subject: Re: [PATCH 6.1.y] net: qrtr: ns: Raise node count limit to 512
Date: Wed, 29 Jul 2026 22:40:10 -0400	[thread overview]
Message-ID: <20260729223316.stable-0014@kernel.org> (raw)
In-Reply-To: <20260729150958.3889964-1-youssef.abdulrahman@oss.qualcomm.com>

> -/* Max lookup limit is chosen based on the current platform requirements. If the
> - * requirement changes in the future, this value can be increased.
> - */
> -#define QRTR_NS_MAX_LOOKUPS 64
> -

I've queued 6.18, 6.12 and 6.6, but I'm holding 6.1, 5.15 and 5.10 and
would like one v2 covering those three.

Two things:

1) The hunk above is in the 6.1 and 5.10 patches only.  It removes a
   duplicated #define that our own backports of 27d5e84e810b ("net: qrtr:
   ns: Limit the total number of nodes") introduced, which upstream
   ff194cffd586 ("net: qrtr: ns: Raise node count limit to 512") does not
   touch.  The 5.15 patch does not have it, even though 6.1 and 5.15
   currently have a byte-identical net/qrtr/ns.c.  Taking them as-is would
   leave the three old trees gratuitously different from each other.

2) More importantly, none of 6.1, 5.15 and 5.10 ever decrement node_count.
   The backports of 27d5e84e810b dropped the node_count-- hunk with the
   note that ctrl_cmd_bye() has no delete_node, but all three trees do have
   the delete_node: label with the xa_erase() + kfree().  So the counter is
   monotonic there and raising the cap from 64 to 512 only defers the wedge
   rather than fixing it.

Could you send a single v2 for 6.1, 5.15 and 5.10 that matches upstream
exactly and adds the missing node_count-- in ctrl_cmd_bye()?

-- 
Thanks,
Sasha

  reply	other threads:[~2026-07-30  2:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 13:53 FAILED: patch "[PATCH] net: qrtr: ns: Raise node count limit to 512" failed to apply to 6.1-stable tree gregkh
2026-07-29 15:09 ` [PATCH 6.1.y] net: qrtr: ns: Raise node count limit to 512 Youssef Samir
2026-07-30  2:40   ` Sasha Levin [this message]
2026-07-30 10:53     ` Youssef Samir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260729223316.stable-0014@kernel.org \
    --to=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=youssef.abdulrahman@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.