Re: [PATCH 1/2] media: dt-bindings: imx908: Add Sony IMX908 sensor bindings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] The `endpoint` node incorrectly uses `additionalProperties: false` alongside a `$ref`, causing `dt_binding_check` failure.
- [Low] The schema omits a reference to `video-interface-devices.yaml`, forbidding standard camera properties.
- [Low] The MAINTAINERS entry references a non-existent driver file.
--

--- Patch [1]: [PATCH 1/2] media: dt-bindings: imx908: Add Sony IMX908 sensor bindings ---
commit b917e4497ee65daa99bbbfe30747c3a19b86a295
Author: Lachlan Michael <lachlan.michael@sony.com>

media: dt-bindings: imx908: Add Sony IMX908 sensor bindings

The Sony IMX908 is an 8.39 megapixel (3856x2176) CMOS image sensor
with a MIPI CSI-2 output interface.
Add device tree bindings for the sensor.

> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml
> new file mode 100644
> index 0000000000000..6ab382d1cf34c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml
[ ... ]
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        additionalProperties: false

[Severity: Low]
Since this endpoint node uses a $ref to video-interfaces.yaml, will using
additionalProperties: false here reject standard inherited properties?

For example, the dt_binding_check might fail because remote-endpoint is used
in the example below but is not locally listed in this properties block.
Should this be unevaluatedProperties: false instead?

> +
> +        properties:
> +          data-lanes:
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - dvdd-supply
> +  - ovdd-supply
> +  - avdd-supply
> +  - port
> +
> +additionalProperties: false

[Severity: Low]
Does this schema need a reference to video-interface-devices.yaml?

Without inheriting from /schemas/media/video-interface-devices.yaml# in an
allOf block, does this additionalProperties: false prevent users from
specifying standard camera sensor properties like orientation or rotation?

> +
> +examples:
> +  - |
[ ... ]
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2f9472c1a0907..5a0265e0676a2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -25266,6 +25266,13 @@ T:	git git://linuxtv.org/media.git
>  F:	Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
>  F:	drivers/media/i2c/imx415.c
>  
> +SONY IMX908 SENSOR DRIVER
> +M:	Lachlan Michael <lachlan.michael@sony.com>
> +L:	linux-media@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml
> +F:	drivers/media/i2c/imx908.c

[Severity: Low]
Is it intended to reference drivers/media/i2c/imx908.c here?

This file does not appear to be introduced in this patch, which might
trigger warnings from maintenance scripts about a missing file.

> +
>  SONY MEMORYSTICK SUBSYSTEM
>  M:	Maxim Levitsky <maximlevitsky@gmail.com>
>  M:	Alex Dubov <oakad@yahoo.com>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730021525.166811-1-lachlan.michael@sony.com?part=1