From: sashiko-bot@kernel.org
To: "Hrushiraj Gandhi" <hrushirajg23@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Vicharak Vaaman board
Date: Thu, 30 Jul 2026 05:04:56 +0000 [thread overview]
Message-ID: <20260730050457.3CC471F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260730045947.388660-2-hrushirajg23@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit introduces a new compatible string 'vicharak,vaaman' but fails to document the 'vicharak' vendor prefix in vendor-prefixes.yaml, violating device tree binding requirements.
--
--- Patch [1]: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Vicharak Vaaman board ---
commit 002a19e13723e85ef3d5de1114afcf5868a4c28e
Author: Hrushiraj Gandhi <hrushirajg23@gmail.com>
dt-bindings: arm: rockchip: Add Vicharak Vaaman board
This commit documents the compatible string for the Vicharak Vaaman, an
RK3399-based single-board computer.
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1a9dde18626d0..7cfd3687768cf 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -1306,6 +1306,11 @@ properties:
> - const: turing,rk1
> - const: rockchip,rk3588
>
> + - description: Vicharak Vaaman
> + items:
> + - const: vicharak,vaaman
[Severity: Low]
Does this new compatible string require an update to vendor-prefixes.yaml?
Since the "vicharak" vendor prefix is newly introduced here, running
dt_binding_check will likely report a schema validation warning because
"vicharak" is not documented in
Documentation/devicetree/bindings/vendor-prefixes.yaml.
Should it be added there as well to ensure schema validation passes?
> + - const: rockchip,rk3399
> +
> - description: WolfVision PF5 mainboard
> items:
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260730045947.388660-1-hrushirajg23@gmail.com?part=1
next prev parent reply other threads:[~2026-07-30 5:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 4:59 [PATCH v3 0/2] Add support for Vicharak Vaaman board Hrushiraj Gandhi
2026-07-30 4:59 ` Hrushiraj Gandhi
2026-07-30 4:59 ` [PATCH v3 1/2] dt-bindings: arm: rockchip: Add " Hrushiraj Gandhi
2026-07-30 4:59 ` Hrushiraj Gandhi
2026-07-30 5:04 ` sashiko-bot [this message]
2026-07-30 4:59 ` [PATCH v3 2/2] arm64: dts: " Hrushiraj Gandhi
2026-07-30 4:59 ` Hrushiraj Gandhi
2026-07-30 5:14 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730050457.3CC471F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hrushirajg23@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.