From: Michal Pecio <michal.pecio@gmail.com>
To: Jie Deng <dengjie03@kylinos.cn>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>,
mathias.nyman@intel.com, linux-usb@vger.kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: xhci: Restore MSI/MSI-X reinitialization on resume for RESET_ON_RESUME hosts
Date: Thu, 30 Jul 2026 06:48:17 +0200 [thread overview]
Message-ID: <20260730064817.79e3d1af.michal.pecio@gmail.com> (raw)
In-Reply-To: <e0c37a75-0569-45ac-acd0-534a24b6e3dd@kylinos.cn>
To avoid putting PCI-specific code in xhci.c, I wonder if it would
still work if the disable/enable cycle is done by xhci_pci_resume()
before calling xhci_resume()?
On Thu, 30 Jul 2026 10:24:05 +0800, Jie Deng wrote:
> Runtime PM is not practically triggerable on this desktop setup,
> but code inspection shows runtime resume also goes through
> xhci_resume() with reset_registers=true for XHCI_RESET_ON_RESUME
> hosts.
Resetting at runtime resume sounds like an odd thing to do, maybe
runtime suspend should be rejected then. But this is unrelated...
> We conducted 1000 tests on Hibernate and did not observe the problem
> recurring.
> When it is suspended, both xHC D3hot and D3clod can reproduce the
> problem.
> Additionally, I was able to reproduce the problem using the Renesas
> uPD720201 controller as well.
I wonder if it's an issue with those chips or a general PCIe or IRQ
resume bug in some particular host system? It looks like nobody else
complained about this old patch for three years.
I don't have ASM3042, but I do have ASM1042, ASM1142, ASM3142 and
also uPD720200, uPD720201 (rarely available for testing), uPD720202.
To be honest, I have never seen lost IRQs after resume here.
How often is this supposed to happen, how exactly is it reproduced?
Regards,
Michal
next prev parent reply other threads:[~2026-07-30 4:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 9:02 [PATCH] usb: xhci: Restore MSI/MSI-X reinitialization on resume for RESET_ON_RESUME hosts Jie Deng
2026-07-27 14:19 ` Mathias Nyman
2026-07-30 2:24 ` Jie Deng
2026-07-30 4:48 ` Michal Pecio [this message]
2026-07-31 7:38 ` Jie Deng
2026-07-31 10:57 ` Michal Pecio
2026-08-03 9:14 ` Jie Deng
2026-08-03 9:17 ` Jie Deng
2026-08-04 1:00 ` Jie Deng
2026-08-08 11:41 ` kernel test robot
2026-08-08 12:16 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730064817.79e3d1af.michal.pecio@gmail.com \
--to=michal.pecio@gmail.com \
--cc=dengjie03@kylinos.cn \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.