Re: [PATCH v9 1/2] dt-bindings: media: add ITE IT6625/IT6626 HDMI bridge

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The schema permits `bus-type = <1>` (C-PHY) for the `ite,it6625` compatible, despite the hardware only supporting D-PHY.
--

--- Patch [1]: [PATCH v9 1/2] dt-bindings: media: add ITE IT6625/IT6626 HDMI bridge ---
commit f6d61ed9f4634ce06509b6b075bb232fb04aed05
Author: Hermes Wu <Hermes.wu@ite.com.tw>

dt-bindings: media: add ITE IT6625/IT6626 HDMI bridge

This commit adds the device tree binding schema for the ITE IT6625 and IT6626 
HDMI to MIPI CSI-2 bridges. It documents the supported properties, including
the required I2C configuration, power supplies, and port endpoints for CSI-2
outputs and HDMI input.

> diff --git a/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml b/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml
> new file mode 100644
> index 0000000000000..756fe655f534f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml

[ ... ]

> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: ite,it6626

[Severity: Low]
Does omitting an if block for ite,it6625 here permit invalid device trees to
pass validation?

Without a constraint for ite,it6625, it appears a configuration specifying 
bus-type = <1> (C-PHY) would silently pass schema validation, despite the
hardware only supporting D-PHY.

> +    then:
> +      properties:
> +        ports:
> +          properties:
> +            port@0:
> +              properties:
> +                endpoint:
> +                  required:
> +                    - bus-type

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730-upstream-it6625-it6626-v9-0-e7725db2b92f@ite.com.tw?part=1