From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: hch@lst.de, cem@kernel.org, stable@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/6] xfs: adjust datadev sector count to reflect internal rt volumes
Date: Thu, 30 Jul 2026 10:22:04 +0200 [thread overview]
Message-ID: <20260730082204.GE10558@lst.de> (raw)
In-Reply-To: <178538912986.4070956.14205556423461124701.stgit@frogsfrogsfrogs>
On Wed, Jul 29, 2026 at 10:27:20PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> A media scan of a filesystem containing an internal rt volume produced
> an error in xfs_scrub phase 6 complaining about a truncated realtime
> device. The rt device wasn't truncated, but the media scan code thought
> we were trying to start a scan past the end of m_rtdev_targp. That in
> turn is an alias for m_ddev_targp, but in xfs_configure_buftarg we set
> nr_sectors to the size of the data section. Oops.
>
> On these filesystems, the internal rt section comes immediately after
> the data section. We need to set the sector count for the data device
> buftarg to the size of both sections. Without this, media scans don't
> work and media failure notifications from the kernel will be discarded
> silently.
>
> We also need to fix the superblock buffer recovery code to do the same.
This feels wrong. Nothing should acess the internal rtdev through
the data device buftarg.
Is this an LLM report bug, or did you actually run it using scrub? If
so can you help with the reproducer?
next prev parent reply other threads:[~2026-07-30 8:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 5:26 [PATCHSET] xfs: LLM-inspired bug fixes, part 5 Darrick J. Wong
2026-07-30 5:26 ` [PATCH 1/6] xfs: fix unit conversions in per_binval computation Darrick J. Wong
2026-07-30 8:18 ` Christoph Hellwig
2026-07-30 5:26 ` [PATCH 2/6] xfs: fix short ifork reaping computation in xreap_bmapi_binval Darrick J. Wong
2026-07-30 8:19 ` Christoph Hellwig
2026-07-30 5:26 ` [PATCH 3/6] xfs: fix name string recording in slowpath pptr tracepoints Darrick J. Wong
2026-07-30 8:19 ` Christoph Hellwig
2026-07-30 5:27 ` [PATCH 4/6] xfs: don't leak dqacct if rhashtable insertion fails Darrick J. Wong
2026-07-30 8:20 ` Christoph Hellwig
2026-07-30 5:27 ` [PATCH 5/6] xfs: adjust datadev sector count to reflect internal rt volumes Darrick J. Wong
2026-07-30 8:22 ` Christoph Hellwig [this message]
2026-07-30 5:27 ` [PATCH 6/6] xfs: fix the rtrmap and rtrefcount _maxlevels_ondisk functions Darrick J. Wong
2026-07-30 8:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730082204.GE10558@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.