From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC1A242B339 for ; Thu, 30 Jul 2026 12:27:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785414436; cv=none; b=NQdoYbuobVlPzffwcT7LCftwlxNkjXHzUEE3oAWoDYYFnhop8UcGj059bUpWkbqO8hn7PPZrmIVbkJ3dvwPd0BI/PYTSS0MCZz764N/LjFqhFww9uzDmPpAdv48cuwD1b3aZol4SG9CVBhjuDhKZyPGv9u8KgHz/XxWGGtMyY6U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785414436; c=relaxed/simple; bh=2AY3ANig1f9OglpG0yOGbYieMpkvUr8z3xG0jAvYXjs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gP42iQt/t0xYl6ciHhvX6TOS6uTH8R2p7aDiVxryEeTapIKPy+6R51CDcWZtvGQkF0kHTnLxpqeT/foQxb2aZef937FagYIgbDIY60sD+bTe7uHlC9OCDkIFAEChq1BJCIMLEDQFLbbEY3JCBIsXT8OA5CqruvO+HvKMcHraBCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N7A8v/4G; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N7A8v/4G" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-38e071ed6aeso1737540a91.0 for ; Thu, 30 Jul 2026 05:27:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785414435; x=1786019235; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=nY21TCjMLC68nQGz7B4rPYSEfj4hhFqBLreSGblBeOQ=; b=N7A8v/4GySHa3hXqfn1Vz8Szj9WLdwN7CCwE1bGiDupwBkUWmP1mPujIKemLu9rxNR U7OkbM+GuKHHR2D1KLfWHrZKFOaDTRlj/v+/Gk+vYXY+JntdE6BHwZgKHyAwGpk8SvKA KO6lHfu8QLeFWBMwKdNa+kHC3IXu2qgSR1CsniM59CsX0zJgsac6gfj88//SvgR3WNlY J4jqRuBWjqzPpDDNec/ulZtNtbnSTo4jHu70t8c2j8geFDV2d+SAmcPeixhDM/P7gLt7 b2NkzNKkZY/jQ1LglG1Hsz3/wJqq4VGhFXIzfl21/STyVUHkRfk5jg1Bd5P8k57pM4BP NEaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785414435; x=1786019235; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nY21TCjMLC68nQGz7B4rPYSEfj4hhFqBLreSGblBeOQ=; b=XjcPR5F0P19AWL3UeT8OB8K9SLkH7ca/iXDwvJ9L8OWoahHtHr1dkvWobrXYxZEf8t iN9aEKcl9vehJYoPTvwQ7WAG6pCbURreYq4HSzQ+LAc++Y/h71wJSBTLWWg620+cYjEy SH0Yo3tieTt+bdplgFq85Rw5X1b7OqaAVoWbjX+DQUx1/Zd0/mBW+DDQFA0WAPxETAFz if5dYtEH6rWVrJQ5OuaIXmYu2DM8UauRk7KZi77xwDl+7JdMsuJMXOxSy5k595pqGIKO my2rPyP9EvBxAerDCtUWWVlHWkHWT1qJ1JXR9AWp90cl4hDKWCr11Y1GevdJTixHmRPT d87g== X-Forwarded-Encrypted: i=1; AHgh+RoZV2tp4kABVWHDihWHn/mPNxVsqO8K5DJ/zUZf22/LWUpUrvqqU9iZpgOETP4PZ/ivWVl0XemO3sxjNsA=@vger.kernel.org X-Gm-Message-State: AOJu0YyDZjeuA9Z44AyBwLqnkqL55/baZ9exnrJx5FT3YQVAjX8YlMHV FoSDyfCAh66BG2bJanGhKpfiM7QAgx7AmxYQoyAhrAvrKEHbXPXerLQP X-Gm-Gg: AR+sD13sCpN+1TmmH/cX6hW02yvNzTwHaijMs4otOtcDfdM0w5it98NpTrMfQKnxXf9 ffQkxUrmcwfVbWEHu+5h2AbfX1sFE8TItkkBs7CeWp+FLJEeWhOwoxROngQ/8+zfRUvMLBP2o9/ SNc7HC7vVxQ6v+38CVFUHvC6SCJ9ul4oJebzEbcmUkXaUX1kSpjHsK5bRTWnl3tT2RqsRjbepHu 5/bcXDA7sQTgkB6ZkEduK6raoyYz4SDCec15fc6VeZLsVI4+M33uBTtPOvAXZ5DIn0tdJt+kMrU D3Vs2LL/cifpAn1trgc4abOH1YY1lpEutKN64sq9gg8lGkL1Be5DNHqxUC9g6IPTZLNfgDp72di nqaQoHrT4nVcOycSI8hDsiY0GQLcFAfBIiP8shGppuiz4VEE/HmV4vhiex8icsOqUiENk8skM/r qP0XEe044K4Fs4rHiN46MO6RqoVNHCAAWaVNR8MD9ILxlSQOECje6Ch3mTKKwKvY9ZNKjUEKz5V IobjCz7p56SrWQ1nEPVqQeg8rruFpnzsDUp4PmDRtbzuCY= X-Received: by 2002:a17:90b:4fc4:b0:38d:a150:ee04 with SMTP id 98e67ed59e1d1-38f9bee9096mr2142153a91.30.1785414434964; Thu, 30 Jul 2026 05:27:14 -0700 (PDT) Received: from junsungpark-QEMU-Virtual-Machine ([210.97.63.13]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f9b2844e5sm1021765a91.0.2026.07.30.05.27.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 05:27:14 -0700 (PDT) From: junsungpark774@gmail.com To: tzimmermann@suse.de Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Park Junsung Subject: [PATCH] drivers: drm: remove drm_simple_encoder_init then inline with drm_encoder_init Date: Thu, 30 Jul 2026 17:49:08 +0900 Message-ID: <20260730084908.109270-1-junsungpark774@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Park Junsung remove drm_simple_encoder_init which is noted as a unnecessary intermediate layer in the TODO list and inline it into drm_encoder_init. to achieve this, declare and define drm_encoder_funcs with the static keyword. has been verified by module compilation with no errors on modified area. Signed-off-by: Park Junsung --- drivers/gpu/drm/qxl/qxl_display.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index a026bd35ef48..52d9bb46ea95 100644 --- a/drivers/gpu/drm/qxl/qxl_display.c +++ b/drivers/gpu/drm/qxl/qxl_display.c @@ -44,6 +44,10 @@ #include "qxl_drv.h" #include "qxl_object.h" +static const struct drm_encoder_funcs drm_encoder_funcs_cleanup = { + .destroy = drm_encoder_cleanup, +}; + static bool qxl_head_enabled(struct qxl_head *head) { return head->width && head->height; @@ -1169,10 +1173,11 @@ static int qdev_output_init(struct drm_device *dev, int num_output) drm_connector_init(dev, &qxl_output->base, &qxl_connector_funcs, DRM_MODE_CONNECTOR_VIRTUAL); - ret = drm_simple_encoder_init(dev, &qxl_output->enc, - DRM_MODE_ENCODER_VIRTUAL); + ret = drm_encoder_init(dev, &qxl_output->enc, + &drm_encoder_funcs_cleanup, + DRM_MODE_ENCODER_VIRTUAL, NULL); if (ret) { - drm_err(dev, "drm_simple_encoder_init() failed, error %d\n", + drm_err(dev, "drm_encoder_init() failed, error %d\n", ret); goto err_drm_connector_cleanup; } -- 2.53.0