Re: [RFC PATCH 1/3] dt-bindings: soc: qcom: add xiaomi,taoyao-pmic-glink compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema change enforces an incorrect, truncated fallback chain that skips the intermediate SoC compatible string.
--

--- Patch [1]: [RFC PATCH 1/3] dt-bindings: soc: qcom: add xiaomi,taoyao-pmic-glink compatible ---
commit 52fb33657926ca90fb558df9e2cd09cb2c215e6e
Author: Stanislav Zaikin <zstaseg@gmail.com>

dt-bindings: soc: qcom: add xiaomi,taoyao-pmic-glink compatible

This commit adds the xiaomi,taoyao-pmic-glink compatible string for the
Xiaomi 12 Lite 5G. This allows its battery manager to be matched to a
device-specific variant in qcom_battmgr.

> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> index 16ad4f5698fc3..8ca057c4e3e61 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> @@ -41,6 +41,7 @@ properties:
>        - items:
>            - enum:
>                - qcom,sm7325-pmic-glink
> +              - xiaomi,taoyao-pmic-glink
>            - const: qcom,qcm6490-pmic-glink
>            - const: qcom,pmic-glink

[Severity: Medium]
Does this schema change enforce an incorrect, truncated fallback chain that
skips the intermediate SoC compatible string?

By grouping the board-specific string (xiaomi,taoyao-pmic-glink) in an enum
alongside the SoC string (qcom,sm7325-pmic-glink), the schema restricts the
compatible list to exactly 3 items. This forces device tree authors to omit
the SoC-level fallback (qcom,sm7325-pmic-glink) in order to pass dtbs_check.

Should this instead be defined with a 4-item list so the board compatible
can properly fall back to the sm7325 SoC compatible before falling back to
the generic qcm6490 and pmic-glink ones?

>        - items:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730093502.689505-1-zstaseg@gmail.com?part=1