From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 478213C73F7 for ; Thu, 30 Jul 2026 09:29:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785403766; cv=none; b=kfhxQB3I55yYEh+Tyvu8we/KjwThZasOpb7cFPtH+tQQ5Qb3McwmNwGYGbi/X7MYe7Bet60KILfhkKs0AkmjbddLAUWZS8qgHqUrhq4vIIG39GxLV/VHL0dovtfbVvp/rkiz/ToVJ94pI8Z/ax1m5J4yoYRJ6+qPg6JZ6KsVz7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785403766; c=relaxed/simple; bh=zTloMMk8FYsPRRQewY7w42aCzfXCvtTujzT+65i546w=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=e8lToHKYWtke6UrU+Ir2nPgx4wtQG1QC6aw3e27SnpglKHGYNSYCHZGsx+wGBqRO8CTcs37LsaaC/zsO8fhhxYMKIgI7jVXwpCL1YrK/st8haGzg4NStcsOIqSm5kq/GdpAm6y8laIByEtqt8z0gwNBgnGYR3REsW4fOGYyOdg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=lHRpTryO; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="lHRpTryO" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 1CEEE1A1311; Thu, 30 Jul 2026 09:29:14 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id E530A602B8; Thu, 30 Jul 2026 09:29:13 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 074B311C15912; Thu, 30 Jul 2026 11:29:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1785403749; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=BtGBUghZ3NVIAEOKhEMfE4OWjyrtG5sqoDoPPz9NCKI=; b=lHRpTryOpV8JKVIpccrVl2dKXfsUls7y1AdqNdu+lbrNBdtrNAs6PeL/OlQ7OxIRNx/Dwq hSoYbDY+ObMspxRJIPdg8y+9840xOr+OvewITwTLqWvJiKVwz/+Rz1NEwWP73Z4KURSzox b96T/fWI9sr1mMgS3MSzmKgVti/5PCxnIx0VFJnocoufsgrdaz7JheIudlYyWGmAkwGPLQ lAFLyag3CjNETsoxAIiqN3q4P9aW38M37y8u1eMIoEUu/IZ5vAc9dJek1a3w0ujpookQaW PGFESeP4ZrCZLJ3/Q0kfpee/sk2QAcVYqbaTlIq9/TFvZRx5FyzfGFEC7H5qHA== Date: Thu, 30 Jul 2026 11:29:05 +0200 From: Herve Codina To: "Christophe Leroy (CS GROUP)" Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Paul Louvel Subject: Re: [PATCH] soc: fsl: qe: properly scan GPIO nodes at startup Message-ID: <20260730112905.23a4b2f2@bootlin.com> In-Reply-To: <0e5628ae-886a-4a8e-8a35-6402737ad65a@kernel.org> References: <04dc047f8958a78a920f0a88ca3bd8bf70c56187.1785333986.git.chleroy@kernel.org> <20260729172156.4371a8bc@bootlin.com> <0e5628ae-886a-4a8e-8a35-6402737ad65a@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Christophe, On Thu, 30 Jul 2026 10:11:29 +0200 "Christophe Leroy (CS GROUP)" wrote: > Hi Hervé, > > Le 29/07/2026 à 17:21, Herve Codina a écrit : > > Hi Christophe, > > > > On Wed, 29 Jul 2026 16:10:36 +0200 > > "Christophe Leroy (CS GROUP)" wrote: > > > >> Before commit 156460811def ("soc: fsl: qe: Change GPIO driver to a > >> proper platform driver") qe_add_gpiochips() was walking the device > >> tree to find all nodes with compatible "fsl,mpc8323-qe-pario-bank". > >> > >> After that commit the discovery is handled by the platform core, > >> therefore it is necessary to call of_platform_default_populate() on > >> the par_io node. > >> > >> Fixes: 156460811def ("soc: fsl: qe: Change GPIO driver to a proper platform driver") > >> Signed-off-by: Christophe Leroy (CS GROUP) > >> --- > >> drivers/soc/fsl/qe/qe_io.c | 15 +++++++++++++++ > >> 1 file changed, 15 insertions(+) > >> > >> diff --git a/drivers/soc/fsl/qe/qe_io.c b/drivers/soc/fsl/qe/qe_io.c > >> index a5e2d0e5ab51..02ca556c8db0 100644 > >> --- a/drivers/soc/fsl/qe/qe_io.c > >> +++ b/drivers/soc/fsl/qe/qe_io.c > >> @@ -15,6 +15,7 @@ > >> #include > >> #include > >> #include > >> +#include > >> > >> #include > >> #include > >> @@ -184,3 +185,17 @@ int par_io_of_config(struct device_node *np) > >> return 0; > >> } > >> EXPORT_SYMBOL(par_io_of_config); > >> + > >> +static int __init par_io_populate(void) > >> +{ > >> + struct device_node *np = of_find_node_by_name(NULL, "par_io"); > >> + > >> + if (!np) > >> + return 0; > >> + > >> + of_platform_default_populate(np, NULL, NULL); > >> + of_node_put(np); > >> + > >> + return 0; > >> +} > >> +arch_initcall(par_io_populate); > > > > > > The par_io node is a sub-node of the soc@xxx node. > > The soc@xxx node is simple-bus compatible. This child node should be > > populated. > > > > Why do we need this additional of_platform_default_populate? > > > > Also par_io node has a compatible. Maybe the related driver should call > > of_platform_populate() to populate children of par_io if needed. If this > > driver is missing, maybe it should be created. > > > > Do I miss something? > > As discussed together off-line, at the time being the par_io driver is > not a platform driver. par_io_init() is called from setup_arch() by some > board setups. > > In order to fix the regression, I keep it minimal with an > arch_initcall() function which is equivalent to what we had before > changing this driver to a platform driver. It will also ease applying > the fix to stable without too much churn. > > It will still be possible to rework par_io driver in a follow-up patch > and change it to a propoer platform driver. > Yes, indeed, this makes sense. Thanks for the clarification. Best regards, Hervé