From: Christoph Hellwig <hch@lst.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Hari Mishal <harimishal1@gmail.com>, Jens Axboe <axboe@kernel.dk>,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
Kanchan Joshi <joshi.k@samsung.com>,
Nitesh Shetty <nj.shetty@samsung.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] nvme: drop WARN_ON_ONCE on write_stream bounds check
Date: Thu, 30 Jul 2026 15:37:26 +0200 [thread overview]
Message-ID: <20260730133726.GA2983@lst.de> (raw)
In-Reply-To: <2026073003-primp-granular-c176@gregkh>
On Thu, Jul 30, 2026 at 03:18:21PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Jul 30, 2026 at 01:41:23PM +0200, Christoph Hellwig wrote:
> > On Tue, Jul 28, 2026 at 08:58:00AM +0200, Greg Kroah-Hartman wrote:
> > [... monster quote mostly dropped, please stick mail netiquette]
> > > > but a debug setup you get what you pay for, and I'm really tired of
> > > > all these totally stupid attempts to make WARN_ON the new BUG_ON.
> > > > It is not, and that's for a reason.
> > >
> > > I'm tired of it too, but again, if this can be hit by something a user
> > > does, it ends up being a DoS on the machine :(
> >
> > So let's kill parnic_on_warn? Or tain the kernel when it is set so
> > that anyone enaling it knows they have to keep the pieces when it
> > breaks?
>
> I know why the cloud-boxes want panic-on-warn enabled, as they are
> cattle and want any potential problem to just reboot the box and keep on
> going. And Samsung likes it for their billions of devices for the same
> reason (it's "safe" to reboot a phone I guess...)
>
> So as much as I would _love_ to drop it, we seem to have real users.
Then at least add a taint to make it clear to them that they are
getting themselves into trouble instead of trying taking the only
useful debug tool away because of bad choices of a few.
next prev parent reply other threads:[~2026-07-30 13:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-25 13:51 [PATCH 0/2] nvme: fix racy access to FDP placement ID array Hari Mishal
2026-07-25 13:51 ` [PATCH 1/2] " Hari Mishal
2026-07-27 13:31 ` Kanchan Joshi
2026-07-27 14:22 ` Kanchan Joshi
2026-07-29 11:47 ` Hari Mishal
2026-07-30 5:11 ` Kanchan Joshi
2026-07-25 13:51 ` [PATCH 2/2] nvme: drop WARN_ON_ONCE on write_stream bounds check Hari Mishal
2026-07-27 14:24 ` Keith Busch
2026-07-27 19:19 ` Greg Kroah-Hartman
2026-07-27 22:51 ` Keith Busch
2026-07-28 5:15 ` Greg Kroah-Hartman
2026-07-28 5:18 ` Christoph Hellwig
2026-07-28 6:58 ` Greg Kroah-Hartman
2026-07-28 9:46 ` Keith Busch
2026-07-28 10:34 ` Greg Kroah-Hartman
2026-07-30 11:41 ` Christoph Hellwig
2026-07-30 13:18 ` Greg Kroah-Hartman
2026-07-30 13:37 ` Christoph Hellwig [this message]
2026-07-30 14:04 ` Greg Kroah-Hartman
2026-07-30 14:27 ` Keith Busch
2026-07-30 15:02 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730133726.GA2983@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=harimishal1@gmail.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nj.shetty@samsung.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.