From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA2BD453A23; Thu, 30 Jul 2026 16:06:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785427606; cv=none; b=lLJ2z4+sZ3azbQTUvOOzkQZ1FH9iThj3Lr59FxiKpYlOhQm807pKo72diMKnHcAdL3nSEUzZNNZtfviQsQTo7FiS1oeUzI+4VOOTlm83wFio8D9frVq6YosLa7beyyStvZXtWIK2tCVjLCC6Jx1pyY/Z5Mth0XG6wXN5vsUw+Kk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785427606; c=relaxed/simple; bh=fhJnzq8LeBdloW/Cvqb5Ep1gBUpzPq1sTKSfFZJyCiQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GOa2KR62WKnwmLvei8F6N3y7GV06p+Yeq/fWpWUpY0bi2f3xDzGKDtuE68CTwCJ39jNXsa3Fd9u+EzzRbfFz04WAsBVsvQoOODjUDtmvMBrxHr+OaUDkyE/JVxUkvqXY6tT9kMJvDLpdqsqTGaNIEpEYXOJfvjWZ7gY8eTru6B8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Sm5RwfNc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Sm5RwfNc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 222111F000E9; Thu, 30 Jul 2026 16:06:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785427604; bh=fd5HPbZe34HQZFBotwmb16boKgghbXMN9VSld9DIg4o=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Sm5RwfNc3BcooB017KylpmuvEWj4/nr/3WZkkRQQpLQ9ZWIGBmBIsWKeOwMnJzSSE D+4qAuE0lrVXEDYKI3PjNYzT2E1f1PBhI0qHxpjcfOL24Ms3mWVt+e5WGmnyJtljOc Ao068GtYKXWvoihVs858XLrWyozmhI3Xsx0qANws= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Qing Luo , Xin Long , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.6 184/484] sctp: auth: verify auth requirement when auth_chunk is NULL Date: Thu, 30 Jul 2026 16:11:21 +0200 Message-ID: <20260730141427.464385466@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141423.392222816@linuxfoundation.org> References: <20260730141423.392222816@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Qing Luo [ Upstream commit 8e04823c120b376ef7dab14b60ebf6823aa16c14 ] sctp_auth_chunk_verify() returns true unconditionally when chunk->auth_chunk is NULL, silently skipping authentication. This is incorrect when: 1. skb_clone() failed in the BH receive path, leaving auth_chunk NULL. In sctp_endpoint_bh_rcv() asoc is NULL for new connections, so the early sctp_auth_recv_cid() check cannot catch this. 2. No AUTH chunk precedes COOKIE-ECHO, so skb_clone() is never called and auth_chunk remains NULL. Fix by checking sctp_auth_recv_cid() when auth_chunk is NULL: if authentication is required, return false to drop the chunk; otherwise continue normally. Fixes: bbd0d59809f9 ("[SCTP]: Implement the receive and verification of AUTH chunk") Signed-off-by: Qing Luo Acked-by: Xin Long Link: https://patch.msgid.link/20260721015532.120157-2-l1138897701@163.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/sctp/sm_statefuns.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index fc04bea029dc1d..ce0b5d6b4c5239 100644 --- a/net/sctp/sm_statefuns.c +++ b/net/sctp/sm_statefuns.c @@ -640,7 +640,7 @@ static bool sctp_auth_chunk_verify(struct net *net, struct sctp_chunk *chunk, struct sctp_chunk auth; if (!chunk->auth_chunk) - return true; + return !sctp_auth_recv_cid(chunk->chunk_hdr->type, asoc); /* SCTP-AUTH: auth_chunk pointer is only set when the cookie-echo * is supposed to be authenticated and we have to do delayed -- 2.53.0