From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ECDE449EB8; Thu, 30 Jul 2026 16:11:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785427893; cv=none; b=qfe84zwdXwS9sOQltjsuTXTCKh2NAJ1zNeTZW4yq5Hvb/MzaiWtH1vJsyrA/5LeF5cuDRqEZm28CGurHsuXuuMuRjlwXrWGV+ITFYV8alx3N+ztY9I+ScxnmmRRD0Eok77Y5xib05XL8YRGvROBpJF0bMYOZY5W25LbqcZh/TJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785427893; c=relaxed/simple; bh=KR1/sesV08dYAIjkKUIWGMR6OxPTjAUXa3WNnpAHYnw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j0l2cvlejvAXDn2SborV6e/Tr2kXYth8dlkrGQg89kKUavdy6NhA2DixFP+ViQdSphorp14imxHo2/weq1TpO9fCKwdVmW/uUdROn/xqZJvk6e1R9aS9+j6/hUxGgaiPeCbJtYbu4pgbhw3Tobqs6xtSonegYbj2nkhO7BiUV20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Hy4K+nvD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Hy4K+nvD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 664171F000E9; Thu, 30 Jul 2026 16:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785427892; bh=23rIHuEP+RbA5mrVk+sZV2ug6SbOM//eFw2oUJOyivY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Hy4K+nvDMqXGIW8eTaKaM9C5fWKJJdCrUElgYyP3KueSf5eHcV5aaGlKyo4P7TT+e jc2CMrwCJUnR1pnDPJxN6MBS+Kq4zCswf6koZQFDQPDti9y07CJ1QOg4PIN0QPgLAT lgj7yztqufYd5WmkLpS/td4ZXNKOteaDZ1djUbB4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Simon Horman , Doruk Tan Ozturk , Jakub Kicinski Subject: [PATCH 6.6 331/484] mac802154: llsec: reject frames shorter than the authentication tag Date: Thu, 30 Jul 2026 16:13:48 +0200 Message-ID: <20260730141430.678107918@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141423.392222816@linuxfoundation.org> References: <20260730141423.392222816@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Doruk Tan Ozturk commit fd3a3f28ed60c6af4b2a39933b151d6b27842c3b upstream. llsec_do_decrypt_auth() computes the associated-data length for the AEAD request as assoclen += datalen - authlen; where datalen is the number of bytes after the MAC header and authlen (4, 8 or 16) is the length of the authentication tag. Nothing verifies that the frame actually carries at least authlen payload bytes. A secured frame whose payload is shorter than the tag makes datalen - authlen negative; assoclen is then passed to aead_request_set_ad() as an unsigned value close to 4 GiB, so crypto_aead_decrypt() walks far off the end of the scatterlist that only spans the real frame. The frame is fully attacker-controlled and reaches this path from any IEEE 802.15.4 peer in radio range. Reject frames whose payload is shorter than the authentication tag before the subtraction. Dynamically reproduced on a KASAN kernel as a general-protection-fault in the AEAD scatterwalk, and the fix confirmed. Fixes: 4c14a2fb5d14 ("mac802154: add llsec decryption method") Cc: stable@vger.kernel.org Reviewed-by: Simon Horman Signed-off-by: Doruk Tan Ozturk Link: https://patch.msgid.link/20260716193423.32498-1-doruk@0sec.ai Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/mac802154/llsec.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/net/mac802154/llsec.c +++ b/net/mac802154/llsec.c @@ -891,6 +891,11 @@ llsec_do_decrypt_auth(struct sk_buff *sk data = skb_mac_header(skb) + skb->mac_len; datalen = skb_tail_pointer(skb) - data; + if (datalen < authlen) { + kfree_sensitive(req); + return -EBADMSG; + } + sg_init_one(&sg, skb_mac_header(skb), assoclen + datalen); if (!(hdr->sec.level & IEEE802154_SCF_SECLEVEL_ENC)) {