From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6BF433438F; Thu, 30 Jul 2026 15:41:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785426110; cv=none; b=ixof5jJIif8WRSnPw8HMKtMkdT2GcgZrWO0uMPc8HgcgRqOgVicXRCy9l7hRLup9oJcxgQVtst3T+OIjKhbPQYYNNhIwHBXV8TsGC6ZdiLRs3Zfz9R/vDUEjZL7wF5A7ErS5BOGCiW4eWo/UVgjUpHkPFL+jcHsRkgdyY9rPYGE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785426110; c=relaxed/simple; bh=oBJopeP49lYO2EJ4C0twLdoChOdwjqqr8MVKmFL6B/o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OhBL+cOSG9CWwXmkk61USs9BStRmWEmRfzzeJ8JR6xAsrqHLNJzikl0cspcFtdDlqqU/oaY0HoKXhgdJSO81mn4dWT5/mERPMgbjdXSAZ92Q+4TZXgGZBe7wClhYPuTxVzLvp1hzprTOd5/9NAfGo5G09/QbCag7ky2REV4htIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=j3OXXY9t; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="j3OXXY9t" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CD5E1F000E9; Thu, 30 Jul 2026 15:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785426109; bh=CfTG65PHbKxVLAR3IpkZ6NkZ9+lVl1toR4o3xRG1JVU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=j3OXXY9t+tSpmliobW4LZZhQIJKWvTG+0AiN5Ir5MRZsBfBd3/wJJHU2FUeCShcGd MQxGMIwr50WLscEwjYSz+mHYTvh+bUwwaw8kkmKgTwU+58WmC9cNmTchWVQrGLCo96 CYZGOOT//XrZLrLbXHeRsCu37nAs8IhLm81Ht/Bs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pengpeng Hou , Nicolas Dufresne , Jernej Skrabec , Chen-Yu Tsai , Hans Verkuil Subject: [PATCH 6.12 304/602] media: cedrus: skip invalid H.264 reference list entries Date: Thu, 30 Jul 2026 16:11:36 +0200 Message-ID: <20260730141442.356771225@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141435.976815864@linuxfoundation.org> References: <20260730141435.976815864@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pengpeng Hou commit 10358ea986c3c85516d1c8206486464f79d36e76 upstream. Cedrus consumes H.264 ref_pic_list0/ref_pic_list1 entries from the stateless slice control and later uses their indices to look up decode->dpb[] in _cedrus_write_ref_list(). Rejecting such controls in cedrus_try_ctrl() would break existing userspace, since stateless H.264 reference lists may legitimately carry out-of-range indices for missing references. Instead, guard the actual DPB lookup in Cedrus and skip entries whose indices do not fit the fixed V4L2_H264_NUM_DPB_ENTRIES array. This keeps the fix local to the driver use site and avoids out-of-bounds reads from malformed or unsupported reference list entries. Fixes: e000e1fa4bdbd ("media: uapi: h264: Update reference lists") Cc: stable@vger.kernel.org Signed-off-by: Pengpeng Hou Reviewed-by: Nicolas Dufresne Acked-by: Jernej Skrabec Tested-by: Chen-Yu Tsai Signed-off-by: Nicolas Dufresne Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/sunxi/cedrus/cedrus_h264.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/staging/media/sunxi/cedrus/cedrus_h264.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus_h264.c @@ -210,6 +210,9 @@ static void _cedrus_write_ref_list(struc u8 dpb_idx; dpb_idx = ref_list[i].index; + if (dpb_idx >= V4L2_H264_NUM_DPB_ENTRIES) + continue; + dpb = &decode->dpb[dpb_idx]; if (!(dpb->flags & V4L2_H264_DPB_ENTRY_FLAG_ACTIVE))