From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5EBC217723; Thu, 30 Jul 2026 15:19:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785424795; cv=none; b=TC8kr1V/oH345hKqJQj2Ej2fs+1wnkk7zCODeo8Bsy/H/2S7OI/alYsr9+AaldQwecEKiSzCXc+Cr7VYwP/1nSJHKjAMNM5SMjviMspbeMmByc1jDArR+9esVzXiC0H2550zYtZ9Nxq5Ig9bVV7cR9xCA/wXrN42LCgBeGuBJFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785424795; c=relaxed/simple; bh=Z+DevC9XIkctLxrVo857vbkaU2zoKT60QAhdvkrbQJA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BoKeQrKti4da0iPlXGwt1yN47U2w9qTIS/Id/pW7WWyDzyJ3QXbPeW4UhoOTpRYxqCZU9Ry74BhDmaTrOO2VADkW2No6WZOzOpfeN0k9pv/0oNc6ozYyFjfY1CkFwypPfCy8to7ocZknUXhVH/lS3bnPL49BtbOoWipjrgKn2xo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ADqMqmkN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ADqMqmkN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35AA41F000E9; Thu, 30 Jul 2026 15:19:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785424794; bh=JMxAelb6SlNcrwt0qICFtTdiMBI2WDd+J0oRT16xXS4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ADqMqmkN7PF1A2tanOocMCsJ44t6dCM+rMggw3V3wJE7uWl/SAzVhTGLzTftoJDrU KgnDhjSazmAlJ4jp38M0a/w7/V1FJj/ZIhdl5ETPaONaZvE1h54BF2dJaAKmiq6bDe wUaZiZYHOqXpaW2Ka5mbrEblE34iGLukpzaIS4sw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuan Tan , Zhengchuan Liang , Xin Liu , Douya Le , Ren Wei , Viacheslav Dubeyko , Ilya Dryomov Subject: [PATCH 6.18 520/675] libceph: remove debugfs files before client teardown Date: Thu, 30 Jul 2026 16:14:10 +0200 Message-ID: <20260730141456.191189940@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141445.110192266@linuxfoundation.org> References: <20260730141445.110192266@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Douya Le commit e4c804726c4afce3ba648b982d564f6af2cfa328 upstream. ceph_destroy_client() tears down the monitor client before removing the per-client debugfs files. A concurrent read of the monmap debugfs file can enter monmap_show() after ceph_monc_stop() has freed monc->monmap, triggering a use-after-free. Remove the debugfs files before stopping the OSD and monitor clients. debugfs_remove() drains active handlers and prevents new accesses, so the debugfs callbacks can no longer race the rest of client teardown. Cc: stable@vger.kernel.org Fixes: 76aa844d5b2f ("ceph: debugfs") Reported-by: Yuan Tan Reported-by: Zhengchuan Liang Reported-by: Xin Liu Assisted-by: Codex:GPT-5.4 Signed-off-by: Douya Le Signed-off-by: Ren Wei Reviewed-by: Viacheslav Dubeyko Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- net/ceph/ceph_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/ceph/ceph_common.c +++ b/net/ceph/ceph_common.c @@ -763,13 +763,13 @@ void ceph_destroy_client(struct ceph_cli atomic_set(&client->msgr.stopping, 1); + ceph_debugfs_client_cleanup(client); + /* unmount */ ceph_osdc_stop(&client->osdc); ceph_monc_stop(&client->monc); ceph_messenger_fini(&client->msgr); - ceph_debugfs_client_cleanup(client); - ceph_destroy_options(client->options); kfree(client);