From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF647C55164 for ; Thu, 30 Jul 2026 14:33:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wllIMaVZR8KIXbzrhUeKa1ZfhJISOa7afFz3TmfALVQ=; b=e5qvHmhYP4RJcX P31syvW2lbXfCQPdy/BbKLdP6EnA+EKtvfjVthfOfwfRq68OCCq5Kmqo/KsjYysBa3FA+Nlg8Mn/m Mr2cD+hbnIkb4deDBJEWTK+de2TEL2EobErUJLgwfAj+gbspOcefUpSCnKmkAeLnPyjRFY/NFCXrb 86HH8QkuYrgI5oZfO3CH+Thob9C3h49KFybydtW8Pq2KW0EmwAYYgdlG5qQjwAOlHl6stUdiqcg/R cTGuGm2zsaefjXqb+xFw2BttcJD7l5wmQrD4WinziMTudjvuk/SzAk821w9pkfX/9GlefCaMbNrue TwidzBPzVhCu7Ed5/Rdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpRpA-0000000Al2y-2VAU; Thu, 30 Jul 2026 14:33:28 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpRp9-0000000Al2Y-09em for linux-phy@lists.infradead.org; Thu, 30 Jul 2026 14:33:27 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B96F240743; Thu, 30 Jul 2026 14:33:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 368671F000E9; Thu, 30 Jul 2026 14:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785422006; bh=jDGqA9OLIzwP/f6D/7b6USQ0/qeaV30b9h4d0Wxh8N0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ChklVWRHIVvAl+fMRxnmcnvPQ0TWZqkx29afSnNgJgD0c5WieZ1PFwBZAGHbrgzrN IkyD8r66xQhaL5+GXlwvjuIa+kHQ6lQQl4JH/DLvfESh/HoXhoB7b96j1ENRabrXtv 3zVedvoTvBu7rirq+F6iIvPfbzrIJBUnhOUHawJikIJucL7fhKThHA7zBZIs97gKpp RbMtyNggLKz9w6fFC/ToiaZr1E8VGt0Vo4AJu2p1Q+RQQpPXXG5CJMHTz6iYUrfw9X O0ivppxz022oyiggvJbJoAh6PNhvL10EoxR8GLV1cmMyNCDKHUA5xQ0hGNOQcvkbWD skWmBM1fcFdKg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 1/5] dt-bindings: phy: qcom,qmp-usb3-dp: Extend X1E description for USB4 To: "Konrad Dybcio" Cc: olteanv@gmail.com, vkoul@kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260730-topic-usb4phy-v3-1-ccf0f7ea98b5@oss.qualcomm.com> References: <20260730-topic-usb4phy-v3-0-ccf0f7ea98b5@oss.qualcomm.com> <20260730-topic-usb4phy-v3-1-ccf0f7ea98b5@oss.qualcomm.com> Date: Thu, 30 Jul 2026 14:33:25 +0000 Message-Id: <20260730143326.368671F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIFRoZSBgY2xvY2stbmFt ZXNgIGRlZmluaXRpb24gZm9yIGBxY29tLHgxZTgwMTAwLXFtcC11c2IzLWRwLXBoeWAgaW1wbGlj aXRseSBtYWtlcyB0aGUgNXRoIGNsb2NrIG1hbmRhdG9yeSwgYnJlYWtpbmcgdmFsaWRhdGlvbiBm b3IgZXhpc3RpbmcgZGV2aWNlIHRyZWVzLgotIFtNZWRpdW1dIFRoZSBgcDJycjJwX3BpcGVgIGNs b2NrIGlzIGFydGlmaWNpYWxseSByZXN0cmljdGVkIHRvIHRoZSBYMUUgU29DLCBwcmV2ZW50aW5n IG90aGVyIFVTQjQtY2FwYWJsZSBTb0NzIGluIHRoZSBzYW1lIGJpbmRpbmcgZnJvbSBtb2RlbGlu ZyB0aGVpciBoYXJkd2FyZSBjb3JyZWN0bHkuCi0tCgotLS0gUGF0Y2ggWzFdOiBbUEFUQ0ggdjMg MS81XSBkdC1iaW5kaW5nczogcGh5OiBxY29tLHFtcC11c2IzLWRwOiBFeHRlbmQgWDFFIGRlc2Ny aXB0aW9uIGZvciBVU0I0IC0tLQpjb21taXQgODYyODNlMTIwYTI5MmU3M2U3NDFkOGZjMGQyMzMz ODJlNjkxNzcwYQpBdXRob3I6IEtvbnJhZCBEeWJjaW8gPGtvbnJhZC5keWJjaW9Ab3NzLnF1YWxj b21tLmNvbT4KCmR0LWJpbmRpbmdzOiBwaHk6IHFjb20scW1wLXVzYjMtZHA6IEV4dGVuZCBYMUUg ZGVzY3JpcHRpb24gZm9yIFVTQjQKClRoaXMgY29tbWl0IGV4dGVuZHMgdGhlIFgxRSBVU0IzL0RQ IFBIWSBiaW5kaW5ncyB0byBzdXBwb3J0IFVTQjQgbW9kZSBieQphbGxvd2luZyBhbiBhZGRpdGlv bmFsIGNsb2NrIChQMlJSMlApLiBJdCBhZGRzIGNvbmRpdGlvbmFscyB0byBoYW5kbGUgdGhlCmRp ZmZlcmVuY2VzIGluIGNsb2NrIHJlcXVpcmVtZW50cyBiZXR3ZWVuIGVhcmxpZXIgZ2VuZXJhdGlv bnMgYW5kIFgxRS4KCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9waHkvcWNvbSxzYzgyODB4cC1xbXAtdXNiNDNkcC1waHkueWFtbCBiL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9waHkvcWNvbSxzYzgyODB4cC1xbXAtdXNiNDNkcC1waHku eWFtbAo+IGluZGV4IDRlZmY5MjM0M2NlNGYuLjE4OTMwZWI5NmJkZmUgMTAwNjQ0Cj4gLS0tIGEv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BoeS9xY29tLHNjODI4MHhwLXFtcC11 c2I0M2RwLXBoeS55YW1sCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L3BoeS9xY29tLHNjODI4MHhwLXFtcC11c2I0M2RwLXBoeS55YW1sCgpbIC4uLiBdCgo+IEBAIC0x ODcsMjEgKzE4Miw1OSBAQCBhbGxPZjoKPiAgICAtIGlmOgo+ICAgICAgICBwcm9wZXJ0aWVzOgo+ ICAgICAgICAgIGNvbXBhdGlibGU6Cj4gLSAgICAgICAgICBlbnVtOgo+IC0gICAgICAgICAgICAt IHFjb20sc2M3MTgwLXFtcC11c2IzLWRwLXBoeQo+IC0gICAgICAgICAgICAtIHFjb20sc2RtODQ1 LXFtcC11c2IzLWRwLXBoeQo+ICsgICAgICAgICAgY29udGFpbnM6Cj4gKyAgICAgICAgICAgIGVu dW06Cj4gKyAgICAgICAgICAgICAgLSBxY29tLHgxZTgwMTAwLXFtcC11c2IzLWRwLXBoeQo+ICAg ICAgdGhlbjoKPiAgICAgICAgcHJvcGVydGllczoKPiAgICAgICAgICBjbG9ja3M6Cj4gICAgICAg ICAgICBtYXhJdGVtczogNQo+ICAgICAgICAgIGNsb2NrLW5hbWVzOgo+ICsgICAgICAgICAgaXRl bXM6Cj4gKyAgICAgICAgICAgIC0gY29uc3Q6IGF1eAo+ICsgICAgICAgICAgICAtIGNvbnN0OiBy ZWYKPiArICAgICAgICAgICAgLSBjb25zdDogY29tX2F1eAo+ICsgICAgICAgICAgICAtIGNvbnN0 OiB1c2IzX3BpcGUKPiArICAgICAgICAgICAgLSBjb25zdDogcDJycjJwX3BpcGUKCltTZXZlcml0 eTogSGlnaF0KV2lsbCB0aGlzIGJyZWFrIGRldmljZSB0cmVlIHZhbGlkYXRpb24gZm9yIGV4aXN0 aW5nIHgxZTgwMTAwIGRldmljZSB0cmVlcwp0aGF0IG9ubHkgcHJvdmlkZSA0IGNsb2Nrcz8gU2lu Y2UgbWluSXRlbXMgaXMgbm90IGV4cGxpY2l0bHkgc2V0IGluIHRoaXMKbG9jYWwgc3Vic2NoZW1h LCBkdC1zY2hlbWEgd2lsbCBhdXRvbWF0aWNhbGx5IHNldCBtaW5JdGVtcyB0byA1IHRvIG1hdGNo CnRoZSBsZW5ndGggb2YgdGhlIGl0ZW1zIGFycmF5LiBTaG91bGQgbWluSXRlbXM6IDQgYmUgYWRk ZWQgdG8gdGhpcyBibG9jayB0bwpwcmVzZXJ2ZSBiYWNrd2FyZCBjb21wYXRpYmlsaXR5PwoKPiAr Cj4gKyAgLSBpZjoKPiArICAgICAgcHJvcGVydGllczoKPiArICAgICAgICBjb21wYXRpYmxlOgo+ ICsgICAgICAgICAgY29udGFpbnM6Cj4gKyAgICAgICAgICAgIGVudW06Cj4gKyAgICAgICAgICAg ICAgLSBxY29tLHNjNzE4MC1xbXAtdXNiMy1kcC1waHkKPiArICAgICAgICAgICAgICAtIHFjb20s c2RtODQ1LXFtcC11c2IzLWRwLXBoeQo+ICsgICAgdGhlbjoKPiArICAgICAgcHJvcGVydGllczoK PiArICAgICAgICBjbG9ja3M6Cj4gICAgICAgICAgICBtYXhJdGVtczogNQo+IC0gICAgZWxzZToK PiArICAgICAgICBjbG9jay1uYW1lczoKPiArICAgICAgICAgIGl0ZW1zOgo+ICsgICAgICAgICAg ICAtIGNvbnN0OiBhdXgKPiArICAgICAgICAgICAgLSBjb25zdDogcmVmCj4gKyAgICAgICAgICAg IC0gY29uc3Q6IGNvbV9hdXgKPiArICAgICAgICAgICAgLSBjb25zdDogdXNiM19waXBlCj4gKyAg ICAgICAgICAgIC0gY29uc3Q6IGNmZ19haGIKPiArCj4gKyAgLSBpZjoKPiArICAgICAgbm90Ogo+ ICsgICAgICAgIHByb3BlcnRpZXM6Cj4gKyAgICAgICAgICBjb21wYXRpYmxlOgo+ICsgICAgICAg ICAgICBjb250YWluczoKPiArICAgICAgICAgICAgICBlbnVtOgo+ICsgICAgICAgICAgICAgICAg LSBxY29tLHgxZTgwMTAwLXFtcC11c2IzLWRwLXBoeQo+ICsgICAgICAgICAgICAgICAgLSBxY29t LHNjNzE4MC1xbXAtdXNiMy1kcC1waHkKPiArICAgICAgICAgICAgICAgIC0gcWNvbSxzZG04NDUt cW1wLXVzYjMtZHAtcGh5CgpbU2V2ZXJpdHk6IE1lZGl1bV0KRG9lcyB0aGlzIGFydGlmaWNpYWwg cmVzdHJpY3Rpb24gdG8gbWF4SXRlbXM6IDQgZm9yIGFsbCBvdGhlciBjb21wYXRpYmxlcwpwcmV2 ZW50IG90aGVyIFVTQjQtY2FwYWJsZSBTb0NzIChsaWtlIHNjODI4MHhwKSBmcm9tIGNvcnJlY3Rs eSBtb2RlbGluZwp0aGVpciBoYXJkd2FyZT8KCklmIHRoZXkgc2hhcmUgdGhlIHNhbWUgVVNCNDNE UCBoYXJkd2FyZSBjYXBhYmlsaXRpZXMgYW5kIGF2YWlsYWJsZSBjbG9jawpsaW5lcywgdGhleSB3 aWxsIGZhaWwgdmFsaWRhdGlvbiBpZiBhIGRldmVsb3BlciBhdHRlbXB0cyB0byBhZGQgdGhlCnAy cnIycF9waXBlIGNsb2NrIHRvIHRoZW0gaW4gdGhlIGZ1dHVyZS4KCkNvdWxkIHRoaXMgYmUgc3Ry dWN0dXJlZCB0byBhbGxvdyB0aGUgNXRoIGNsb2NrIG9uIG90aGVyIGlkZW50aWNhbCBoYXJkd2Fy ZQp2YXJpYW50cz8KCj4gKyAgICB0aGVuOgo+ICAgICAgICBwcm9wZXJ0aWVzOgo+ICAgICAgICAg IGNsb2NrczoKPiAgICAgICAgICAgIG1heEl0ZW1zOiA0Cj4gICAgICAgICAgY2xvY2stbmFtZXM6 Cj4gLSAgICAgICAgICBtYXhJdGVtczogNAo+ICsgICAgICAgICAgaXRlbXM6Cj4gKyAgICAgICAg ICAgIC0gY29uc3Q6IGF1eAo+ICsgICAgICAgICAgICAtIGNvbnN0OiByZWYKPiArICAgICAgICAg ICAgLSBjb25zdDogY29tX2F1eAo+ICsgICAgICAgICAgICAtIGNvbnN0OiB1c2IzX3BpcGUKCi0t IApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAy NjA3MzAtdG9waWMtdXNiNHBoeS12My0wLWNjZjBmN2VhOThiNUBvc3MucXVhbGNvbW0uY29tP3Bh cnQ9MQoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt cGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04B90441600 for ; Thu, 30 Jul 2026 14:33:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785422008; cv=none; b=nh3IwPGb7xI7KGdW+kLA+J+OG77HoJVHggJ8W8gp094acX82kyrswAW4NBVx0Yh6dJha3c0Ad/fAuxXxUwTXkMa/3IAnXDGrc+t4NUggFmHEjPdDcwhF4PzFkrn+nadf94eDNhKcoigEhR/XIieRiH6j4g5URydRnCj1AcB6vgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785422008; c=relaxed/simple; bh=53dUPOGtMTdKmDexw5aAa5qqfcFZRfWYTJMbXsvu+mQ=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=kbDWIX3y9CTF2nES0Hu7bqJ3VtglHrLbWDIz+GpGF4qIpQy1bytopSl1lM74elQozO15W07Ie8ycV06scG4RapiwGIBxyVuiEDjo/YYCsuqAICJZZ6q6/MVyQ7X3vKs2HioU9sHOHPctr0ZWhzyy1Xycy1I/KvlC0cmD44emVAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ChklVWRH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ChklVWRH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 368671F000E9; Thu, 30 Jul 2026 14:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785422006; bh=jDGqA9OLIzwP/f6D/7b6USQ0/qeaV30b9h4d0Wxh8N0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ChklVWRHIVvAl+fMRxnmcnvPQ0TWZqkx29afSnNgJgD0c5WieZ1PFwBZAGHbrgzrN IkyD8r66xQhaL5+GXlwvjuIa+kHQ6lQQl4JH/DLvfESh/HoXhoB7b96j1ENRabrXtv 3zVedvoTvBu7rirq+F6iIvPfbzrIJBUnhOUHawJikIJucL7fhKThHA7zBZIs97gKpp RbMtyNggLKz9w6fFC/ToiaZr1E8VGt0Vo4AJu2p1Q+RQQpPXXG5CJMHTz6iYUrfw9X O0ivppxz022oyiggvJbJoAh6PNhvL10EoxR8GLV1cmMyNCDKHUA5xQ0hGNOQcvkbWD skWmBM1fcFdKg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 1/5] dt-bindings: phy: qcom,qmp-usb3-dp: Extend X1E description for USB4 Reply-To: sashiko-reviews@lists.linux.dev To: "Konrad Dybcio" Cc: olteanv@gmail.com, vkoul@kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260730-topic-usb4phy-v3-1-ccf0f7ea98b5@oss.qualcomm.com> References: <20260730-topic-usb4phy-v3-0-ccf0f7ea98b5@oss.qualcomm.com> <20260730-topic-usb4phy-v3-1-ccf0f7ea98b5@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 30 Jul 2026 14:33:25 +0000 Message-Id: <20260730143326.368671F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] The `clock-names` definition for `qcom,x1e80100-qmp-usb3-dp-phy` i= mplicitly makes the 5th clock mandatory, breaking validation for existing d= evice trees. - [Medium] The `p2rr2p_pipe` clock is artificially restricted to the X1E So= C, preventing other USB4-capable SoCs in the same binding from modeling the= ir hardware correctly. -- --- Patch [1]: [PATCH v3 1/5] dt-bindings: phy: qcom,qmp-usb3-dp: Extend X1= E description for USB4 --- commit 86283e120a292e73e741d8fc0d233382e691770a Author: Konrad Dybcio dt-bindings: phy: qcom,qmp-usb3-dp: Extend X1E description for USB4 This commit extends the X1E USB3/DP PHY bindings to support USB4 mode by allowing an additional clock (P2RR2P). It adds conditionals to handle the differences in clock requirements between earlier generations and X1E. > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb4= 3dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb4= 3dp-phy.yaml > index 4eff92343ce4f..18930eb96bdfe 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy= .yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy= .yaml [ ... ] > @@ -187,21 +182,59 @@ allOf: > - if: > properties: > compatible: > - enum: > - - qcom,sc7180-qmp-usb3-dp-phy > - - qcom,sdm845-qmp-usb3-dp-phy > + contains: > + enum: > + - qcom,x1e80100-qmp-usb3-dp-phy > then: > properties: > clocks: > maxItems: 5 > clock-names: > + items: > + - const: aux > + - const: ref > + - const: com_aux > + - const: usb3_pipe > + - const: p2rr2p_pipe [Severity: High] Will this break device tree validation for existing x1e80100 device trees that only provide 4 clocks? Since minItems is not explicitly set in this local subschema, dt-schema will automatically set minItems to 5 to match the length of the items array. Should minItems: 4 be added to this block to preserve backward compatibility? > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sc7180-qmp-usb3-dp-phy > + - qcom,sdm845-qmp-usb3-dp-phy > + then: > + properties: > + clocks: > maxItems: 5 > - else: > + clock-names: > + items: > + - const: aux > + - const: ref > + - const: com_aux > + - const: usb3_pipe > + - const: cfg_ahb > + > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - qcom,x1e80100-qmp-usb3-dp-phy > + - qcom,sc7180-qmp-usb3-dp-phy > + - qcom,sdm845-qmp-usb3-dp-phy [Severity: Medium] Does this artificial restriction to maxItems: 4 for all other compatibles prevent other USB4-capable SoCs (like sc8280xp) from correctly modeling their hardware? If they share the same USB43DP hardware capabilities and available clock lines, they will fail validation if a developer attempts to add the p2rr2p_pipe clock to them in the future. Could this be structured to allow the 5th clock on other identical hardware variants? > + then: > properties: > clocks: > maxItems: 4 > clock-names: > - maxItems: 4 > + items: > + - const: aux > + - const: ref > + - const: com_aux > + - const: usb3_pipe --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260730-topic-usb4= phy-v3-0-ccf0f7ea98b5@oss.qualcomm.com?part=3D1