From: Jakub Kicinski <kuba@kernel.org>
To: Kyle Switch <kyle.switch@motor-comm.com>
Cc: Frank.Sae@motor-comm.com, andrew@lunn.ch, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ming.xu@motor-comm.com,
xiaolin.xu@motor-comm.com, jianmin.wang@motor-comm.com,
jie.han@motor-comm.com
Subject: Re: [PATCH net-next v7] net: phy: Add driver for Motorcomm Quad 2.5GbE phy
Date: Thu, 30 Jul 2026 15:35:27 -0700 [thread overview]
Message-ID: <20260730153527.34135188@kernel.org> (raw)
In-Reply-To: <20260728112105.2668014-1-kyle.switch@motor-comm.com>
On Tue, 28 Jul 2026 19:21:05 +0800 Kyle Switch wrote:
> Add a driver for motorcomm yt8824 quad 2.5G ethernet phy, supports
> 2.5G/1000M/100M/10M speed
Missing some kdoc returns:
Warning: drivers/net/phy/phy-c45.c:1293 No description found for return value of 'genphy_c45_template_testmode'
Warning: drivers/net/phy/phy-c45.c:1293 No description found for return value of 'genphy_c45_template_testmode'
Plus at a glance you also added stray semicolons after functions?
Last but not least, Sashiko/Gemini has 10 complaints, please check
these before working on v8:
https://sashiko.dev/#/patchset/20260728112105.2668014-1-kyle.switch@motor-comm.com
--
pw-bot: cr
prev parent reply other threads:[~2026-07-30 22:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 11:21 [PATCH net-next v7] net: phy: Add driver for Motorcomm Quad 2.5GbE phy Kyle Switch
2026-07-30 22:35 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730153527.34135188@kernel.org \
--to=kuba@kernel.org \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jianmin.wang@motor-comm.com \
--cc=jie.han@motor-comm.com \
--cc=kyle.switch@motor-comm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ming.xu@motor-comm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiaolin.xu@motor-comm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.