From: Jakub Kicinski <kuba@kernel.org>
To: Marcelo Mendes Spessoto Junior <marcelomspessoto@gmail.com>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
Marcelo Mendes Spessoto Junior <marcelospe@proton.me>
Subject: Re: [PATCH net-next 0/4] net: selftests: adjustments to ipv6_flowlabel_mgr
Date: Thu, 30 Jul 2026 18:41:03 -0700 [thread overview]
Message-ID: <20260730184103.0a5abf5b@kernel.org> (raw)
In-Reply-To: <20260727043516.93101-1-marcelospe@proton.me>
On Mon, 27 Jul 2026 01:25:06 -0300 Marcelo Mendes Spessoto Junior wrote:
> The ipv6_flowlabel_mgr test file was lacking coverage for the IPV6_FL_A_RENEW
> action, and the IPV6_FL_F_REMOTE and IPV6_FL_F_REFLECT flags. The first
> three patches from this set aim to add a proper test case for each.
>
> The fourth patch proposes the adoption of "kselftest_harness.h" helpers,
> improving code readability and conforming to the implementation of the most
> recent selftests.
I sent out an AI generated review, please assume that around half of
the comments are valid and worth addressing...
prev parent reply other threads:[~2026-07-31 1:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 4:25 [PATCH net-next 0/4] net: selftests: adjustments to ipv6_flowlabel_mgr Marcelo Mendes Spessoto Junior
2026-07-27 4:25 ` [PATCH net-next 1/4] selftests: net: test IPV6_FL_A_RENEW Marcelo Mendes Spessoto Junior
2026-07-31 1:39 ` Jakub Kicinski
2026-07-27 4:25 ` [PATCH net-next 2/4] selftests: net: test IPV6_FL_F_REMOTE Marcelo Mendes Spessoto Junior
2026-07-31 1:39 ` Jakub Kicinski
2026-07-31 1:42 ` Jakub Kicinski
2026-07-27 4:25 ` [PATCH net-next 3/4] selftests: net: test IPV6_FL_F_REFLECT Marcelo Mendes Spessoto Junior
2026-07-31 1:39 ` Jakub Kicinski
2026-07-27 4:25 ` [PATCH 4/4] selftests: net: adopt harness for flow label mgr Marcelo Mendes Spessoto Junior
2026-07-31 1:39 ` Jakub Kicinski
2026-07-31 1:41 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730184103.0a5abf5b@kernel.org \
--to=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=marcelomspessoto@gmail.com \
--cc=marcelospe@proton.me \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.