From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7E363451B3 for ; Thu, 30 Jul 2026 16:21:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785428475; cv=none; b=JoN69NuhnjobCV/xbKhdfBJYjKRD6JAlPDprQqjHwjoUiWWOk1J3WX7rGZUQvm74New15er6LpWUN6eEIrT4LrVyB0L7UFkwqDxRoGTpS2V5gQnu5iiUGLNJU6q+0lW76A/236WAW3mlyfbWvSwpLTVIO8xGvoCxm5iB3GCwC8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785428475; c=relaxed/simple; bh=VKY66KK5Vz6dXuJQ0mcjGbhcSs5G7y/10yeglb1glCY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MuJhNrg1vIhiJIPDzLtOaY540e05NefxiJptVUOpUytMqtBYslXcSkQjq6ueYH4vOqDJKQCjrTTjYZ9NzZ+CV6aQABumV6AY5U0le2kToofiAau+6/2rRbk68k7wy4C4RwWw8NOKfhwNFlitkCEUWqR5CnZkZy6SoVBNYAnVfok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Uw6mP4KA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Uw6mP4KA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 229E11F000E9; Thu, 30 Jul 2026 16:21:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785428474; bh=kf5ageCsFrap3bA1QWcIlFlQfC1vfoha691k6exf2uE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Uw6mP4KAf2UaS98H1gBHmDVl/BrH9fFspyWL0M23xglW3zzXPUC2NdbYApv6v0Qk+ EsWMF6iYOVEOPxb/AUXqBVDD6UCP+PxAT2OThdFT8/mJZgdod6uY+vAHKSigyrfpnx YBZ928aaNoBgFVopfPzaXwMuTIoYHaTrGNlMk4jo= Date: Thu, 30 Jul 2026 17:02:32 +0200 From: Greg Kroah-Hartman To: Keith Busch Cc: Christoph Hellwig , Hari Mishal , Jens Axboe , Sagi Grimberg , Hannes Reinecke , Kanchan Joshi , Nitesh Shetty , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] nvme: drop WARN_ON_ONCE on write_stream bounds check Message-ID: <2026073054-visiting-plural-7eb0@gregkh> References: <2026072748-unpopular-onlooker-4a2b@gregkh> <2026072849-uproar-aqua-07c3@gregkh> <20260728051838.GA20593@lst.de> <2026072834-buffoon-entwine-ed16@gregkh> <20260730114123.GB25956@lst.de> <2026073003-primp-granular-c176@gregkh> <20260730133726.GA2983@lst.de> <2026073049-improper-paparazzi-6be7@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jul 30, 2026 at 08:27:07AM -0600, Keith Busch wrote: > On Thu, Jul 30, 2026 at 04:04:03PM +0200, Greg Kroah-Hartman wrote: > > It's only the systems that have panic-on-warn enabled that need to worry > > about user-triggered calls to that macro, and those systems know what > > they are getting themselves into, including the huge number of CVE fixes > > they then need to be responsible for backporting :) > > This is a bit of a rug pull. We've long held the pattern that WARN is an > appropriate macro for conditions that should never happen, but don't > leave the system in an unrecoverable or compromised state. For > unrecoverable conditions, use BUG. It has been a valuable tool for > debugging and bug reporting. Sure, that's fine, just don't have such a path that a user can trigger, and all is good. syzbot has been dealing with this for years, it's not a rug-pull at all. thanks, greg k-h