From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D36023CB567 for ; Fri, 31 Jul 2026 11:57:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785499078; cv=none; b=oMNdeuMi6iXkAMSy73ReGlueEmvXvqCXhsVI2Q9wYYHTuSzRx2gN0wCYaNG3sijm/aXtiwJBXCncwkuG4u+EpymVSoP7121fgZaN3++s3HFXrEWIxjfq1tpOueZP3ob/e8/fGniJdJXg3M7TgzRWkwRsswdTeSKVMaiOBYQnpIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785499078; c=relaxed/simple; bh=rdmdYMH2x++Ip0ojorw7l3QrxWNtPJvBUV4AjD3Yfr4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GFp4EF8urEZYbieF7NED4kMBNLcyuolFXndBYpCMUiPClWQlGeFWYT94d3k2EINIB8oM/zF4AlbaSp17+4BmMxdDo/sdjGdgoBUosd6i2h6fxNPdvLr5k7kQbW2B4HgAJNg4wjjdWSoELBFj0Av6WUiYa7cuWjxcpBwsQcvpUkY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=pc4Yywcm; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="pc4Yywcm" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=YzoQJ6AmlrH3orHeyfqBwZHpTshYUKv4cOhOLhYMmhw=; b=pc4Yywcm6NI7KbhOj7QNYbgNtv 8N44Ph/yRrDIfcb+dCtMiFXtxzbXpdEXNX7q5tg1S9bwBzIrp1v1mneeIGQb6vYOayuVbUwxRcJ95 ssldmQ9xJL2/I5KX0xpu4O1Glbid/A1TNM9O/LNJWFuBWyiPdRIFrCeJYjXqozfAtrxCW00A2cVak uiMeKEnjGDpqCGXybuZeYhSIWd4PCUsk8KZCDPcuI5FmiJBaO9ZUIEGV0YGLOREW5pqS7vDm/Dlif ra0MyaIPqBQNdqy5lSfYMO012sIWgxAZ+HsMF0VM7BRWFDRtO0JxeONWsqYZP+Udw4jTy98M5j/im 9Bg57lfA==; Received: from authenticated-user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1wplsA-009zcP-2u; Fri, 31 Jul 2026 11:57:55 +0000 From: Breno Leitao Date: Fri, 31 Jul 2026 04:57:33 -0700 Subject: [PATCH 1/6] workqueue: factor out get_percpu_pool() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260731-wq-pool-refactor-v1-1-8eaf71cdab5f@debian.org> References: <20260731-wq-pool-refactor-v1-0-8eaf71cdab5f@debian.org> In-Reply-To: <20260731-wq-pool-refactor-v1-0-8eaf71cdab5f@debian.org> To: Tejun Heo , Lai Jiangshan Cc: linux-kernel@vger.kernel.org, Breno Leitao , kernel-team@meta.com, marco.crivellari@suse.com X-Mailer: b4 0.16-dev-d5d98 X-Developer-Signature: v=1; a=openpgp-sha256; l=1943; i=leitao@debian.org; h=from:subject:message-id; bh=rdmdYMH2x++Ip0ojorw7l3QrxWNtPJvBUV4AjD3Yfr4=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBqbI286096eswp/d66bc7f2E7q4ABe+o/uOGnNn GsXLRXA9puJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCamyNvAAKCRA1o5Of/Hh3 bV2tD/9mU4kyDcRM9lpB2i5RcE4vQ57TNXFdwMKgdT7ol/AI1ZBlGay/V+ANlKvuBuVQGqGJniJ VYx4ZyvDpA9A0a0kQG2yx2zrOI4uV94xNgaG0vFtDy9XDUVq7kt0iHvI2Lb1t+tmdKLz5B5ohCD o47TMcCGLy3hIviq44dCRVATfUV2FQdGl8tZk54ziTRgrlPbFz0gBlCBt1Z+I0j89X3XZkxugC1 4uRfVLVuN8umqGKhyWiahmVK6lfAGXltEwZ7cNJFU9NXnAeT/j9lQRIk6bHFEdDT/KWb4K1JVbV +Ca8BZ/hq0648T1t7tPNwByIDYyCv0nwajXaWDedWK+hV9zOf2K32mCi6jIYlmVk7w/hTf9JC2h jxQw2VLUvGjdTHZfBhoyBCV1r0ksfACupe257HdWsm/EQHqm4FDQmDPbDkY1tvetyUCcIvICVy/ +XnThbxTxnDfM37ZtAoajrsb4EiaghZ9HS3Bn5wiDLkgZaLq2Yo5FTFfHP+SU342uTkL2SesuVK 9hrVyTh1He4F6e4cSumOHvPlJmDZ6Q0yQVR3vRXAtpWhMNxtIfp53UQ6X6n5a6rWydMrftaNCMh h8wXXUNMMje7IYZy7CF8KYtn8djhIDXZWKUIG4pruxqanOI/tLmcgH3WeMdGV6n4qpy3AyJMNWQ CHkxGZksYpKMFbQ== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao Move the static per-cpu worker_pool lookup in alloc_and_link_pwqs() into a helper, get_percpu_pool(), so the lookup can be shared by other pool-selection paths. No functional change. Signed-off-by: Breno Leitao --- kernel/workqueue.c | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 4ec3db31493d2..63a39bb3f5e47 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -5350,6 +5350,20 @@ static void link_pwq(struct pool_workqueue *pwq) list_add_tail_rcu(&pwq->pwqs_node, &wq->pwqs); } +/* Return the static per-cpu worker_pool that backs @wq on @cpu. */ +static struct worker_pool *get_percpu_pool(struct workqueue_struct *wq, int cpu) +{ + struct worker_pool __percpu *pools; + bool highpri = wq->flags & WQ_HIGHPRI; + + if (wq->flags & WQ_BH) + pools = bh_worker_pools; + else + pools = cpu_worker_pools; + + return &per_cpu_ptr(pools, cpu)[highpri]; +} + /* obtain a pool matching @attr and create a pwq associating the pool and @wq */ static struct pool_workqueue *alloc_unbound_pwq(struct workqueue_struct *wq, const struct workqueue_attrs *attrs) @@ -5664,19 +5678,9 @@ static int alloc_and_link_pwqs(struct workqueue_struct *wq) goto enomem; if (!(wq->flags & WQ_UNBOUND)) { - struct worker_pool __percpu *pools; - - if (wq->flags & WQ_BH) - pools = bh_worker_pools; - else - pools = cpu_worker_pools; - for_each_possible_cpu(cpu) { - struct pool_workqueue **pwq_p; - struct worker_pool *pool; - - pool = &(per_cpu_ptr(pools, cpu)[highpri]); - pwq_p = per_cpu_ptr(wq->cpu_pwq, cpu); + struct pool_workqueue **pwq_p = per_cpu_ptr(wq->cpu_pwq, cpu); + struct worker_pool *pool = get_percpu_pool(wq, cpu); *pwq_p = kmem_cache_alloc_node(pwq_cache, GFP_KERNEL, pool->node); -- 2.53.0-Meta